From: Jonas Karlman <jonas@kwiboo.se>
To: "dennis@ausil.us" <dennis@ausil.us>
Cc: FUKAUMI Naoki <naoki@radxa.com>, Hsun Lai <i@chainsx.cn>,
Chaoyi Chen <chaoyi.chen@rock-chips.com>,
John Clark <inindev@gmail.com>,
Michael Opdenacker <michael.opdenacker@rootcommit.com>,
Quentin Schulz <quentin.schulz@cherry.de>,
Andrew Lunn <andrew@lunn.ch>, Chukun Pan <amadeus@jmu.edu.cn>,
Alexey Charkov <alchark@gmail.com>,
Peter Robinson <pbrobinson@gmail.com>,
Michael Riesch <michael.riesch@collabora.com>,
Mykola Kvach <xakep.amatop@gmail.com>,
Jimmy Hon <honyuenkwun@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-rockchip@lists.infradead.org"
<linux-rockchip@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>
Subject: Re: [PATCH v5 2/3] arm64: dts: rockchip: refactor items from Orange Pi 5/b to prep for Pro
Date: Wed, 1 Apr 2026 16:05:40 +0200 [thread overview]
Message-ID: <d7e235c0-425e-4da6-a51e-5efdcac5a5f0@kwiboo.se> (raw)
In-Reply-To: <20260401010707.2584962-3-dennis@ausil.us>
Hi Dennis,
On 4/1/2026 3:07 AM, dennis@ausil.us wrote:
> From: Dennis Gilmore <dennis@ausil.us>
>
> The Orange Pi 5 Pro uses the same SoC and base as the Orange Pi 5 and
> Orange Pi 5B but has had sound, USB, and leds wired up differently. The
> boards also use gmac for ethernet where thre Pro has a PCIe attached NIC
>
> Signed-off-by: Dennis Gilmore <dennis@ausil.us>
> ---
> .../boot/dts/rockchip/rk3588s-orangepi-5.dts | 184 ++++++++++++++++
> .../boot/dts/rockchip/rk3588s-orangepi-5.dtsi | 202 ++----------------
> .../boot/dts/rockchip/rk3588s-orangepi-5b.dts | 181 ++++++++++++++++
> 3 files changed, 378 insertions(+), 189 deletions(-)
This patch seem to reintroduce a lot of duplication for the 5 and 5b
.dts-files. Please reduce the added duplication caused by this patch.
Maybe it is better to create a rk3588s-orangepi-5-base.dtsi or similar
where everything that is shared for all three boards is moved. Or the 5
an 5b specific parts are moved into a rk3588s-orangepi-5-5b.dtsi or
similar. Then the change in 5 and 5b board .dts-files are kept to a
minimum.
Regards,
Jonas
next prev parent reply other threads:[~2026-04-01 14:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-01 1:07 [PATCH v5 0/3] Add support for Orange Pi 5 Pro dennis
2026-04-01 1:07 ` [PATCH v5 1/3] dt-bindings: arm: rockchip: Add " dennis
2026-04-01 1:07 ` [PATCH v5 2/3] arm64: dts: rockchip: refactor items from Orange Pi 5/b to prep for Pro dennis
2026-04-01 11:52 ` Andrew Lunn
2026-04-01 13:27 ` Dennis Gilmore
2026-04-03 0:53 ` Andrew Lunn
2026-04-01 14:05 ` Jonas Karlman [this message]
2026-04-01 1:07 ` [PATCH v5 3/3] arm64: dts: rockchip: Add Orange Pi 5 Pro board support dennis
2026-04-01 9:51 ` Alexey Charkov
2026-04-01 11:56 ` Andrew Lunn
2026-04-01 13:29 ` Dennis Gilmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7e235c0-425e-4da6-a51e-5efdcac5a5f0@kwiboo.se \
--to=jonas@kwiboo.se \
--cc=alchark@gmail.com \
--cc=amadeus@jmu.edu.cn \
--cc=andrew@lunn.ch \
--cc=chaoyi.chen@rock-chips.com \
--cc=conor+dt@kernel.org \
--cc=dennis@ausil.us \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=honyuenkwun@gmail.com \
--cc=i@chainsx.cn \
--cc=inindev@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.opdenacker@rootcommit.com \
--cc=michael.riesch@collabora.com \
--cc=naoki@radxa.com \
--cc=pbrobinson@gmail.com \
--cc=quentin.schulz@cherry.de \
--cc=robh@kernel.org \
--cc=xakep.amatop@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®