From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CAFEC1DF242 for ; Fri, 13 Dec 2024 11:34:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734089669; cv=none; b=HAmvNgx98hvdTquSTpVWSt7pnQunXPNM2/fOB4TiXrbM4sKp3YaR0G1U/gfj05xyLMkrcP6P5FBGOC4lEP/w265HvD9NbPEo8ejvxkoYJ0skKNasJUP5Ri+VfyRuLgng5SOyEdxO/QfwfySP5Q/v1V+pQbVSLZO78IJwPyxSAEM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734089669; c=relaxed/simple; bh=4XfO9sgRR89Q+W9l3UVT/d7WgRINh0RFlj7iisUzSSY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=qZjCxfwD92xx10oMSr3begBISWtUrsxdV8mzAzrm0Ls0Cs7CSm/eiBX0rBd87onXFbGYDfHoRgY3hekboBpMmTsphqwK1nKD1Qi7zsb4IKYt8vyreHfVhQJlaqM96MKEr3b6R0VHwIAHq2PsDSqUhNb2wr0ex40G8R0hsBINBuM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=t8yg3K4H; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="t8yg3K4H" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4361b0ec57aso15582525e9.0 for ; Fri, 13 Dec 2024 03:34:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1734089666; x=1734694466; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=VoLSaqzOSgXTHhnrnBIXiVWZQerMmrmkF4OQm6gfaXQ=; b=t8yg3K4HuJOQUWWwhafEpqBrJaKiZKZmA5y1s36J0W4dUmZmLI6y0nzF0S3u5eBbyU thHcVU5L+OdrrnXZft4OTJK6APLOMrD7jaWmsFZvZZiPKuCTFXsk9h6NiezLuJej3QYj fTrLxnSXOFrlgQGNxRbrA3KuUWmqK9Y6lx64vnsvFfEuZ6aGYDwNZ0YJGQyfi/0dtdVS 6fGEyGW7vBg3j/yLwMHqZjiRs2PIIU4wUQ+qjAR6irmZU/EowyNM7Ph7/KEky7hXLM2L ZkiKZldsU9dpj2bvjOPaPHH5jYUF5dd15Lv/1UzXWDk1w458WwHAQfhAXRL3DZaBJL+D v0/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734089666; x=1734694466; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VoLSaqzOSgXTHhnrnBIXiVWZQerMmrmkF4OQm6gfaXQ=; b=u45whVFOky6zUwuP9JhQcZdesOtAyZTbC+52ASs7U8AVRNTvW5Vj+Xj63GKa+H4d+B enuoRUeWMdz/TpMUUvFNOJszLk1yP4MSUfYPv6onJAnoBNYbWJwWDo3hJax6Ij2ZC3WY QZ9ukrSrDI1soy+Fr7nTFBQi62hFd+Kvln/WA2BhGegvablb9HANEY6BgKyRpGOEZcBW dxiJV6e+ll/CNCxZkddT6mIVtIRKSgoicYTkWZzm2Yo9b8HcUvdnWLrPdhYWkwrTRw2O z2m/IgU9XRE70TV5o0I7/rs93VLZ6QNZxysKzKUpwKXnc6zeJtYuWqSBRTqPKdLFnu4X S5+g== X-Forwarded-Encrypted: i=1; AJvYcCUp51GE2B9YzZObHtbo313ruW01WoS7SZMXDeioBiPQEqze5pAOZ+ybW7oeObrWMLVG/4DxEYNPEDhcI/8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz137xozpcBVTYBrfPoWjp4Q5VazoqI5fL7VVqJTj1mFTB/ssBL IrFP6xCeUQ4Wr086pubyHrwHlFQFJDvr+pUwITCm8zOLNKkGuVp0rkaDtTHqICs= X-Gm-Gg: ASbGnct2KBf3nMDdzZK2hS3qr5VilAYdHvyHsdkcMl0ueySAofDBRjbX8p/drNixvTv J753s8+/AzRKdIvRhFPTGWc/ikWQaOHKSK9hJ0pb1eh+NlEmFLHY1xXLGVtNWHgyH+WBAX6X7vu KqAjYtBdILVoxRm+rjxoCLC/6Za1+EpM5FG10MxMQ1LKju6iBNcFuwZ+G8cGE98GtTMYTG39CYb DUD9Q/C0W72MZxpsKau0wmmB1iSKLT/khIdYkFlzp7iyf3XY/LD3hn8kWUpm3w4LO/WSA== X-Google-Smtp-Source: AGHT+IFa8ec15w1W+mCJa8qiRjb8wSbVwQDAXu4RYHaXXbcgV53ag8xsVJvsFwXS3y/+5di8npaPTQ== X-Received: by 2002:a05:600c:384e:b0:431:12a8:7f1a with SMTP id 5b1f17b1804b1-4362aa52e39mr20921645e9.16.1734089666146; Fri, 13 Dec 2024 03:34:26 -0800 (PST) Received: from [192.168.0.40] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-387824ca9absm6818336f8f.61.2024.12.13.03.34.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Dec 2024 03:34:25 -0800 (PST) Message-ID: Date: Fri, 13 Dec 2024 11:34:24 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] media: dt-bindings: media: camss: Restrict bus-type property To: Luca Weiss , Vladimir Zapolskiy , Krzysztof Kozlowski Cc: Robert Foss , Todor Tomov , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Barnabas Czeman , AngeloGioacchino Del Regno , Caleb Connolly , David Heidelberg , ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241209-camss-dphy-v1-0-5f1b6f25ed92@fairphone.com> <20241209-camss-dphy-v1-1-5f1b6f25ed92@fairphone.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 13/12/2024 11:24, Luca Weiss wrote: > On Fri Dec 13, 2024 at 11:50 AM CET, Vladimir Zapolskiy wrote: >> On 12/13/24 11:34, Krzysztof Kozlowski wrote: >>> On Mon, Dec 09, 2024 at 01:01:05PM +0100, Luca Weiss wrote: >>>> The CSIPHY of Qualcomm SoCs support both D-PHY and C-PHY standards for >>>> CSI-2, but not any others so restrict the bus-type property describing >>>> this to the supported values. >>>> >>>> The only exception here is MSM8916 which only supports D-PHY. C-PHY was >>>> introduced with newer SoCs. >>>> >>>> Do note, that currently the Linux driver only supports D-PHY. >>>> >>>> Signed-off-by: Luca Weiss >>>> --- >>>> .../bindings/media/qcom,msm8916-camss.yaml | 8 ++++++ >>>> .../bindings/media/qcom,msm8953-camss.yaml | 15 +++++++++++ >>>> .../bindings/media/qcom,msm8996-camss.yaml | 20 +++++++++++++++ >>>> .../bindings/media/qcom,sc8280xp-camss.yaml | 20 +++++++++++++++ >>>> .../bindings/media/qcom,sdm660-camss.yaml | 20 +++++++++++++++ >>>> .../bindings/media/qcom,sdm845-camss.yaml | 20 +++++++++++++++ >>>> .../bindings/media/qcom,sm8250-camss.yaml | 30 ++++++++++++++++++++++ >>>> 7 files changed, 133 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml >>>> index 9cc0a968a401836814560c1af3ee84d946500b4f..3de2a3d2b5b761106975aab65ff614b2ef579ef5 100644 >>>> --- a/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml >>>> +++ b/Documentation/devicetree/bindings/media/qcom,msm8916-camss.yaml >>>> @@ -94,6 +94,10 @@ properties: >>>> minItems: 1 >>>> maxItems: 4 >>>> >>>> + bus-type: >>>> + enum: >>>> + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY >>>> + >>>> required: >>>> - data-lanes >>>> >>>> @@ -113,6 +117,10 @@ properties: >>>> minItems: 1 >>>> maxItems: 4 >>>> >>>> + bus-type: >>>> + enum: >>>> + - 4 # MEDIA_BUS_TYPE_CSI2_DPHY >>>> + >> >> But is it really needed to specify the single supported bus-type? >> >> I believe it is not, at least it's not ever done for other media devices >> like sensors. > > Through video-interfaces.yaml 'bus-type' is already allowed but not > restricted to the values that actually make any sense on such hardware, > so in my opinion this makes sense to have here. This is additive not prescriptive. New additions should include this bus-type number as we will need it when we add CPHY support and the subsequently move to the PHY API for CAMSS PHYs. So still in favour of this amendment. --- bod