From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 017172222CB for ; Tue, 18 Nov 2025 08:44:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763455455; cv=none; b=Q7/Kl+dRiZGYA1iIs8QfN/1edt/zwvWzTC+9QQSDo4OF6c/tsSb8n1YGPf9W1e/KfFo+05u7Mvkyhthj6Rg0B5rCNqJJakYmi52o435ax2zjwSWZp4DDfkedy7GctEwFQIYo6PAmeISPej4bpbKpBcRhlPonXKwh9OR/WWRcbCA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763455455; c=relaxed/simple; bh=Fw0r4SJQA4YB69HhgO73OVyQnIuz/pqnRNkRaw++LdA=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=N7uCkxZwoj1ZpWL5pCHD3TuArORnvSGWwzDOA1sD9ZzIqvyOrKSlyksUorpzU6JUHML/WX/b/H4PZKIcRag0ffKtib+mBC3mXWphHflV3O9Q8D/RET6lWW3L3bV+r4jLpmE9sAmTz104hlE6dYLoKb1sB+9yoHLvK+O9HPTk6Yg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=h3UyyVt0; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="h3UyyVt0" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-42b39d51dcfso2880084f8f.2 for ; Tue, 18 Nov 2025 00:44:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1763455452; x=1764060252; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=skPvgKgOzKLBLcTYhsTuqCFv5N46l8HCKNcS62pDJuU=; b=h3UyyVt04npoW0M4TTRXEc5i/ADPoTSmWBvat5CEU2QO5ar86dVonimwI9SHtLFzZ4 wyLq6iMuEMZqnq87843X2iwMz52o86KhvRSocl2X5yOFzOzX2GWbYh8RkpWltamvjpeS aQu7mgtfYEX0aO6NUzJlWfcZypdb1ETOwSWBj8DB6cWELEWlhPpRnl9GQqFYSrFrD7iP bvlzjJ2jGQColqLqykK+dSOeIonPsNYYPSz98eBNVUqGqrhvNIOnndgICXRAAYxCNpiW OsWhWw8FMJ3VIHNsK2NUq6aSR/h3yroObPulwkVyQA3J9RTauN5z5Gp4B9QcW06AwX47 wJhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763455452; x=1764060252; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=skPvgKgOzKLBLcTYhsTuqCFv5N46l8HCKNcS62pDJuU=; b=vOd1aV2s6bnNc/qWd2bKUvEHXAhpxAYCecZUyiIaERVwT2iVwmDSI3aRp6T9rl2ipN 9tBYXNvVC8Wp4acxN75IRKeCVs7W+/VsgiV8uXJ/v+QxiHqZKohCRlbKisNfvcnjFOOS F9Sc4IQFzRDv48TgsmyQo2YeJV2wdA+CDJSAQC3e6IT6T+vvYSk7U+ZSnkRV45rN0ifZ +G43t0ca4TntB/1AffKYibfhHIhmrws1d0LV0llZQepXwfle8jW2i5kWy9mrOnuHm2H/ f/zH3GgDUhOOv5zjM3YSIbKnDOPar4Zr2JYpMFHKIRL4uJ8+7+I90sT+SgdsKNQ75j9i /dqg== X-Forwarded-Encrypted: i=1; AJvYcCWXiweDeNS/7la4eZLkUT7q9m167p31/rYwP1IHqoAHzEwC3+xdbNLOpZxFDNzRQDqB4HCKNy8tlHQRhW4=@vger.kernel.org X-Gm-Message-State: AOJu0Yywnqpjs9gXj/Fb4igE+K2Az8bw1puxBZZoOvy/sqP28YzMaR+U O1P9qLNlJWGhpvnWtq8clQ9WPMyM0UGTOQbeh0+mkqEtflaioIQwUYX3KlMq9/9bI+A= X-Gm-Gg: ASbGncvV1E2bQhMvtMZ+OKtOd1EjYfIjjeWVcVExFRW2F3UnC1Xlk3PyDl6vnxdaw4P jgxXB8Yssot6WPSOUs6JQWlipDxf7CVH+OJZ66e2OrYJcOxjxHgDnlgOUnAKuT59cJ8pfUCMc0K oA94ruCYH1oo+915vGSx0vxBc5loC6HkJV6Ip/TyiqUiYZegRejmaQyzPA907i4bSL4XHzkrgMJ P5TEQbetWJbQQSCTUyoL2naA/l6IXAP6oswR/R309eDIggjB8kdldjFjrlYoRroyW/gWjxA42Xf Z1kgNSplVz3QDuAcWlTAismB68SvoMSBrUKDYRqFZWpwKOc5TOmwgHw2d2tBbTXRtLInnoH6ZIs q2J/eUHwl6V3OZQky3UEywteouE1O6rEIqG1DeeCulf9iGYe/SzUSWyvHhdczi2B9mq2pQxiChw CjnyaNb/MzikpCraNQz4gAbu8/Ha+5sNjwbVBbDG5bJcIDNDpH+oVr1aXmx1dY8sF2eZlamk6QU w== X-Google-Smtp-Source: AGHT+IEQmNMAhg7c5ylKpz3XgzZvskAD6S8nCFrFxxaR1yFJHrnMGgU4L4pcdpl7dbKF7g6zIn94Og== X-Received: by 2002:a05:6000:2083:b0:42b:3867:b39c with SMTP id ffacd0b85a97d-42b593745c4mr14643424f8f.34.1763455452210; Tue, 18 Nov 2025 00:44:12 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:366e:5264:fffe:1c49? ([2a01:e0a:3d9:2080:366e:5264:fffe:1c49]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-42b53f1fd50sm30639426f8f.38.2025.11.18.00.44.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 00:44:11 -0800 (PST) Message-ID: Date: Tue, 18 Nov 2025 09:44:10 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: Neil Armstrong Subject: Re: [PATCH] drm/panel: jadard-jd9365da-h3: Use dev_err_probe() instead of DRM_DEV_ERROR() during probing To: Abhishek Rajput , jagan@edgeble.ai, jessica.zhang@oss.qualcomm.com, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20251117064702.222424-1-abhiraj21put@gmail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20251117064702.222424-1-abhiraj21put@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/17/25 07:47, Abhishek Rajput wrote: > The DRM_DEV_ERROR() has been deprecated, and use dev_err_probe() > can be better. The other reason is that dev_err_probe() help avoid > unexpected repeated err logs during defered probing. > > Signed-off-by: Abhishek Rajput > > diff --git a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c > index 5c2530598ddb..aa05316dc57b 100644 > --- a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c > +++ b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c > @@ -1132,22 +1132,19 @@ static int jadard_dsi_probe(struct mipi_dsi_device *dsi) > dsi->lanes = desc->lanes; > > jadard->reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH); > - if (IS_ERR(jadard->reset)) { > - DRM_DEV_ERROR(&dsi->dev, "failed to get our reset GPIO\n"); > - return PTR_ERR(jadard->reset); > - } > + if (IS_ERR(jadard->reset)) > + return dev_err_probe(&dsi->dev, PTR_ERR(jadard->reset), > + "failed to get our reset GPIO\n"); > > jadard->vdd = devm_regulator_get(dev, "vdd"); > - if (IS_ERR(jadard->vdd)) { > - DRM_DEV_ERROR(&dsi->dev, "failed to get vdd regulator\n"); > - return PTR_ERR(jadard->vdd); > - } > + if (IS_ERR(jadard->vdd)) > + return dev_err_probe(&dsi->dev, PTR_ERR(jadard->vdd), > + "failed to get vdd regulator\n"); > > jadard->vccio = devm_regulator_get(dev, "vccio"); > - if (IS_ERR(jadard->vccio)) { > - DRM_DEV_ERROR(&dsi->dev, "failed to get vccio regulator\n"); > - return PTR_ERR(jadard->vccio); > - } > + if (IS_ERR(jadard->vccio)) > + return dev_err_probe(&dsi->dev, PTR_ERR(jadard->vccio), > + "failed to get vccio regulator\n"); > > ret = of_drm_get_panel_orientation(dev->of_node, &jadard->orientation); > if (ret < 0) Reviewed-by: Neil Armstrong