From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 892DFC433F5 for ; Sun, 27 Feb 2022 21:51:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231922AbiB0Vwa (ORCPT ); Sun, 27 Feb 2022 16:52:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39418 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229901AbiB0Vw1 (ORCPT ); Sun, 27 Feb 2022 16:52:27 -0500 Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4C5466FB6 for ; Sun, 27 Feb 2022 13:51:49 -0800 (PST) Received: by mail-pf1-x430.google.com with SMTP id z15so9321855pfe.7 for ; Sun, 27 Feb 2022 13:51:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=T+bY3cSVQwU97rpm1PWOkOKMCijaJDttt0NtP9XMRUQ=; b=P5MaDUXk16z8/hpH693B2xHSHZo//ZReUYLWsO5WmQlLEtpjLdqZ3SxcShABucESWD gkUDZcqvtqrxzTL/HBznk0KrejYwIAj3HoxYQalVeG1HxDmq/YLbpu9NlB4P6TirmJj2 tNdNIV6wYGqY82VLMA+Mw5GUbyS0jOd/itE8dHkrcVdM9Bb6L95gorWOa8zYmgsddC8h zwCoc5DjwY/j3Rg7vXTyev4iXasdo5AcMBQ1q6scfujWk+AKpoL3W0XrcjyD40Gt2MbI /8viux9vd/q2pOFj2lly3had36ZTNzGSAeWkdFCorEsxqkjHFwoed3w28lUUMVXaTzda BIcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=T+bY3cSVQwU97rpm1PWOkOKMCijaJDttt0NtP9XMRUQ=; b=u5clBpOP38Z/2NsY7UEO9QtW1O48H9qwvHlkEQrW543o34XKVI3xuI8EHNmplErNYw idUQsryUJgS6aV6nGBHo0T3y89MqUpoxyScHy6ss4mtQaE+0B2Qz9WRlJ7ZmdxgvozJ8 wkh+xyUR0HaTmPQ0JoPf2qfgYwEm/IOBZ1pI0oT2d3KtH/j7NhRGJxZd2nHEBRprYlXZ IWn6LXxXT9Yp8CQIalVjQrRB1zqJoe/L0WCtJMcdqgxz83MD1wWYqNYDczKjOP+SVMCr DoX2rpt7mMYyoSFP82IX7KBO+FZbf1eVCT5a2nJw59eLOo1XehZE/9deCxaRCpvDS4iq L08A== X-Gm-Message-State: AOAM531jXRbFg2RrVmuyORQUtJQV0LP8Goh9LQvZJuVcVZlKt0LT5ONN le2cPXHeADgFA++kiJbTxrs5MQ== X-Google-Smtp-Source: ABdhPJw5iyelAy8Y8e7UDBvu5VGI0R9LRLKgwMaAMReYVGgkCIixIT0k5CsicGBwZOju4r6toco/bw== X-Received: by 2002:a63:221f:0:b0:374:7286:446a with SMTP id i31-20020a63221f000000b003747286446amr14756264pgi.538.1645998709137; Sun, 27 Feb 2022 13:51:49 -0800 (PST) Received: from [192.168.4.166] (cpe-72-132-29-68.dc.res.rr.com. [72.132.29.68]) by smtp.gmail.com with ESMTPSA id v23-20020a17090a521700b001bbfc181c93sm15037230pjh.19.2022.02.27.13.51.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 27 Feb 2022 13:51:48 -0800 (PST) Message-ID: Date: Sun, 27 Feb 2022 14:51:46 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v9] block: cancel all throttled bios in del_gendisk() Content-Language: en-US To: Christoph Hellwig , Yu Kuai Cc: ming.lei@redhat.com, tj@kernel.org, cgroups@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, yi.zhang@huawei.com References: <20220210115637.1074927-1-yukuai3@huawei.com> From: Jens Axboe In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/27/22 10:16 AM, Christoph Hellwig wrote: > On Thu, Feb 10, 2022 at 07:56:37PM +0800, Yu Kuai wrote: >> Throttled bios can't be issued after del_gendisk() is done, thus >> it's better to cancel them immediately rather than waiting for >> throttle is done. >> >> For example, if user thread is throttled with low bps while it's >> issuing large io, and the device is deleted. The user thread will >> wait for a long time for io to return. > > FYI, this crashed left rigt and center when running xfstests with > traces pointing to throtl_pending_timer_fn. Dropped for now. -- Jens Axboe