Re: [PATCH v2 2/2] drm/nouveau: nouveau_fence: Standardize list iterations

["Christian König" <christian.koenig@amd.com>]

Am 15.04.25 um 14:19 schrieb Philipp Stanner:
> nouveau_fence.c iterates over lists in a non-canonical way. Since the
> operations done are just basic for-each-loops, they should be written in
> the standard form.
>
> Use for_each_safe() instead of the custom loop iterations.
>
> Signed-off-by: Philipp Stanner <phasta@kernel.org>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>  drivers/gpu/drm/nouveau/nouveau_fence.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b/drivers/gpu/drm/nouveau/nouveau_fence.c
> index 6ded8c2b6d3b..60d961b43488 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_fence.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_fence.c
> @@ -84,11 +84,12 @@ void
>  nouveau_fence_context_kill(struct nouveau_fence_chan *fctx, int error)
>  {
>  	struct nouveau_fence *fence;
> +	struct list_head *pos, *tmp;
>  	unsigned long flags;
>  
>  	spin_lock_irqsave(&fctx->lock, flags);
> -	while (!list_empty(&fctx->pending)) {
> -		fence = list_entry(fctx->pending.next, typeof(*fence), head);
> +	list_for_each_safe(pos, tmp, &fctx->pending) {
> +		fence = list_entry(pos, struct nouveau_fence, head);
>  
>  		if (error && !dma_fence_is_signaled_locked(&fence->base))
>  			dma_fence_set_error(&fence->base, error);
> @@ -131,11 +132,12 @@ static int
>  nouveau_fence_update(struct nouveau_channel *chan, struct nouveau_fence_chan *fctx)
>  {
>  	struct nouveau_fence *fence;
> +	struct list_head *pos, *tmp;
>  	int drop = 0;
>  	u32 seq = fctx->read(chan);
>  
> -	while (!list_empty(&fctx->pending)) {
> -		fence = list_entry(fctx->pending.next, typeof(*fence), head);
> +	list_for_each_safe(pos, tmp, &fctx->pending) {
> +		fence = list_entry(pos, struct nouveau_fence, head);
>  
>  		if ((int)(seq - fence->base.seqno) < 0)
>  			break;