From: Florian Fainelli <f.fainelli@gmail.com>
To: Chen-Yu Tsai <wens@kernel.org>,
Markus Mayer <mmayer@broadcom.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Zhang Rui <rui.zhang@intel.com>,
Eduardo Valentin <edubezval@gmail.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Amit Kucheria <amit.kucheria@verdurent.com>
Cc: Chen-Yu Tsai <wens@csie.org>,
bcm-kernel-feedback-list@broadcom.com, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thermal: brcmstb: enable hwmon
Date: Wed, 30 Oct 2019 10:15:19 -0700 [thread overview]
Message-ID: <d7f3c6fa-4785-bf9a-b83f-d19448412d0f@gmail.com> (raw)
In-Reply-To: <6c681697-c9ad-02a1-8289-fa265cea36c8@broadcom.com>
On 10/30/19 9:57 AM, Florian Fainelli wrote:
> Hi Chen-Yu,
>
> On 10/30/19 9:38 AM, Chen-Yu Tsai wrote:
>> From: Chen-Yu Tsai <wens@csie.org>
>>
>> By defaul of-based thermal driver do not have hwmon entries registered.
>>
>> Do this explicitly so users can use standard hwmon interfaces and tools
>> to read the temperature.
>>
>> This is based on similar changes for bcm2835_thermal in commit
>> d56c19d07e0b ("thermal: bcm2835: enable hwmon explicitly").
>>
>> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
>
> Tested-by: Florian Fainelli <f.fainelli@gmail.com>
>
> There a number of patches that I need to get upstream from our
> downstream tree, because right now the temperatures reported are note
> quite in the expected units..
Oh yes, because we call the standard thermal framework helpers to
extract the coefficients, and we never made that a mandatory property,
so our firmware does not provide that information and the raw DAC code
is not properly converted, will fix that as well.
--
Florian
next prev parent reply other threads:[~2019-10-30 17:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 16:38 Chen-Yu Tsai
2019-10-30 16:57 ` Florian Fainelli
2019-10-30 17:15 ` Florian Fainelli [this message]
2019-10-31 13:08 ` Stefan Wahren
2019-11-01 3:01 ` Florian Fainelli
2019-11-01 3:04 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d7f3c6fa-4785-bf9a-b83f-d19448412d0f@gmail.com \
--to=f.fainelli@gmail.com \
--cc=amit.kucheria@verdurent.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mmayer@broadcom.com \
--cc=rui.zhang@intel.com \
--cc=wens@csie.org \
--cc=wens@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®