Re: [PATCH v2 5/7] docs: nova-core: Document devinit process

[Joel Fernandes <joelagnelf@nvidia.com>]

On 5/5/2025 12:04 AM, Bagas Sanjaya wrote:
> On Sat, May 03, 2025 at 12:07:57AM -0400, Joel Fernandes wrote:
>> +.. SPDX-License-Identifier: GPL-2.0
>> +==================================
>> +Device Initialization (devinit)
>> +==================================
> 
> Separate SPDX line from title heading.
> 
>> +These low-level GPU firmware components are typically:
>> +1. Located in the VBIOS ROM in the same ROM partition (see vbios.rst and fwsec.rst).
>> +2. Executed in sequence on different microcontrollers:
>> +   - The devinit engine typically but not necessarily runs on the PMU.
>> +   - On an Ampere GPU, the FWSEC typically runs on the GSP (GPU System Processor) in
>> +     heavy-secure mode.
> 
> Please separate numbered list from preceding sentence, and the bullet sublist
> from parent numbered list by a line.
> 
>> +Runtime Considerations
>> +---------------------
>> <snipped>...
>> +Security and Access Control
>> +--------------------------
> 
> Match section underline length with the text.
Thanks a lot for finding these issues. I have fixed everything and will re-post
patches end of the week. Please let me know if I can add your Tested-by tag.

Also here is my tree with the changes for a preview (top 7 patches):
https://git.kernel.org/pub/scm/linux/kernel/git/jfern/linux.git/log/?h=nova-docs

thanks,

 - Joel