From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45B58C433E6 for ; Mon, 31 Aug 2020 03:16:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1E5DC20CC7 for ; Mon, 31 Aug 2020 03:16:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727054AbgHaDQQ (ORCPT ); Sun, 30 Aug 2020 23:16:16 -0400 Received: from mga03.intel.com ([134.134.136.65]:12325 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726573AbgHaDQQ (ORCPT ); Sun, 30 Aug 2020 23:16:16 -0400 IronPort-SDR: ESzTFRpugYU2SxXZdElFv8c1C2YCxwQW7dwfKE4HQ3vBHG/EPGo+EvRnvGbtu/O4vX+TPN6lth FpnjyfYyVO7Q== X-IronPort-AV: E=McAfee;i="6000,8403,9729"; a="156907775" X-IronPort-AV: E=Sophos;i="5.76,374,1592895600"; d="scan'208";a="156907775" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2020 20:16:15 -0700 IronPort-SDR: wHt5yS4zUxncIxFJ9UJ3TqdAGzxMZwOzgjOE1KllM3VIZVFlH0o7kMFgP6XZbMnhWgPzVztZhf OIe1Pz2NlQng== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.76,374,1592895600"; d="scan'208";a="330564381" Received: from cqiang-mobl.ccr.corp.intel.com (HELO [10.238.2.93]) ([10.238.2.93]) by orsmga008.jf.intel.com with ESMTP; 30 Aug 2020 20:16:12 -0700 Subject: Re: [PATCH 2/5] KVM: nVMX: Verify the VMX controls MSRs with the global capability when setting VMX MSRs To: Jim Mattson Cc: Paolo Bonzini , Sean Christopherson , Vitaly Kuznetsov , Wanpeng Li , Joerg Roedel , Xiaoyao Li , kvm list , LKML References: <20200828085622.8365-1-chenyi.qiang@intel.com> <20200828085622.8365-3-chenyi.qiang@intel.com> From: Chenyi Qiang Message-ID: Date: Mon, 31 Aug 2020 11:15:50 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/29/2020 2:23 AM, Jim Mattson wrote: > On Fri, Aug 28, 2020 at 1:54 AM Chenyi Qiang wrote: >> >> When setting the nested VMX MSRs, verify it with the values in >> vmcs_config.nested_vmx_msrs, which reflects the global capability of >> VMX controls MSRs. >> >> Signed-off-by: Chenyi Qiang > > You seem to have entirely missed the point of this code, which is to > prevent userspace from adding features that have previously been > removed for this vCPU (e.g as a side-effect of KVM_SET_CPUID). > We only have the case that the scope of features set by userspace is always reduced, right? If so, we don't need the change here.