From: Johannes Berg <johannes@sipsolutions.net>
To: Aleksandr Nesterenko <alexandernesterenko837@gmail.com>,
jeff.johnson@oss.qualcomm.com, davem@davemloft.net,
kuba@kernel.org
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: ath9k: add range check for epid in htc_issue_send()
Date: Fri, 30 Jan 2026 14:25:05 +0100 [thread overview]
Message-ID: <d8026b7f005a4d20562983e344d70d3d6f72d82a.camel@sipsolutions.net> (raw)
In-Reply-To: <20260130125915.47036-1-alexandernesterenko837@gmail.com>
On Fri, 2026-01-30 at 13:59 +0100, Aleksandr Nesterenko wrote:
>
> While htc_connect_service() now validates the endpoint ID before storing
> it, htc_issue_send() can still receive invalid epid values from callers
> such as htc_send() and htc_send_epid().
I'm not convinced, what makes you think so?
Arguably, even the prior fix was somewhat confusing, because it used the
ENDPOINT_MAX value as an indicator that the response wasn't success,
could have checked that more explicitly.
(And why did you send the same thing three times in 6 minutes?!)
johannes
next prev parent reply other threads:[~2026-01-30 13:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-30 12:59 Aleksandr Nesterenko
2026-01-30 13:25 ` Johannes Berg [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-01-30 12:56 Aleksandr Nesterenko
2026-01-30 12:53 Aleksandr Nesterenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8026b7f005a4d20562983e344d70d3d6f72d82a.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=alexandernesterenko837@gmail.com \
--cc=davem@davemloft.net \
--cc=jeff.johnson@oss.qualcomm.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®