From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753855AbdA3Qx6 (ORCPT ); Mon, 30 Jan 2017 11:53:58 -0500 Received: from mx2.suse.de ([195.135.220.15]:48351 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751878AbdA3Qxv (ORCPT ); Mon, 30 Jan 2017 11:53:51 -0500 Subject: Re: [PATCH 7/9] md: use kvmalloc rather than opencoded variant To: Michal Hocko , Andrew Morton References: <20170130094940.13546-1-mhocko@kernel.org> <20170130094940.13546-8-mhocko@kernel.org> Cc: David Rientjes , Mel Gorman , Johannes Weiner , Al Viro , linux-mm@kvack.org, LKML , Michal Hocko , Mikulas Patocka , Mike Snitzer From: Vlastimil Babka Message-ID: Date: Mon, 30 Jan 2017 17:42:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <20170130094940.13546-8-mhocko@kernel.org> Content-Type: text/plain; charset=iso-8859-2; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/30/2017 10:49 AM, Michal Hocko wrote: > From: Michal Hocko > > copy_params uses kmalloc with vmalloc fallback. We already have a helper > for that - kvmalloc. This caller requires GFP_NOIO semantic so it hasn't > been converted with many others by previous patches. All we need to > achieve this semantic is to use the scope memalloc_noio_{save,restore} > around kvmalloc. > > Cc: Mikulas Patocka > Cc: Mike Snitzer > Signed-off-by: Michal Hocko Acked-by: Vlastimil Babka > --- > drivers/md/dm-ioctl.c | 13 ++++--------- > 1 file changed, 4 insertions(+), 9 deletions(-) > > diff --git a/drivers/md/dm-ioctl.c b/drivers/md/dm-ioctl.c > index a5a9b17f0f7f..dbf5b981f7d7 100644 > --- a/drivers/md/dm-ioctl.c > +++ b/drivers/md/dm-ioctl.c > @@ -1698,6 +1698,7 @@ static int copy_params(struct dm_ioctl __user *user, struct dm_ioctl *param_kern > struct dm_ioctl *dmi; > int secure_data; > const size_t minimum_data_size = offsetof(struct dm_ioctl, data); > + unsigned noio_flag; > > if (copy_from_user(param_kernel, user, minimum_data_size)) > return -EFAULT; > @@ -1720,15 +1721,9 @@ static int copy_params(struct dm_ioctl __user *user, struct dm_ioctl *param_kern > * Use kmalloc() rather than vmalloc() when we can. > */ > dmi = NULL; > - if (param_kernel->data_size <= KMALLOC_MAX_SIZE) > - dmi = kmalloc(param_kernel->data_size, GFP_NOIO | __GFP_NORETRY | __GFP_NOMEMALLOC | __GFP_NOWARN); > - > - if (!dmi) { > - unsigned noio_flag; > - noio_flag = memalloc_noio_save(); > - dmi = __vmalloc(param_kernel->data_size, GFP_NOIO | __GFP_HIGH | __GFP_HIGHMEM, PAGE_KERNEL); > - memalloc_noio_restore(noio_flag); > - } > + noio_flag = memalloc_noio_save(); > + dmi = kvmalloc(param_kernel->data_size, GFP_KERNEL); > + memalloc_noio_restore(noio_flag); > > if (!dmi) { > if (secure_data && clear_user(user, param_kernel->data_size)) >