From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B41B6C433E0 for ; Tue, 9 Mar 2021 09:13:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7FFA46513E for ; Tue, 9 Mar 2021 09:13:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230058AbhCIJNA convert rfc822-to-8bit (ORCPT ); Tue, 9 Mar 2021 04:13:00 -0500 Received: from eu-smtp-delivery-151.mimecast.com ([185.58.86.151]:47683 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229639AbhCIJMp (ORCPT ); Tue, 9 Mar 2021 04:12:45 -0500 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-65-IhmyWhliOq6NmMDXu6s74g-1; Tue, 09 Mar 2021 09:12:42 +0000 X-MC-Unique: IhmyWhliOq6NmMDXu6s74g-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Tue, 9 Mar 2021 09:12:41 +0000 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Tue, 9 Mar 2021 09:12:40 +0000 From: David Laight To: 'Andy Shevchenko' , Marco Elver CC: Petr Mladek , Geert Uytterhoeven , Linux Kernel Mailing List , Vlastimil Babka , Timur Tabi , Steven Rostedt , Sergey Senozhatsky , Rasmus Villemoes Subject: RE: [PATCH 2/2] lib/vsprintf: reduce space taken by no_hash_pointers warning Thread-Topic: [PATCH 2/2] lib/vsprintf: reduce space taken by no_hash_pointers warning Thread-Index: AQHXFEobJ7Swwp6RcU2yBDODqe2J7ap7X8pg Date: Tue, 9 Mar 2021 09:12:40 +0000 Message-ID: References: <20210305194206.3165917-1-elver@google.com> <20210305194206.3165917-2-elver@google.com> In-Reply-To: Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ... > On Mon, Mar 08, 2021 at 07:23:34PM +0100, Marco Elver wrote: > > On Mon, 8 Mar 2021 at 18:23, Petr Mladek wrote: > > > > - pr_warn("**********************************************************\n"); > > > - pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n"); > > > - pr_warn("** **\n"); > > > - pr_warn("** This system shows unhashed kernel memory addresses **\n"); > > > - pr_warn("** via the console, logs, and other interfaces. This **\n"); > > > - pr_warn("** might reduce the security of your system. **\n"); > > > - pr_warn("** **\n"); > > > - pr_warn("** If you see this message and you are not debugging **\n"); > > > - pr_warn("** the kernel, report this immediately to your system **\n"); > > > > While we're here: This paragraph can be shortened by saying what > > kernel/trace/trace.c says ("..., report this immediately to your > > vendor!") which avoids the "administrator! ". > > Aren't we discussed that and the point was that kernel configuration option is > in administrator's realm? > > > > - pr_warn("** administrator! **\n"); > > > - pr_warn("** **\n"); > > > - pr_warn("** NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE NOTICE **\n"); > > > - pr_warn("**********************************************************\n"); If you actually want anyone to notice it you need to splat it out when root logs in - not just hidden in the middle of the boot messages. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)