From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 089303E1CFC for ; Mon, 25 May 2026 09:57:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779703025; cv=none; b=TQznpIDApKiwEH7S0p69CjrcdnmPTzMPxlVbV9AVhWG+NgGn1XhkBE3uZW7M/u4ubsDz1CbzZfASoF+KLHdyb2QjQ7UQN8lGF19oLqWCCtnl1ysI4NNLby6Fb7ClC5ZJdGRdxsZnNAsw7Q2XtICdC9DzPXcpPrLh2oWHGABZDyQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779703025; c=relaxed/simple; bh=MgR93XTU1mq8y2aZ9hWPpI2kctBBCnxVq1k/OqiBpNw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=f/uizFxQ5/0ACBVPsevECJctnwvXnLkQPyrVzY/ESJ6q/td+XONvH02FhXaPP+87qKDXol/lZGGwYldlE73KIFbNDGOO7SPyrNN5jX/3DLiRDNuzzfclDv1PHGJmwSeIx+Wkl0JhHcUKjqUPXjM50+0kOOfQSwHN3ohi3OWjtbo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AfEffcXO; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AfEffcXO" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-449d6c68ed8so5655603f8f.0 for ; Mon, 25 May 2026 02:57:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779703021; x=1780307821; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cez/cnYMxxZmQ2yyzCf16xYcrSK3/MCZDkpw9VeqbqI=; b=AfEffcXOY2pm+1R4AaZVi6AyUialZbr9D9JNBm1ZI1818u4mp2QkdyjEXCD0R1OgGb XF1rPqTYzpDMo7zfOZLssRUwXCLagyGXGELHg+c3m0NW6CnTfEzVEzjd8XLD/c7zC9Vd 89hmTEK69JJR7Bk5J0xGSBceyw5TUUMHOYBRgjZBvgNGK2WMwEIJ7Rf+FB5GurRPXyht jYAdlve99fu1Y0b2tOfpwRQ+YdBAyc+ZRphJfoHYE6qOUaC/xt7tE+mR0wrBgWjiOk22 tigmVygaV1VMAsdnEONqwa791+ncG+dnwj/Px+kSy/XRvs4p+pW4vZ2Ksn86BCIwfAWU sL+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779703021; x=1780307821; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cez/cnYMxxZmQ2yyzCf16xYcrSK3/MCZDkpw9VeqbqI=; b=RLMpTkDaHb0NUIrsFlzbXImvaF4hYHY/fjtN7WpqvdRyn2yoOS+RG4L1nAtlVGWKpK na9+PEzdqg4kLcjZCyw5EN38+RH25hQvvhCRdpkqSNw6rDvaKMFiSU2W9ZqQEjibxlIy GXrpXa8uw9oHp9rLOhPl0/Pmgz7oG7R+RPgsBGhoP412h/ZiCAYD3bPGzxjM7oFV2SMv 5BalcYjHWCT1sBgTTpHtOmSjlM0naRighj2oLBTIJqFDYcbX9fHIVNx+/bjC0qNrhWNE ijjUD7SvwvxtSAuyrLZP/uMjgDb/NLd6C0dLQimj3tu4wxFi8YFSge/l03KX20zd5oa1 i3Hw== X-Forwarded-Encrypted: i=1; AFNElJ9YHkoBW7dmwMpK2hqd/fv+baHps0UgAJKH5dh4bVl7TPpRar820DYDRrVCXoayD9g6wwUtgBwP9dpZof4=@vger.kernel.org X-Gm-Message-State: AOJu0YzyhScCn+AjXmFk0t6ezCdyjG1RHaUVpk0PlJ+UbeL3EfD8a+SV 71OqvdOBgJYg3RnmypqDPy2VXh24w1ERkphoUFM7hiraxtqeFAxFJ32S X-Gm-Gg: Acq92OHEF8lSYpKzigsg9yfwVln5ikqVMByNBZ5xM4d42kZR8t9wzTEJNGqgvUGk3wl R3c4VjoJc39FRlrXV7wIJlFI9bPjI3JvdtxhCYgyoOrrjbhKK+ghRXFubkuiZ7fXYuBvBj7NvhT LZVxxPoZu56yRHoluZ/WARKOwWslCQqKmFCo/DUBYvU0PbjmkSC2WIMokeOLZ8BTXHeSxQ1SP0G ixCbEO+bzndX9KgIc9UXk6+KW8Xj3eQ5Xra+Shqbhm/dDsfpRl73XDqgZvwb31C5JntFoWiUaBB yzzLpzN4L0Tx9IppEgyZ0Sh4Q9tJlwbpXC2kCnPLjE1+X5ip5oxaW6oxvCaqacM63eRC4U8zFOn smQKJMAWt8Nd1iOVFMkJ7Oy1RystCcHDD2hBpm2GSypfhXtZabE3UQWWrDAVOfu/D5YJcqAwgcH /Ijk5XZf1nvoPtOUzawPOsVNMEQNS9a4VjULsvCOrzaUrwJAwq4qCCt0v/7hpPAjR0s0sPLdw= X-Received: by 2002:a05:6000:401e:b0:44a:247e:67b1 with SMTP id ffacd0b85a97d-45eb36920e5mr23940884f8f.5.1779703021283; Mon, 25 May 2026 02:57:01 -0700 (PDT) Received: from ?IPV6:2a00:f502:160:5a27:4d10:c059:34aa:a542? ([2a00:f502:160:5a27:4d10:c059:34aa:a542]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45eb6cd151asm25354818f8f.13.2026.05.25.02.56.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 25 May 2026 02:57:00 -0700 (PDT) Message-ID: Date: Mon, 25 May 2026 12:56:58 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 2/9] clk: qcom: gcc-msm8939: mark Venus core GDSCs as hardware controlled To: Taniya Das , Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Andr=C3=A9_Apitzsch?= , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd , Brian Masney Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260519-msm8939-venus-rfc-v8-0-542ec7557ebc@gmail.com> <20260519-msm8939-venus-rfc-v8-2-542ec7557ebc@gmail.com> <608dc53d-17a8-4230-9ebb-48a94bf03675@kernel.org> <6ae3a89c-f205-45c5-87c0-5550f78502d6@oss.qualcomm.com> <01f9a303-846a-4048-8115-c94b9b78078a@gmail.com> Content-Language: en-US From: Erikas Bitovtas In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 5/25/26 8:51 AM, Taniya Das wrote: > > > On 5/22/2026 4:18 PM, Erikas Bitovtas wrote: >>>>>   static struct clk_branch gcc_venus0_core0_vcodec0_clk = { >>>>>       .halt_reg = 0x4c02c, >>>>> +    .halt_check = BRANCH_HALT_SKIP, >>> please use .halt_check = BRANCH_HALT >>> >> If I do that, the clock fails to power on on boot. >> [ 20.324488] ------------[ cut here ]------------ >> [ 20.324520] gcc_venus0_core0_vcodec0_clk status stuck at 'off' >> [ 20.324663] WARNING: drivers/clk/qcom/clk-branch.c:88 at > > > I am hoping the Venus driver has enabled the GDSC before requesting the > clock enable. > It does. From 3/9: +static int vcodec_domains_enable(struct venus_core *core) +{ + const struct venus_resources *res = core->res; + struct device *pd_dev; + int i = 0, ret; + + if (!res->vcodec_pmdomains) + return 0; + + for (; i < res->vcodec_pmdomains_num; i++) { + pd_dev = core->pmdomains->pd_devs[i]; + ret = pm_runtime_resume_and_get(pd_dev); + if (ret) + goto err; + + ret = dev_pm_genpd_set_hwmode(pd_dev, true); + if (ret && ret != -EOPNOTSUPP) { + pm_runtime_put_sync(pd_dev); + goto err; + } + } static void core_put_v1(struct venus_core *core) @@ -320,11 +410,35 @@ static int core_power_v1(struct venus_core *core, int on) { int ret = 0; - if (on == POWER_ON) + if (on == POWER_ON) { + ret = vcodec_domains_enable(core); + if (ret) + return ret; + ret = core_clks_enable(core); - else + if (ret) + goto fail_pmdomains; + + if (!core->res->vcodec_pmdomains) + return 0; + + ret = vcodec_clks_enable(core, core->vcodec_clks); + if (ret) + goto fail_core_clks; +