From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A883C77B73 for ; Mon, 8 May 2023 11:36:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236059AbjEHLgw (ORCPT ); Mon, 8 May 2023 07:36:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59018 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236095AbjEHLg0 (ORCPT ); Mon, 8 May 2023 07:36:26 -0400 Received: from out30-130.freemail.mail.aliyun.com (out30-130.freemail.mail.aliyun.com [115.124.30.130]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D3A183D214; Mon, 8 May 2023 04:35:59 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R751e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046049;MF=renyu.zj@linux.alibaba.com;NM=1;PH=DS;RN=17;SR=0;TI=SMTPD_---0Vi5-Kjt_1683545726; Received: from 30.221.149.87(mailfrom:renyu.zj@linux.alibaba.com fp:SMTPD_---0Vi5-Kjt_1683545726) by smtp.aliyun-inc.com; Mon, 08 May 2023 19:35:28 +0800 Message-ID: Date: Mon, 8 May 2023 19:35:24 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH v2 3/5] driver/perf: Add identifier sysfs file for Yitian 710 DDR To: John Garry Cc: James Clark , Mike Leach , Leo Yan , Mark Rutland , Ilkka Koskinen , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Adrian Hunter , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, Zhuo Song , Shuai Xue , Will Deacon , Ian Rogers References: <1682329456-19418-1-git-send-email-renyu.zj@linux.alibaba.com> <1682329456-19418-4-git-send-email-renyu.zj@linux.alibaba.com> <136984f7-b9a0-721f-3e31-f6ef840b0878@oracle.com> From: Jing Zhang In-Reply-To: <136984f7-b9a0-721f-3e31-f6ef840b0878@oracle.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2023/5/1 下午8:31, John Garry 写道: > On 24/04/2023 10:44, Jing Zhang wrote: >> To allow userspace to identify the specific implementation of the device, >> add an "identifier" sysfs file. >> >> The perf tool can match the Yitian 710 DDR metric through the identifier. >> >> Signed-off-by: Jing Zhang >> --- >>   drivers/perf/alibaba_uncore_drw_pmu.c | 27 +++++++++++++++++++++++++++ >>   1 file changed, 27 insertions(+) >> >> diff --git a/drivers/perf/alibaba_uncore_drw_pmu.c b/drivers/perf/alibaba_uncore_drw_pmu.c >> index a7689fe..fe075fd 100644 >> --- a/drivers/perf/alibaba_uncore_drw_pmu.c >> +++ b/drivers/perf/alibaba_uncore_drw_pmu.c >> @@ -236,10 +236,37 @@ static ssize_t ali_drw_pmu_cpumask_show(struct device *dev, >>       .attrs = ali_drw_pmu_cpumask_attrs, >>   }; >>   +static ssize_t ali_drw_pmu_identifier_show(struct device *dev, >> +                    struct device_attribute *attr, >> +                    char *page) >> +{ >> +    return sysfs_emit(page, "%s\n", "ali_drw_pmu"); >> +} > > Would there be anything more unique per implementation version? Having a constant like this means that all implementations will have same events from userspace PoV. > Currently there is only this version, and no new revision will be added in the future. We can consider all implementations to have the same events. Thanks, Jing