From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86226C001DF for ; Tue, 25 Jul 2023 11:52:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231777AbjGYLwn (ORCPT ); Tue, 25 Jul 2023 07:52:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59818 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232106AbjGYLwX (ORCPT ); Tue, 25 Jul 2023 07:52:23 -0400 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C5F310EC for ; Tue, 25 Jul 2023 04:52:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690285928; x=1721821928; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=Fd/RDz89cgDhh0kuNdhH2IWsW1WRaHvoArD8ju6Ge28=; b=fbVFzRs4VXkMnS4d6aA+faeIsdgZRBflas6O5bG/GO3SNcLEB9acJ/rG TaBLR1H9NDcn08lQPXFxjWwjWSWK8CXhIcXoTWFBAH5Zl0yBa4nQjPkls SiRhGHb0na+ZjNjEO1oxfS7lw7jazwk1Tx3m5Z7zC90OKIEKAnRhda59F 5PUJ0byBxmN8j4hAfKgs/KLMbG4dbjqczWuwrBynMQ5sES5zB/iw8Hrdl UedOPuRmxbe/sq40XXMpkxiRhoXOIuuTWUaKsNIqp776NHgp03cR4KcNU 7CtMFaqxlAABm16wyOgqzIXm7jAxwKvo4sybhPdpWjOtE8++t1nW/eolw A==; X-IronPort-AV: E=McAfee;i="6600,9927,10781"; a="357700524" X-IronPort-AV: E=Sophos;i="6.01,230,1684825200"; d="scan'208";a="357700524" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2023 04:52:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10781"; a="729323683" X-IronPort-AV: E=Sophos;i="6.01,230,1684825200"; d="scan'208";a="729323683" Received: from ahunter6-mobl1.ger.corp.intel.com (HELO [10.0.2.15]) ([10.249.37.150]) by fmsmga007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2023 04:52:02 -0700 Message-ID: Date: Tue, 25 Jul 2023 14:51:58 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0 Thunderbird/102.13.0 Subject: Re: [PATCH 1/1] perf dlfilter: Initialize addr_location before passing it to thread__find_symbol_fb() Content-Language: en-US To: Arnaldo Carvalho de Melo , Ian Rogers Cc: "Aneesh Kumar K.V" , Athira Rajeev , Disha Goel , Jiri Olsa , Kajol Jain , Madhavan Srinivasan , Namhyung Kim , Linux Kernel Mailing List References: From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/07/23 00:31, Arnaldo Carvalho de Melo wrote: > Em Mon, Jul 24, 2023 at 02:16:05PM -0700, Ian Rogers escreveu: >> On Mon, Jul 24, 2023 at 2:09 PM Arnaldo Carvalho de Melo >> wrote: >>> >>> As thread__find_symbol_fb() will end up calling thread__find_map() and >>> it in turn will call these on uninitialized memory: >>> >>> maps__zput(al->maps); >>> map__zput(al->map); >>> thread__zput(al->thread); >> >> Normally there would be a addr_location__exit. It looks here like most >> values are copied in al_to_d_al, which copies reference counted values >> without doing appropriate gets. Perhaps add the gets in al_to_d_al and >> add the exit to make it clear there can't be addr_location related >> leaks here. > > I'll do that as well and add the addr_location__exit() then send a V2. The data is not valid outside the context of ->filter_event() or ->filter_event_early(), so the reference counts should not be changed. That probably needs to be made clearer in the documentation. > > - Arnaldo > >> Thanks, >> Ian >> >>> Fixes: 0dd5041c9a0eaf8c ("perf addr_location: Add init/exit/copy functions") >>> Cc: Adrian Hunter >>> Cc: Aneesh Kumar K.V >>> Cc: Athira Rajeev >>> Cc: Disha Goel >>> Cc: Ian Rogers >>> Cc: Jiri Olsa >>> Cc: Kajol Jain >>> Cc: Madhavan Srinivasan >>> Cc: Namhyung Kim >>> Link: https://lore.kernel.org/lkml/ >>> Signed-off-by: Arnaldo Carvalho de Melo >>> --- >>> tools/perf/util/dlfilter.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/tools/perf/util/dlfilter.c b/tools/perf/util/dlfilter.c >>> index 46f74b2344dbb34c..798a53d7e6c9dfc5 100644 >>> --- a/tools/perf/util/dlfilter.c >>> +++ b/tools/perf/util/dlfilter.c >>> @@ -166,6 +166,7 @@ static __s32 dlfilter__resolve_address(void *ctx, __u64 address, struct perf_dlf >>> if (!thread) >>> return -1; >>> >>> + addr_location__init(&al); >>> thread__find_symbol_fb(thread, d->sample->cpumode, address, &al); >>> >>> al_to_d_al(&al, &d_al); >>> -- >>> 2.37.1 >>> >