From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 662251991CB for ; Mon, 8 Dec 2025 16:33:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765211590; cv=none; b=BA2mN9f9cQCMivMWbK48rnB8J0uAU7gIzAA/jOsVB/HYJq7P/87Erw9rQRjo/+J2Mx3S41mW7Lns4hPHOOtbDCsfLrxU8VhbyQNVjznBGu4shcCSjW8ta0/KvQs/g13ZNVyASsPAovPMOEMnnygRo1gPK9EZ+XVK9O2/gDdJABs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765211590; c=relaxed/simple; bh=4kP2/K5lTTzD5c1dfUscOl9B3nFR54A29c9lPCoqrmg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Kr9Po6vOv3eHDGM4YDCDPNhjA2Czl3pzGUaPI6c3HOcAeWXUlAKcdGFIfam4pJbn7svDtQtojPgWW2XSN28JAZX9AbBaWKrtx7MfPGz6bMmZCUswwGNS9NefsRryHsyWU9Jizr2TEhCiijAoNBg5DFmtpJiBUDS5WSEGvxyAbC0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Z4FaYQ6s; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=CPBpbi4h; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Z4FaYQ6s"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="CPBpbi4h" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B8B4ExW1130618 for ; Mon, 8 Dec 2025 16:33:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= p0jPCBlDjyAGHOYNhm4qqz3KwSpK2g+kV3CwXvtWt40=; b=Z4FaYQ6s9cH26VAe IdNsMvVHL2UGkdyfjgaRROsDKQqgEErjrGw8b7Vyu5dwyfvg5fSnuOuSERj+riND WkyDFel2arRlNzwuRGIKdXJk87UGs4HDmr6IcgwSDundcOIosM/0D31207HmZh08 Ip3c3Tpu+lHn8734L1/enuQbhSXBqcRJGeGWp0lR9b2C1I0Jg2WhJpCvplQliYYk Nb6poajnBosed72iayww7YCXAd8vQXPPViifnrp2gl1Sl+JOsbyD6//co4koj6IJ Ixb5K3LU5CC10eayYWXLZ37tpuqBwagvAhLfZFCc5Bn5cbxsmf4o0/0v1+DbwRkP nW8MJw== Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4awwfr8xs5-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 08 Dec 2025 16:33:06 +0000 (GMT) Received: by mail-vs1-f70.google.com with SMTP id ada2fe7eead31-5de01f47e82so364860137.3 for ; Mon, 08 Dec 2025 08:33:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765211586; x=1765816386; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=p0jPCBlDjyAGHOYNhm4qqz3KwSpK2g+kV3CwXvtWt40=; b=CPBpbi4h02TrjJ6QmamVto3FASF+B7qy3iXUFzUfj7OAvdCpokDjMi5guF6YIWtE7j kY4oKZz7Qm7YiNEBK91Mc21ti748bZsV9n+hAcWJa61BZqNtrIjzT72BgTbwATW8iKxZ QtYLJbtLZIgz9MplsT/oEsCGrQM6F6gN1GwU0m2bshk9Py72LQD29cL3Dj9i1L52F3mn dKAxcIGHmAjgzRtTcBZMPvgJiGmir0VUQtdGhJmuu9vWCV8T3Dy9c16luPIOEQAlKZjZ fA1eE2qbR/aePFxEEO6vlc3UkO4vsFhnnKKO0qI3PlwglsWqTWfifA07/d40n7xJIAXo 8C8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765211586; x=1765816386; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=p0jPCBlDjyAGHOYNhm4qqz3KwSpK2g+kV3CwXvtWt40=; b=ROmTf020Yxei3uDKbriZE0VaYw2jwOg8e0vtFm8eb3uSh43sATpYYPzmzM3c107bQM fTTn4y+FUnBcSStYfsBZMr+63oqYxTqY2uv0rOpMG/bEsv52jZqzrAKktvzEWFB1ATvx mD0T1KQzA/JJDeINgFb/otsQ+k9XOnpdDl/df2p+7mp0q9yWPJsX72OBZGQriYbjyg78 nsopo5eXS0ZYeyst9ptcI6HyhaT+/90xd7EqZkHkIlio+jUkud/SXmvGvjZlBy8g3hRd Ihv3vIm3o3ijOqc/qwS/lPur4gnSjOYB67FrR4s5mL6HdFurJe+Je7Fxby0CIhqLUfWZ qohw== X-Forwarded-Encrypted: i=1; AJvYcCXmDCtRw9WnDEjhufH16wg/oCclhyJG8VS8PLW/MTvF8Uq1X/UMapM+ghb1yOnZdwkss+xO85Umtw6IDkQ=@vger.kernel.org X-Gm-Message-State: AOJu0YxRHfmUYtBNEppf8pL4kAkEoCqnlv4TZoATk2V07X2rAHQ4gOH9 kuwvTsduh0aN2sU9aIHMQAT8GRYpXXDxiGstGKvmqanG+MsDoOu7D7bQGyu3EB/v8a7NXIKtB/2 W26meBcUTsK9effsOj3DenCQqL489yDvmNodQPz3Y9u+7R38Z1iSQowEn2xHVoKqVb0c= X-Gm-Gg: ASbGncttUVqrXbUBPNTDHJ1zn6wnEqbPkbBXimrTyMWwJqQUZF2OZgRRexuqFph6pkh Wm1hG6rZ/CTAgwsaBxg6qzUa6OMgaKnkgZBTQ+p+DtLm2DOFTdLsXEOyLMa7QEJ4b+Dr79/tFrp vwyyt7MlfnOs5qkx8kPiVQu8TyLRWWYEuyzUKNqabUSbNM1XyvLIJJ9+tyfhPc15fp04/2HEbz1 tXyHAhCGSA7FE66A4Ru8RxmrKlfv0eBp+BdV1zns+1gRzqY10BPa972NqlbtNa/t/y1WBy3mg/O x7GVEv+zgFjj1fF2Jd+jCbKzq0ik+MOAV6hMw3Ojlh0360N5GoW/iATfhHQW6seZNJsSMlgiSlh cpcs3kBwnVk8dZgrGKjlFBwTdyYSVX1o5QMO2n5n0EI5BR0fTQ+1p7iSFHphvGDMCCw== X-Received: by 2002:a05:6123:590:20b0:559:965e:f563 with SMTP id 71dfb90a1353d-55e8456e09dmr922454e0c.1.1765211585540; Mon, 08 Dec 2025 08:33:05 -0800 (PST) X-Google-Smtp-Source: AGHT+IE6DtAX4O9dA9blwgNCdrieGjzAXE19KIk9bTjGIhWldGNpRwxj3DsIOBUbUO1qZ11wI5CioA== X-Received: by 2002:a05:6123:590:20b0:559:965e:f563 with SMTP id 71dfb90a1353d-55e8456e09dmr922439e0c.1.1765211585091; Mon, 08 Dec 2025 08:33:05 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b79f49a898bsm1146957666b.48.2025.12.08.08.33.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Dec 2025 08:33:03 -0800 (PST) Message-ID: Date: Mon, 8 Dec 2025 17:33:00 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dt-bindings: remoteproc: qcom,adsp: Re-add cx-supply To: Luca Weiss , Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , Dmitry Baryshkov , Dzmitry Sankouski Cc: ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251207-adsp-cx-fixup-v1-1-0471bf2c5f33@lucaweiss.eu> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251207-adsp-cx-fixup-v1-1-0471bf2c5f33@lucaweiss.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA4MDE0MCBTYWx0ZWRfXwLyPpzYLBu3/ vN/92TnLmtAZ/9EMR+48uGNanvw+7ZtrEkymo+45JCO55nysgC5nsEjGF7fTE+MXbyBYNIkTDlb LTpK6BU/DYJ8D8WKuJ0PSfbJxRAu4Q3xdumrJcOclMOuqD9V1FOZRrWKyGpbYkpgYBCJeH4ktKt mLozk3bYCdDRJ5gdVQEyHIpzozozyYHJduACSPdqaT4QIB4FYVIe0tBXNOoPeYtudKf8KSrooRM nDgVWtSTeMwqxCe69ecvm6ShEH78lKD5dN/lADaiG5xPTZPMm8mRBkstyF/VsVc2zx8AexXkiYY t4m8B91Ejbq/yUlg/mLbrTOt2wDH6mGvst3B02KjnrByNAGYfC0Up281unJc93yI79krQ+LISHw 4L4kF2CgJWK6HhxtHibHRHmXv4F9mA== X-Proofpoint-ORIG-GUID: AdX6bGrva3fQnrtBLmqInpy03PcPVXCC X-Proofpoint-GUID: AdX6bGrva3fQnrtBLmqInpy03PcPVXCC X-Authority-Analysis: v=2.4 cv=fsXRpV4f c=1 sm=1 tr=0 ts=6936fdc2 cx=c_pps a=N1BjEkVkxJi3uNfLdpvX3g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=dlmhaOwlAAAA:8 a=2w06CcI7I7z3fbE2fRcA:9 a=QEXdDO2ut3YA:10 a=crWF4MFLhNY0qMRaF8an:22 a=y4cfut4LVr_MrANMpYTh:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-06_02,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 malwarescore=0 suspectscore=0 adultscore=0 spamscore=0 clxscore=1015 bulkscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512080140 On 12/7/25 11:35 AM, Luca Weiss wrote: > Some boards (e.g. sdm845-samsung-starqltechn) provide a cx-supply > reference for the SLPI PAS. > > The Linux driver unconditionally tries getting "cx" and "px" supplies, > so it actually is used. > > Fixes: 3d447dcdae53 ("dt-bindings: remoteproc: qcom,adsp: Make msm8974 use CX as power domain") > Signed-off-by: Luca Weiss > --- > There's literally one board using this upstream, judging from that I'm > not sure this is a misuse of cx-supply or what exactly. An alternative > to this patch is of course removing the usage in > sdm845-samsung-starqltechn, but as it stands right now the patch under > "Fixes" introduces a dtbs_check warning. FWIW that's likely a hack (because IIUC it needs to power up some regulator for the sensor devices to work) but that's "fine" I don't know if there's a better way to handle it though.. I think it's a board design "issue", since the DSP has access to some GPIOs but it seems like that wasn't utilized I'm open to suggestions +Dzmitry-the-starqltechn-submitter Konrad