From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailtransmit05.runbox.com (mailtransmit05.runbox.com [185.226.149.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5E97C8F6E for ; Wed, 16 Apr 2025 12:33:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.226.149.38 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744806814; cv=none; b=MU7gR2uyp64FBXFdxvd5EMRVC+W8DA0Pt6xvHMPmZgvwZiWNielQS6xKKQJUQtJ8EWB9AXTsBXQhiNMzRikBtEbow25/BOuFy7mkWE/sY4qzYZSrOl/ECH2g+Aghr52Ur7I+/uX6ydw+uvQEcO0bWotngmJrk87lhxw+nwrqYQQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744806814; c=relaxed/simple; bh=4qIM6NDApAy+iQcMJjhG+V5szdj3jxVPua3mI1f89bw=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=i2F607859Bs70nN1poE6FJ/RzRPhGLms2Oj4QIhqFEK76980AH7tExLPusTaWz8VJKnNZv12kSW/oXOd/Rpsm1BIu9p4/YSBb5AIhNV4W6PDZkRBqC0+XRomtakogr2J9TZE30OvFIa05+W2rZfi3iPF18jk+2ajvpdgFvpvSuA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rbox.co; spf=pass smtp.mailfrom=rbox.co; dkim=pass (2048-bit key) header.d=rbox.co header.i=@rbox.co header.b=OqXc+HW5; arc=none smtp.client-ip=185.226.149.38 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=rbox.co Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=rbox.co Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=rbox.co header.i=@rbox.co header.b="OqXc+HW5" Received: from mailtransmit03.runbox ([10.9.9.163] helo=aibo.runbox.com) by mailtransmit05.runbox.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1u51wt-002cjh-Oa; Wed, 16 Apr 2025 14:33:03 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=rbox.co; s=selector1; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References: Cc:To:Subject:From:MIME-Version:Date:Message-ID; bh=crDf7Ip/1JD64ubcfZIDIgxNvqURgDue9Ofx9nsrBaE=; b=OqXc+HW5jOJBt0DSI9pRew7obI G7v9uG4x6ZoWt4/198n7KvxuaCpNA1yS9JcyU3t7ZeVCt5wOMto1r8UD2vNTxPN68vHWMsWm0Q43T 3KGjJuuKRRsamJDnZGpy9bkFLcNkXQ1pxGCqesZB5zxvtA9Zni+HasGbF9EeY989VSB03aNtRaG43 CfMMhlEzKm4eVHpePIEh1PIiAfjvJtcELz07/KMNKc+pfZL+R2LzpzzcGIcF0SveV7oPHG1x/RyKS ZyrY0K+utd4JgJ4Q0znHzX2ag3Go2L/h0i5i0mXEfWuBEeuDXVMQSNGcRue3t8bkY3DZsQ+7O7fpU MduH9caQ==; Received: from [10.9.9.73] (helo=submission02.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1u51ws-0000hV-I2; Wed, 16 Apr 2025 14:33:02 +0200 Received: by submission02.runbox with esmtpsa [Authenticated ID (604044)] (TLS1.2:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.93) id 1u51wc-008Du8-Be; Wed, 16 Apr 2025 14:32:46 +0200 Message-ID: Date: Wed, 16 Apr 2025 14:32:44 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Michal Luczaj Subject: Re: [PATCH bpf-next v2 5/9] selftests/bpf: Add selftest for sockmap/hashmap redirection To: Jiayuan Chen Cc: Andrii Nakryiko , Eduard Zingerman , Mykola Lysenko , Alexei Starovoitov , Daniel Borkmann , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Shuah Khan , Jonathan Corbet , bpf@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Jakub Sitnicki References: <20250411-selftests-sockmap-redir-v2-0-5f9b018d6704@rbox.co> <20250411-selftests-sockmap-redir-v2-5-5f9b018d6704@rbox.co> Content-Language: pl-PL, en-GB In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 4/11/25 15:17, Jiayuan Chen wrote: > On Fri, Apr 11, 2025 at 01:32:41PM +0200, Michal Luczaj wrote: >> Test redirection logic. All supported and unsupported redirect combinations >> are tested for success and failure respectively. >> ... >> + for (r = redirs; r < redirs + ARRAY_SIZE(redirs); r++) { >> + enum bpf_attach_type attach_type; >> + struct test_sockmap_listen *skel; > > Could we create a new BPF program file, such as test_sockmap_redir.c, > instead of reusing existing ones? This file would be specifically > dedicated to serving the sockmap_redir.c functionality. > > I understand there are already some duplicate programs, but isn’t this > exactly the goal of our current work—to make the test examples more > comprehensive and cleaner? Sure, I get your point. I'll do that. Thanks, Michal