From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758844AbdAKUrM (ORCPT ); Wed, 11 Jan 2017 15:47:12 -0500 Received: from mout.web.de ([212.227.17.11]:49269 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758658AbdAKUpf (ORCPT ); Wed, 11 Jan 2017 15:45:35 -0500 Subject: [PATCH 09/18] mtd-cfi_cmdset_0002: Use kmalloc_array() in cfi_amdstd_setup() To: linux-mtd@lists.infradead.org, Boris Brezillon , Brian Norris , Cyrille Pitchen , David Woodhouse , Denys Vlasenko , Marek Vasut , Richard Weinberger References: <71189baa-8780-b80a-0b4d-9dae74763ba3@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Message-ID: Date: Wed, 11 Jan 2017 21:44:32 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <71189baa-8780-b80a-0b4d-9dae74763ba3@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:+GD7IQjWZZlZtzwltHfCHsYlUyT8U+rhb/YtIuQJYbtqyTnvlRg rXn4nYXCh7lRXAlUpSwai4lj3pTTo9MI6A2UX3Ir36wn1mV9VcXsYT5pyZ//Exd8UJOLlb9 vTi8h6yyh0tckkCs722IxMwEX3x9bzyetFzGHeLlUdrX6etsnJBLhjWDlYXdys+eG5ihDxL Kz2zOIQRg5U73ONw8GNag== X-UI-Out-Filterresults: notjunk:1;V01:K0:PpeTIBIfB0g=:iXVJeNTn6tT3ltwRxfJpAD 7pUUFXhZrBmP6Vwx3rja1LDEPPOFobv5Pz7/29zVs1R24l8WyqTJttky5p+prVxOFk/qwe1h1 FQuuwc4ofEtJRXDyqI4kaqQkOS2KBg9idrPDGzU5Vv3IGwFBwVpzdEQULNblNc8ct4QDvBFv9 Qt2gIF3TdSJLJmOIzGJyN51Wv+Vv0q1KryquUj9oXTvsD+GziSS0vhwx65X5kUtYXp+tYj5gZ hu0Dv5YSjPlz2/bBQm6qO7VgNKBWiio4WyD/JAzyzhvsI1LIuFz9AzgZL/cI8frnjtjvo5hXZ sZeSvTbH7e6EIHD9QHgdAyiTHCT7XtDLr5E6OmfCuGxwumPvqPnV0UhK1UtzJSsFyGyb5yhjo 1fpC+EvRIWGz8B09rRtk/TkqWpu3QqvP9TQg7eiTK2gBE+GM66KidV/W6JGKzNemhHR8zr0W7 IHVQ2VpTA2ZbAb97QFXHAK6wTtFgbIJ8xrOkA34yl75hUlr82vnvcdYZi/qSv3nmOddQp+OSU d/QMUhQY+6joxWAsz1Arq2rFJXZIINuG3hgimE6M2J+eds6VqwlqjkTcHZGahFTokux9rhc7H opNz11g8uKHQqH8lpvn/CRdAoBG1EHuqzuwmAmUwAF3pDYc1WyPc9aOxrUElD2ARj34kPJHcu LeQd9isitVllkQoTKI8Gf6lZSNO7wYveY86nerIHDTmD2HlUeGQWw/C5HxeEKNZdQpuqgvi8w KWShZDnhwu+YP9Ts2ZkXKBmijY9TB5UVVC9zWeLwr9Bu1L4cbq3oldPkKdJr3LH7qtCfs5EtK 8jR2mXd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 11 Jan 2017 17:56:42 +0100 * A multiplication for the size determination of a memory allocation indicated that an array data structure should be processed. Thus use the corresponding function "kmalloc_array". This issue was detected by using the Coccinelle software. * Replace the specification of a data structure by a pointer dereference to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/mtd/chips/cfi_cmdset_0002.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c b/drivers/mtd/chips/cfi_cmdset_0002.c index 9dca881bb378..3bed67e35692 100644 --- a/drivers/mtd/chips/cfi_cmdset_0002.c +++ b/drivers/mtd/chips/cfi_cmdset_0002.c @@ -688,8 +688,9 @@ static struct mtd_info *cfi_amdstd_setup(struct mtd_info *mtd) mtd->size = devsize * cfi->numchips; mtd->numeraseregions = cfi->cfiq->NumEraseRegions * cfi->numchips; - mtd->eraseregions = kmalloc(sizeof(struct mtd_erase_region_info) - * mtd->numeraseregions, GFP_KERNEL); + mtd->eraseregions = kmalloc_array(mtd->numeraseregions, + sizeof(*mtd->eraseregions), + GFP_KERNEL); if (!mtd->eraseregions) goto setup_err; -- 2.11.0