From: Oliver Neukum <oneukum@suse.com>
To: Peilin Ye <yepeilin.cs@gmail.com>,
Oliver Neukum <oneukum@suse.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: Peilin Ye <peilin.ye@bytedance.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Ming Lei <ming.lei@canonical.com>,
Cong Wang <cong.wang@bytedance.com>,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] usbnet: Fix memory leak in usbnet_disconnect()
Date: Mon, 26 Sep 2022 12:47:42 +0200 [thread overview]
Message-ID: <d8224556-72cb-cb48-b530-05cffab2a6df@suse.com> (raw)
In-Reply-To: <20220923042551.2745-1-yepeilin.cs@gmail.com>
On 23.09.22 06:25, Peilin Ye wrote:
Hi,
> I think we may have similar issues at other usb_scuttle_anchored_urbs()
> call sites. Since urb->context is (void *), should we pass a "destructor"
> callback to usb_scuttle_anchored_urbs(), or replace this function with
> usb_get_from_anchor() loops like this patch does?
>
please introduce a new function with an additional parameter
for that, so that we do not need to touch the correct usages.
Regards
Oliver
next prev parent reply other threads:[~2022-09-26 11:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 0:29 [syzbot] memory leak in mld_newpack syzbot
2022-09-16 22:13 ` syzbot
2022-09-23 4:25 ` [PATCH net] usbnet: Fix memory leak in usbnet_disconnect() Peilin Ye
2022-09-26 10:47 ` Oliver Neukum [this message]
2022-09-26 18:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8224556-72cb-cb48-b530-05cffab2a6df@suse.com \
--to=oneukum@suse.com \
--cc=cong.wang@bytedance.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=ming.lei@canonical.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peilin.ye@bytedance.com \
--cc=yepeilin.cs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®