From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D381D3CCFA6 for ; Wed, 27 May 2026 07:51:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779868315; cv=none; b=l5uhve82/2UgKs+JuxAgbRd0NkfP0T5Dh9ghWDDK8qMQFXbivl3uBGRmyT+6Jen2Aee6T96UjfNPc31FCR0oUDB1VIh73iCIFvI7y2UJNXshY/4kF9JGf4SK6ZhHqzC+86TGcWkYJOIbxI562osVvKhJkCVz+E1jF3vV/loE5FA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779868315; c=relaxed/simple; bh=BAe+EarAbMuIYW0DQUGD5Tt7lDM7vRg8HgwirF3AAvo=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=fUzDqyIs5/Bs5zZteL5JfSQCCpNoCKIr4BQlnKpvm0facqT13xvU9zyUnv7Z93WNnbCIcJu/kYbMh+9jbnLSOQaaw+u46dWZQyAxhmwtf846sOvVsBmJC3Qn0r12AFQtpo+HIMPlHn5lWXk//gAEFxkXdsrs/9dYvC/MMHBoiv4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=LEER0Gkr; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="LEER0Gkr" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779868312; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s8MKYKkgpzAFLPjRo1YpVAV+ujkH8ODdIP3anGZt+es=; b=LEER0GkrTMXF9Po67luGgS6XX3fCYznAuH0jhbh7OrCn755Dc/1ywm6KjZ/Z19haBFxIZm oeewuKXSQzo5ZlNrOUa0DOKYwvXw7GXmYme3pllNP1riSH+pjqV6jgeWKcb705dJ+MyPTB gtPN1T2Ks1Kop13nTl7MNs/nR7CH6RI= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-433-nlhaX1s-P6-__aJGyDHRHA-1; Wed, 27 May 2026 03:51:49 -0400 X-MC-Unique: nlhaX1s-P6-__aJGyDHRHA-1 X-Mimecast-MFC-AGG-ID: nlhaX1s-P6-__aJGyDHRHA_1779868308 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 9820D18005B3; Wed, 27 May 2026 07:51:47 +0000 (UTC) Received: from [10.44.48.151] (unknown [10.44.48.151]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id A584719560A3; Wed, 27 May 2026 07:51:44 +0000 (UTC) Message-ID: Date: Wed, 27 May 2026 09:51:43 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net 2/3] dpll: zl3073x: use __dpll_device_change_ntf() and remove change_work From: Ivan Vecera To: netdev@vger.kernel.org, Jakub Kicinski , Paolo Abeni Cc: Vadim Fedorenko , Arkadiusz Kubalewski , Jiri Pirko , Prathosh Satish , Jakub Kicinski , Petr Oros , linux-kernel@vger.kernel.org References: <20260526074525.1451008-1-ivecera@redhat.com> <20260526074525.1451008-3-ivecera@redhat.com> Content-Language: en-US In-Reply-To: <20260526074525.1451008-3-ivecera@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 On 5/26/26 9:45 AM, Ivan Vecera wrote: > The change_work was introduced to send device change notifications > from DPLL device callbacks without deadlocking on dpll_lock, since > the callbacks are already invoked under that lock. Now that > __dpll_device_change_ntf() is exported for callers that already > hold dpll_lock, use it directly and remove the change_work > infrastructure entirely. > > This eliminates a race condition where change_work could be > re-scheduled after cancel_work_sync() during device teardown, > potentially causing the handler to dereference a freed or NULL > dpll_dev pointer. > > Fixes: 9363b4837659 ("dpll: zl3073x: Allow to configure phase offset averaging factor") > Signed-off-by: Ivan Vecera Hi Kuba & Paolo, patchwork reported netdev/build_allmodconfig_warn failure for this patch. But it looks weird: https://netdev-ctrl.bots.linux.dev/logs/build/1100767/14594344/build_allmodconfig_warn/stderr I don't understand how this is related to this patch. Thanks, Ivan