From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751484AbdBNPav (ORCPT ); Tue, 14 Feb 2017 10:30:51 -0500 Received: from mail-it0-f53.google.com ([209.85.214.53]:38519 "EHLO mail-it0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754123AbdBNPad (ORCPT ); Tue, 14 Feb 2017 10:30:33 -0500 Subject: Re: [PATCH] cdrom: Make device operations read-only To: Kees Cook , linux-kernel@vger.kernel.org References: <20170214002526.GA124769@beast> Cc: Jonathan Corbet , Tim Waugh , Borislav Petkov , "David S. Miller" , "James E.J. Bottomley" , "Martin K. Petersen" , linux-doc@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, kernel-hardening@lists.openwall.com From: Jens Axboe Message-ID: Date: Tue, 14 Feb 2017 08:30:25 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.0 MIME-Version: 1.0 In-Reply-To: <20170214002526.GA124769@beast> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/13/2017 05:25 PM, Kees Cook wrote: > Since function tables are a common target for attackers, it's best to keep > them in read-only memory. As such, this makes the CDROM device ops tables > const. This drops additionally n_minors, since it isn't used meaningfully, > and sets the only user of cdrom_dummy_generic_packet explicitly so the > variables can all be const. Agree, it's a good change. Applied for 4.11. -- Jens Axboe