From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD40635B14A for ; Thu, 15 Jan 2026 09:19:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768468775; cv=none; b=c/+aqnlnEsFzUY6KFUGLOUIZzrOjpw58LbxxiWojVJX9hf4VBtNaju+PXLtsBGYNBLvofWzoBFRLK3yyOUkpVhQVtq3Mj5iKl1QGvj04JyAUng5HwW84jMDEgm28HQfqlEbi6nCHOKfsxvUnnSZPd8w4d02rXb0h+JLLbzmep90= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768468775; c=relaxed/simple; bh=6s8VUZHOjMk4dyYpQf1ss5Wiadtz5G/FFe3LYD+4uu8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MI27TyyIXXlvY0/u3lZh/qzBdMMUnACk3WbP/dpLhtlToifRVGKQuYYdYX2VblChGo32Occi515m3WkN0Mggqm7ZFlrS6jwJSXQjLoNsnTBExY5NXfLt1QQjsSfsyaVyhFqg5eadiHwN09DXJxM919dQdm/jvXyqV4NnCMzA0fc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MhNRUBH8; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=UPSjRDBg; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MhNRUBH8"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="UPSjRDBg" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60F6g9hA1056300 for ; Thu, 15 Jan 2026 09:19:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= pURHtbp6VGKQeBQ/ldaen2l7gcfocWJuNey1NSuLoXc=; b=MhNRUBH8bvXRD6RZ ndIGPioDTeOHk0+CbIlS2sv7nj5KZRutmkVj5eprDgbygh7I1s2chnQW43pSv5Zv BjjTDnKRl9Def9ZPsAZfutqQBIcfhKO7enhGCtufkU8+JZwONHdk56CUIyMInfPO hHwcfmBfNnS7iBZVYm29ojxzPRW8GhIbxSai4Rx/U+anzDmVNF/UV2HYMpGLaDx1 mXm79nAF0DazHGE5qLp7VsImtysj3slenQbZ8sNDw8RWoynkgYyus/NJTG09Ec8P TetSGZIUfTV+13+3WuO1ZRQpXpPXNELSL2S57lMZA3WckylJEbuqoZR8NWsfmWME vjuzyA== Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bp8d3436g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 15 Jan 2026 09:19:32 +0000 (GMT) Received: by mail-qk1-f198.google.com with SMTP id af79cd13be357-8c52d47dfceso18551585a.3 for ; Thu, 15 Jan 2026 01:19:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1768468772; x=1769073572; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pURHtbp6VGKQeBQ/ldaen2l7gcfocWJuNey1NSuLoXc=; b=UPSjRDBg47Bf20Wo1Dp2J6anR9U0l7GWFpaqq02qyFOnJyItvYifCbqrzkGYZaQTu6 Ip5SY2bZR4hbnxgru+EDiimma4naD/eVS2TTug9/5GIVZVlB8Wn1fwYCF6Z6rDfFDfgQ POPH2x2ZZquEwwXTiD52M9USItjM19vvPISCMZfIGT3BNiONWILlmMzyyaNjuSIyAk3z 9dbdVl5xPzJcDY8tSrp2CsqTvkfbAA6+tnqDFBBcH/pTTUtc34rQwzF5TK9oBUoqLd0Z FoRhy8yRqkDMN5w7v9C0Qobt9zJ9HKoi54Y8RkfsxXo+4I96YKt2lj6KI8X9btZ6m2LS Fpjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768468772; x=1769073572; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=pURHtbp6VGKQeBQ/ldaen2l7gcfocWJuNey1NSuLoXc=; b=v8Uf45Qr0DpOwRPHT8pQIn+M3IOa4CeFac44YidOp2f2BSzBt+so6ZgmSvHHmXh5/F H+EYleHbWxH7ztW2jyb1OlAKagoE5bTC/CMR8zCtOBA+hMI0IYHT7Sagg0tmQn+bhmRs A9OrgZt0/+hxjFxyzD5vthgncvwcndragJV0qWmfVzYIT/ihvU73OwDbghFTb11UPZGU rkGcNJUmh1NFic+pZ/yVzp+I8evdzZxvNZSla3I1StaRM7LKeJm6R8WNjBXAMf1XPM3T qa5KFCUWHWz/PYKIyGW2QssECbCqfxmdcdBTGskqcj1E81jrYKg4a/UWtQPeA1LJUAVN icuQ== X-Forwarded-Encrypted: i=1; AJvYcCVCYEuYai2JtU9y2BYDcVmkCALpF9X0dN9IR3g4D1l684QfFO92LYg5pQzzM/JiYAhEoSuGLoEPuNPhprM=@vger.kernel.org X-Gm-Message-State: AOJu0YxXQDs69I++ejwcJFGKs+jaRdbnT5c77mrOC6huZ1H4XpWYLKbo sFIxalaXfjvnEhBKrTehI5PxUQlCQO6ojIQGpegDm3P7ncHGcE2NzRqO1U8joRyZ0UL/L+wTY+w jqfD8YeItNgQkrM9HRRm2EBOPuM6POPT/b51Gz7ThH3giKkEIzWpLl1fAaOAau+KMRSg= X-Gm-Gg: AY/fxX7v2Jw4gn0PexZoETZoKd4BqN5astQTwpk5dbhK8cHTqg1nOrqKs4lhGIteKwj OfMsMv157shxv4yQ5ilIQbJg1xElaVBaAXzr8IN3onSMoVBwXOT9Uwv6D904oX8q0+LcQxyHFOH +dxY1Z6eClVqS6r7gbtsYZDcOumYfCf5y9AvNBVv0OhyO2iZp1PFvnPXcq+K6kmfkLx+TrVzsqf B0HdK07knXgBKsXC2usWmxClMZ3UZNoJw39qRwLowTLyN1iuUhUJe3Gss+s1EMZefwlBnofp/e5 fk9vhdB2Ff1vA5XKNOHJotAAD8BjxK6E6TPfEbuykLCvrd1gXdIPZ6t3X+5uUmK1wyxTyLVe3vB 7ylJqteMlwxd4uIY9vcTo/FRXxgSi7BvZElKSNlbT/cRVdMkw+G6XwOsmJS/EtGoJ/9M= X-Received: by 2002:a05:620a:4154:b0:8c6:a22b:e11c with SMTP id af79cd13be357-8c6a22be2c5mr48272485a.1.1768468772078; Thu, 15 Jan 2026 01:19:32 -0800 (PST) X-Received: by 2002:a05:620a:4154:b0:8c6:a22b:e11c with SMTP id af79cd13be357-8c6a22be2c5mr48271185a.1.1768468771575; Thu, 15 Jan 2026 01:19:31 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6541197fb4asm1869724a12.15.2026.01.15.01.19.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 15 Jan 2026 01:19:30 -0800 (PST) Message-ID: Date: Thu, 15 Jan 2026 10:19:27 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/8] drm/msm/dp: Read DPCD and sink count in bridge detect() To: Dmitry Baryshkov , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , Kuogee Hsieh Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Jessica Zhang References: <20260115-hpd-refactor-v3-0-08e2f3bcd2e0@oss.qualcomm.com> <20260115-hpd-refactor-v3-3-08e2f3bcd2e0@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260115-hpd-refactor-v3-3-08e2f3bcd2e0@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: kf9vFNL_NE2XJDhgmN2qXYTb7ZXrvvm7 X-Authority-Analysis: v=2.4 cv=fbWgCkQF c=1 sm=1 tr=0 ts=6968b124 cx=c_pps a=qKBjSQ1v91RyAK45QCPf5w==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=iwLwdXV_GrZBMsYiV9oA:9 a=QEXdDO2ut3YA:10 a=NFOGd7dJGGMPyQGDc5-O:22 X-Proofpoint-ORIG-GUID: kf9vFNL_NE2XJDhgmN2qXYTb7ZXrvvm7 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTE1MDA2NCBTYWx0ZWRfX9sDgVWd07AQb 9lb0Z3uHNFM+K+l6rAq8Qj4LlOY3ooRcNozOKxekUZR/0a3oeNq7DJuJkl9AnAhW77xy66IGwka /8nygsio6zqTBAvWxeTLzpUZ/HlQXola9F6VL9fZElGabrEtX8lLaLuuakWEKEorb+tcW4hojKl gmX1KgenkYQYdMchxIxiHmb0YU3ERRF5D0VTPrCZSSwE3rHZFSWWfgy3QkT+eZdf+M3M3l7fZB3 OBjn96Kl3mqTV6j0zzL2dajuI9Lk0XVqwTiF3Sqmi+XinBkUu0aq5Bn9OaoitZIlwRQWhjvSdyR zU9CmMf99/JkFNFIka+Oqi//36NxJ/REmW8i+3ghrqoqI6pFOZ6QGFR6Z0G+n7kiOuqqWsHSsvj 3TRz+DJZsi2w7ffYZaNeusfOpHZ7jrl1dO8HK/swr2MhGRBShw9b7qYuq9iFg4PXtC5QZ6e3h7r dnbMnfLJrQfUFqbNqTw== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-15_02,2026-01-14_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 impostorscore=0 phishscore=0 priorityscore=1501 adultscore=0 clxscore=1015 malwarescore=0 bulkscore=0 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601150064 On 1/15/26 8:29 AM, Dmitry Baryshkov wrote: > From: Jessica Zhang > > Instead of relying on the link_ready flag to specify if DP is connected, > read the DPCD bits and get the sink count to accurately detect if DP is > connected. > > Signed-off-by: Jessica Zhang > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/dp/dp_display.c | 60 +++++++++++++++++++++++++++++++++++++ > drivers/gpu/drm/msm/dp/dp_drm.c | 20 ------------- > drivers/gpu/drm/msm/dp/dp_drm.h | 2 ++ > 3 files changed, 62 insertions(+), 20 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c > index 5997cd28ba11..a05144de3b93 100644 > --- a/drivers/gpu/drm/msm/dp/dp_display.c > +++ b/drivers/gpu/drm/msm/dp/dp_display.c > @@ -1151,6 +1151,66 @@ static int msm_dp_hpd_event_thread_start(struct msm_dp_display_private *msm_dp_p > return 0; > } > > +/** > + * msm_dp_bridge_detect - callback to determine if connector is connected > + * @bridge: Pointer to drm bridge structure > + * @connector: Pointer to drm connector structure > + * Returns: Bridge's 'is connected' status > + */ > +enum drm_connector_status msm_dp_bridge_detect(struct drm_bridge *bridge, > + struct drm_connector *connector) > +{ > + struct msm_dp_bridge *msm_dp_bridge = to_dp_bridge(bridge); > + struct msm_dp *dp = msm_dp_bridge->msm_dp_display; > + struct msm_dp_display_private *priv; > + int ret = 0; > + int status = connector_status_disconnected; > + u8 dpcd[DP_RECEIVER_CAP_SIZE]; > + struct drm_dp_desc desc; Reverse-Christmas-tree would be nice > + > + dp = to_dp_bridge(bridge)->msm_dp_display; > + > + priv = container_of(dp, struct msm_dp_display_private, msm_dp_display); > + > + if (!dp->link_ready) > + return status; > + > + msm_dp_aux_enable_xfers(priv->aux, true); > + > + ret = pm_runtime_resume_and_get(&dp->pdev->dev); > + if (ret) { See ef8057b07c72 ("PM: runtime: Wrapper macros for ACQUIRE()/ACQUIRE_ERR()") > + DRM_ERROR("failed to pm_runtime_resume\n"); > + msm_dp_aux_enable_xfers(priv->aux, false); > + return status; > + } > + > + ret = msm_dp_aux_is_link_connected(priv->aux); > + if (dp->internal_hpd && !ret) > + goto end; > + > + ret = drm_dp_read_dpcd_caps(priv->aux, dpcd); > + if (ret) > + goto end; > + > + ret = drm_dp_read_desc(priv->aux, &desc, drm_dp_is_branch(dpcd)); > + if (ret) > + goto end; > + > + status = connector_status_connected; > + if (drm_dp_read_sink_count_cap(connector, dpcd, &desc)) { > + int sink_count = drm_dp_read_sink_count(priv->aux); > + > + drm_dbg_dp(dp->drm_dev, "sink_count = %d\n", sink_count); > + > + if (sink_count <= 0) > + status = connector_status_disconnected; < 0 would be an error coming from drm_dp_dpcd_read_byte, should we log it? Konrad