mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ming Lei <tom.leiming@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: kay.sievers@vrfy.org, greg@kroah.com, cornelia.huck@de.ibm.com,
	linux-kernel@vger.kernel.org, arjan@linux.intel.com
Subject: Re: [PATCH] driver core: check bus->match without holding device  lock(v2)
Date: Sat, 11 Apr 2009 09:52:16 +0800	[thread overview]
Message-ID: <d82e647a0904101852h7f41492epad2226f29124452d@mail.gmail.com> (raw)
In-Reply-To: <m2fxggle43.fsf@igel.home>

2009/4/10 Andreas Schwab <schwab@linux-m68k.org>:
> diff --git a/drivers/base/base.h b/drivers/base/base.h
> index ddc9749..087e911 100644
> --- a/drivers/base/base.h
> +++ b/drivers/base/base.h
> @@ -115,7 +115,7 @@ extern int driver_probe_device(struct device_driver *drv, struct device *dev);
>  static inline int driver_match_device(struct device_driver *drv,
>                                      struct device *dev)
>  {
> -       return drv->bus->match && drv->bus->match(dev, drv);
> +       return !drv->bus->match || drv->bus->match(dev, drv);
>  }

A similar patch has been in greg's tree:

http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/driver-core.current/driver-core-fix-driver_match_device.patch

Thanks!

-- 
Lei Ming

      reply	other threads:[~2009-04-11  1:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-21 15:27 tom.leiming
2009-01-21 15:59 ` Cornelia Huck
2009-04-10 15:31 ` Andreas Schwab
2009-04-11  1:52   ` Ming Lei [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d82e647a0904101852h7f41492epad2226f29124452d@mail.gmail.com \
    --to=tom.leiming@gmail.com \
    --cc=arjan@linux.intel.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=greg@kroah.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=schwab@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome