From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754998AbdKFXsi (ORCPT ); Mon, 6 Nov 2017 18:48:38 -0500 Received: from osg.samsung.com ([64.30.133.232]:42123 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752812AbdKFXsW (ORCPT ); Mon, 6 Nov 2017 18:48:22 -0500 Subject: Re: [PATCH] selftests: futex: fix compilation error To: Lei Yang Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan , shuah Khan References: <1509941009-11521-1-git-send-email-Lei.Yang@windriver.com> <6b0b866a-b142-8c07-41e3-d561d4b91fb3@osg.samsung.com> From: Shuah Khan Message-ID: Date: Mon, 6 Nov 2017 16:48:19 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <6b0b866a-b142-8c07-41e3-d561d4b91fb3@osg.samsung.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/06/2017 04:45 PM, Shuah Khan wrote: > On 11/05/2017 09:03 PM, Lei Yang wrote: >> I run into below error when building futext >> /bin/sh: -c: line 5: syntax error: unexpected end of file >> >> the closing ";" and "\" are necessary. >> My OS is "Ubuntu 14.04.5 LTS" >> >> Signed-off-by: Lei Yang >> --- >> tools/testing/selftests/futex/Makefile | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile >> index f0c0369..943f3a2 100644 >> --- a/tools/testing/selftests/futex/Makefile >> +++ b/tools/testing/selftests/futex/Makefile >> @@ -11,9 +11,9 @@ all: >> BUILD_TARGET=$(OUTPUT)/$$DIR; \ >> mkdir $$BUILD_TARGET -p; \ >> make OUTPUT=$$BUILD_TARGET -C $$DIR $@;\ >> - if [ -e $$DIR/$(TEST_PROGS) ]; then >> - rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; >> - fi >> + if [ -e $$DIR/$(TEST_PROGS) ]; then \ >> + rsync -a $$DIR/$(TEST_PROGS) $$BUILD_TARGET/; \ >> + fi \ >> done >> >> override define RUN_TESTS >> > > Hmm. I don't see this error on linux_4.14-rc8? > > Can you give more details on the gcc version you are using? I meant gnumake version? I am not seeing the failure with what I am using thanks, -- Shuah