From: Paolo Abeni <pabeni@redhat.com>
To: Daniel Machon <daniel.machon@microchip.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: Sagi Maimon <maimon.sagi@gmail.com>, Joe Damato <joe@dama.to>,
netdev@vger.kernel.org, radhey.shyam.pandey@amd.com,
michal.simek@amd.com, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, daniel@iogearbox.net,
jacob.e.keller@intel.com, suraj.gupta2@amd.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net v3] net: axienet: free outstanding TX buffers in axienet_dma_bd_release()
Date: Thu, 15 Oct 2026 09:35:58 +0200 [thread overview]
Message-ID: <d832de5c-a01a-471d-b935-5ea00d1c5794@redhat.com> (raw)
In-Reply-To: <20261011084652.c5y3zj7wzmj53ur4@DEN-DL-M70577>
On 10/11/26 10:46, Daniel Machon wrote:
>> On Tue, 6 Oct 2026 06:44:55 +0300 Sagi Maimon wrote:
>>> Agreed on the helper. As on v2, I kept the fix minimal for net, and
>>> will send the helper to net-next once this has reached it, with both
>>> axienet_dma_bd_release() and axienet_dma_err_handler() using it.
>>
>> Let's do this now, trying to keep fixes small is a bit of
>> an anti-pattern
>
> Out of curiosity, why is that an anti-pattern?
>
> I'd think that small fixes are, in general, easier to backport to stable. Is this
> more of procedural question - if the whole fix gets into net, it will get merged
> into net-next by the end of the week anyway?
I'm answering here because I can only guess how scarefully long is
Jakub's email backlog, and possibly this could get lost.
I think the key here is the context. This revision is incorrect because
in order to be minimal intentionally adds a significant chunk of duplicate
code, but such duplication must be avoided, the 'keep is small' is not a
good argument to allow that.
I guess a one-line alternative implementing a different solution
(if existing) could have been ok.
/P
next prev parent reply other threads:[~2026-10-15 7:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-04 8:37 Sagi Maimon
2026-10-05 23:41 ` Joe Damato
2026-10-06 3:44 ` Sagi Maimon
2026-10-07 1:02 ` Jakub Kicinski
2026-10-11 8:46 ` Daniel Machon
2026-10-15 7:35 ` Paolo Abeni [this message]
2026-10-15 8:03 ` Daniel Machon
2026-10-07 3:46 ` [PATCH net v4] " Sagi Maimon
2026-10-08 15:47 ` netdev-bot+sashiko
2026-10-11 5:00 ` Sagi Maimon
2026-10-14 18:57 ` Simon Horman
2026-10-15 7:30 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d832de5c-a01a-471d-b935-5ea00d1c5794@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=daniel.machon@microchip.com \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=joe@dama.to \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maimon.sagi@gmail.com \
--cc=michal.simek@amd.com \
--cc=netdev@vger.kernel.org \
--cc=radhey.shyam.pandey@amd.com \
--cc=suraj.gupta2@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®