From: Chen Yu <yu.c.chen@intel.com>
To: tony.luck@intel.com, reinette.chatre@intel.com
Cc: tglx@kernel.org, bp@alien8.de, mingo@redhat.com,
dave.hansen@linux.intel.com, hpa@zytor.com, fenghuay@nvidia.com,
babu.moger@amd.com, hongyu.ning@intel.com, chen.yu@linux.dev,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v10 07/12] x86/resctrl: Parse ACPI CMRC table
Date: Thu, 5 Nov 2026 18:09:14 +0800 [thread overview]
Message-ID: <d83563076e5f945078a83aa5f10d430b1fb5e561.1793864720.git.yu.c.chen@intel.com> (raw)
In-Reply-To: <cover.1793864720.git.yu.c.chen@intel.com>
The CMRC (Cache Monitoring Registers for CPU Agents Description) sub-table of
ERDT describes the MMIO registers used to read the LLC occupancy counters of an
ERDT domain.
Reading the LLC occupancy of an RMID via MMIO, rather than via the
IA32_QM_EVTSEL/IA32_QM_CTR MSRs, requires the following data from the CMRC
sub-table:
- Where the counters are: the base address and size of the domain's
monitoring register block.
- How the counters are laid out: the index function, clump size and clump
stride, which locate the counter of a given RMID within that block.
- How to interpret a counter value: the flags, which indicate whether a
counter can report that its data is unavailable, and up_scale, which
converts a counter value to bytes.
The LLC occupancy read path needs all of this data on every read. The limbo
handler also needs up_scale to round its occupancy threshold.
Parse each CMRC sub-table, validate the data above, ioremap the monitoring
register block and save a copy of the CMRC sub-table in the corresponding ERDT
domain entry.
Suggested-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Chen Yu <yu.c.chen@intel.com>
Tested-by: Hongyu Ning <hongyu.ning@linux.intel.com>
---
Changes since v9:
- Rebased on the kernel-doc enum erdt_mmio_type from "x86/resctrl:
Parse ACPI ERDT table and save CACD cpumask per RMD". No code change.
arch/x86/kernel/cpu/resctrl/erdt.c | 53 ++++++++++++++++++++++++++
arch/x86/kernel/cpu/resctrl/internal.h | 6 ++-
2 files changed, 58 insertions(+), 1 deletion(-)
diff --git a/arch/x86/kernel/cpu/resctrl/erdt.c b/arch/x86/kernel/cpu/resctrl/erdt.c
index 1b07dd734b9b..ef7f51fde838 100644
--- a/arch/x86/kernel/cpu/resctrl/erdt.c
+++ b/arch/x86/kernel/cpu/resctrl/erdt.c
@@ -23,6 +23,7 @@ static LIST_HEAD(domain_info_list);
static bool erdt_enabled;
#define ERDT_VALID_REVISION 1
+#define CMRC_SUPPORTED_INDEX_FN 1
#define RMDD_FLAG_CPU_L3_DOMAIN BIT(0)
#define ERDT_DOMAIN_ID_UNSET -1
@@ -65,6 +66,7 @@ static void erdt_iounmap_domain(struct erdt_domain_info *domain)
static void cleanup_one_domain(struct erdt_domain_info *d)
{
erdt_iounmap_domain(d);
+ kfree(d->cmrc);
kfree(d);
}
@@ -98,6 +100,47 @@ static __init bool cacd_init(struct acpi_subtbl_hdr_16 *subtbl,
return true;
}
+static __init bool cmrc_init(struct acpi_subtbl_hdr_16 *subtbl,
+ struct erdt_domain_info *domain_info)
+{
+ struct acpi_erdt_cmrc *cmrc = (struct acpi_erdt_cmrc *)subtbl;
+
+ if (cmrc->header.length < sizeof(*cmrc)) {
+ pr_warn(FW_BUG "Truncated CMRC sub-table\n");
+ return false;
+ }
+
+ if (cmrc->index_fn != CMRC_SUPPORTED_INDEX_FN) {
+ pr_info("Unsupported CMRC index function %u\n", cmrc->index_fn);
+ return false;
+ }
+
+ if (!cmrc->clump_size) {
+ pr_warn(FW_BUG "CMRC clump_size is zero\n");
+ return false;
+ }
+
+ /* resctrl scales monitoring values with an unsigned int. */
+ if (cmrc->up_scale > UINT_MAX) {
+ pr_warn(FW_BUG "Insane CMRC up_scale value 0x%llx\n", cmrc->up_scale);
+ return false;
+ }
+
+ domain_info->base[ERDT_MMIO_CMRC_BASE] =
+ erdt_ioremap(cmrc->cmt_reg_base, cmrc->cmt_reg_size, "CMRC base");
+ if (!domain_info->base[ERDT_MMIO_CMRC_BASE])
+ return false;
+
+ domain_info->cmrc = kmemdup(cmrc, cmrc->header.length, GFP_KERNEL);
+ if (!domain_info->cmrc) {
+ iounmap(domain_info->base[ERDT_MMIO_CMRC_BASE]);
+ domain_info->base[ERDT_MMIO_CMRC_BASE] = NULL;
+ return false;
+ }
+
+ return true;
+}
+
static inline struct acpi_subtbl_hdr_16 *next_subtbl(struct acpi_subtbl_hdr_16 *subtbl)
{
return (void *)subtbl + subtbl->length;
@@ -154,6 +197,16 @@ static __init bool parse_rmdd_table(struct acpi_subtbl_hdr_16 *rmdd_hdr)
subtbl_mask |= BIT(ACPI_ERDT_TYPE_CACD);
break;
+ /* An RMDD table supports at most one CMRC sub-table */
+ case ACPI_ERDT_TYPE_CMRC:
+ if (subtbl_mask & BIT(ACPI_ERDT_TYPE_CMRC))
+ break;
+
+ if (!cmrc_init(subtbl, domain_info))
+ goto cleanup;
+
+ subtbl_mask |= BIT(ACPI_ERDT_TYPE_CMRC);
+ break;
default:
break;
}
diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
index deb033155f31..527e3ac91b26 100644
--- a/arch/x86/kernel/cpu/resctrl/internal.h
+++ b/arch/x86/kernel/cpu/resctrl/internal.h
@@ -24,11 +24,13 @@
/**
* enum erdt_mmio_type - Index into erdt_domain_info::base[] for each MMIO region
* @ERDT_MMIO_RMDD_CREG: RMDD control register base address
+ * @ERDT_MMIO_CMRC_BASE: CMRC monitoring register base address
* @ERDT_MMIO_LAST: Last MMIO region type
*/
enum erdt_mmio_type {
ERDT_MMIO_RMDD_CREG,
- ERDT_MMIO_LAST = ERDT_MMIO_RMDD_CREG
+ ERDT_MMIO_CMRC_BASE,
+ ERDT_MMIO_LAST = ERDT_MMIO_CMRC_BASE
};
#define ERDT_MMIO_NUM_TYPES (ERDT_MMIO_LAST + 1)
@@ -36,6 +38,7 @@ enum erdt_mmio_type {
/**
* struct erdt_domain_info - L3 domain ERDT information
* @base: Array of ioremapped MMIO region base addresses, indexed by ERDT_MMIO_*
+ * @cmrc: Copy of the ACPI CMRC sub-table for this domain
* @cpu_mask: CPUs belonging to this resource management domain
* @dom_id: L3 cache ID shared by all CPUs in this domain
* (ERDT_DOMAIN_ID_UNSET if unset)
@@ -43,6 +46,7 @@ enum erdt_mmio_type {
*/
struct erdt_domain_info {
void __iomem *base[ERDT_MMIO_NUM_TYPES];
+ struct acpi_erdt_cmrc *cmrc;
struct cpumask cpu_mask;
int dom_id;
struct list_head entry;
--
2.25.1
next prev parent reply other threads:[~2026-11-05 10:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-05 10:07 [PATCH v10 00/12] Introduce MMIO-based CMT access for Enhanced RDT Chen Yu
2026-11-05 10:08 ` [PATCH v10 01/12] x86/topology: Export topo_lookup_cpuid() for resctrl use Chen Yu
2026-11-05 10:08 ` [PATCH v10 02/12] arm,x86,fs/resctrl: Move resctrl_arch_round_mon_val() out of line Chen Yu
2026-11-05 10:08 ` [PATCH v10 03/12] x86/resctrl: Require 64-bit x86 for resctrl support Chen Yu
2026-11-05 10:08 ` [PATCH v10 04/12] x86/resctrl: Detect Sub-NUMA Cluster mode before enumerating resources Chen Yu
2026-11-05 10:08 ` [PATCH v10 05/12] x86/resctrl: Parse ACPI ERDT table and save CACD cpumask per RMD Chen Yu
2026-11-05 10:08 ` [PATCH v10 06/12] x86/resctrl: Attach ACPI ERDT information to L3 mon domain on CPU online Chen Yu
2026-11-05 10:09 ` Chen Yu [this message]
2026-11-05 10:09 ` [PATCH v10 08/12] x86/resctrl: Refactor the monitor read function Chen Yu
2026-11-05 10:09 ` [PATCH v10 09/12] fs/resctrl: Do not invoke smp_processor_id() in preemptible context Chen Yu
2026-11-05 10:09 ` [PATCH v10 10/12] x86/resctrl: Introduce erdt_cpu_has() and erdt_support() Chen Yu
2026-11-05 10:09 ` [PATCH v10 11/12] x86/resctrl: Add the ERDT CMT scale Chen Yu
2026-11-05 10:10 ` [PATCH v10 12/12] x86/resctrl: Add MMIO-based LLC occupancy monitoring support Chen Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d83563076e5f945078a83aa5f10d430b1fb5e561.1793864720.git.yu.c.chen@intel.com \
--to=yu.c.chen@intel.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=chen.yu@linux.dev \
--cc=dave.hansen@linux.intel.com \
--cc=fenghuay@nvidia.com \
--cc=hongyu.ning@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=reinette.chatre@intel.com \
--cc=tglx@kernel.org \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®