From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932839AbcILNBQ (ORCPT ); Mon, 12 Sep 2016 09:01:16 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:58014 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757742AbcILNBM (ORCPT ); Mon, 12 Sep 2016 09:01:12 -0400 Subject: Re: [PATCH] watchdog: rt2880_wdt: Remove assignment of dev pointer To: Matt Redfearn , Wim Van Sebroeck References: <1473672913-10484-1-git-send-email-matt.redfearn@imgtec.com> Cc: linux-kernel@vger.kernel.org, linux-watchdog@vger.kernel.org From: Guenter Roeck Message-ID: Date: Mon, 12 Sep 2016 06:01:06 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1473672913-10484-1-git-send-email-matt.redfearn@imgtec.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/12/2016 02:35 AM, Matt Redfearn wrote: > Commit 0254e953537c ("watchdog: Drop pointer to watchdog device from > struct watchdog_device") removed the dev pointer from struct > watchdog_device, but this driver was still assigning it, leading to a > compilation error: > > drivers/watchdog/rt2880_wdt.c: In function ‘rt288x_wdt_probe’: > drivers/watchdog/rt2880_wdt.c:161:16: error: ‘struct watchdog_device’ > has no member named ‘dev’ > rt288x_wdt_dev.dev = &pdev->dev; > ^ > scripts/Makefile.build:289: recipe for target > 'drivers/watchdog/rt2880_wdt.o' failed > > Fix this by removing the assignment. > > Fixes: 0254e953537c Fixes: 0254e953537c ("watchdog: Drop pointer to watchdog device ...") > Signed-off-by: Matt Redfearn Cc: stable@vger.kernel.org # v4.5+ Reviewed-by: Guenter Roeck > --- > > drivers/watchdog/rt2880_wdt.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/watchdog/rt2880_wdt.c b/drivers/watchdog/rt2880_wdt.c > index 1967919ae743..14b4fd428fff 100644 > --- a/drivers/watchdog/rt2880_wdt.c > +++ b/drivers/watchdog/rt2880_wdt.c > @@ -158,7 +158,6 @@ static int rt288x_wdt_probe(struct platform_device *pdev) > > rt288x_wdt_freq = clk_get_rate(rt288x_wdt_clk) / RALINK_WDT_PRESCALE; > > - rt288x_wdt_dev.dev = &pdev->dev; > rt288x_wdt_dev.bootstatus = rt288x_wdt_bootcause(); > rt288x_wdt_dev.max_timeout = (0xfffful / rt288x_wdt_freq); > rt288x_wdt_dev.parent = &pdev->dev; >