From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53BE633F390; Wed, 4 Feb 2026 16:57:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770224273; cv=none; b=kf4rZYXfGwVSg34eO4ViC6aPZheaIPd9ojY5JM1GMlJbCGZ9nIcT0SpVDA579q7O7F4NPTtrmT22UxtcAyaEJCOEciQO+4hBNX+eU/hJs4as7dpsMn4yRLWiJjwPVV0b+hU9Q0N9EaCQtQE6dcJ2SI/hAyw8BQCciso4/7TOeK4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770224273; c=relaxed/simple; bh=ZGQw8SCQ9E5j0Rr/XYKdccY0ozg61wegwtmjgf9knpw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FF7Qt+GhiNjbw5SCbqKrI7RDKUK2Ye+o/VFmj72MycuqfbLzrR7F8eU2QTmHRe8HfXn031jjqQX8c9ksaVxFo3WDcDl+6v6LOGZBrUbbVzzG3hLKjb2i5d6X9Cslx5kYm4YWv4fayHkj3P80s0tB1mUn/W6gg9ZhwC5jCFNfPAg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gmT1ttEa; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gmT1ttEa" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 959E6C2BCAF; Wed, 4 Feb 2026 16:57:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770224273; bh=ZGQw8SCQ9E5j0Rr/XYKdccY0ozg61wegwtmjgf9knpw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gmT1ttEaV6VHa6LjeygKPjKrXbF9cn6bkLS8Hixz05qev/YLnSPdiQoKEOXScVQjS oUK/R7lMyCEsunU56p0dxTXmn7ux5rGjrUGZfl0xhT9ZVRM07Gi8ALxo0RNsTf3P9o BZ8IO3YnOwF5Zppa0YUhGJkU7NlPMqquJU1QoH3Z890IQhEm9F0Wb8p0Ev8Hj1wMiz NaM6gi+cuGPqxh+ZZe+T0yYdfxIpl9zrOsOrAgjZoKnNAYTFqzEoJ1R/kzUq1fxNi8 OLWvCel+C5n0DXL665B6u5BkxBt6cduqrbQsknYzOcyPl1Qgh1HrXXwFt6HrQcm8g5 OyWXhZpDIZccg== Date: Wed, 4 Feb 2026 16:57:47 +0000 From: Mark Brown To: Konrad Dybcio Cc: Praveen Talari , linux-arm-msm@vger.kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, bjorn.andersson@oss.qualcomm.com, dmitry.baryshkov@oss.qualcomm.com, prasad.sodagudi@oss.qualcomm.com, mukesh.savaliya@oss.qualcomm.com, quic_vtanuku@quicinc.com, aniket.randive@oss.qualcomm.com, chandana.chiluveru@oss.qualcomm.com, jyothi.seerapu@oss.qualcomm.com Subject: Re: [PATCH v2 4/4] spi: geni-qcom: Add target abort support Message-ID: References: <20260204162854.1206323-1-praveen.talari@oss.qualcomm.com> <20260204162854.1206323-5-praveen.talari@oss.qualcomm.com> <68908c06-390e-4717-bab2-708de7f5cec4@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="zOcovwL2eKNVIBjj" Content-Disposition: inline In-Reply-To: <68908c06-390e-4717-bab2-708de7f5cec4@oss.qualcomm.com> X-Cookie: Are you having fun yet? --zOcovwL2eKNVIBjj Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Feb 04, 2026 at 05:41:46PM +0100, Konrad Dybcio wrote: > On 2/4/26 5:28 PM, Praveen Talari wrote: > > + if (spi->target) > > + spi->target_abort = spi_geni_target_abort; > The same check is made in core: > spi_target_abort() > -> spi_controller_is_target() > So I'm assuming the intention was to allow assigning the func pointer > indiscriminately. Other drivers seem to do it both ways. > Mark, any specific preference? Not really TBH, it's redundant in the driver but if the people working on the driver find having the check there saves them having to check that the core does the right thing that's fine. It's not like this is a fast path. --zOcovwL2eKNVIBjj Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmmDeosACgkQJNaLcl1U h9DQYgf/chdsxM+HwPg2STRHNhREd80182DYjukMSvYRHMMXM1BCANch+8pQC3w0 1VJSRdIBLeqQEAxVY+agsHDSQJfJlYnC0MvSzsH/+1GnfmTnZ1lCBLyzOs7sL+k3 HG1muaHg7dZmuNpjdnwlO58z50+djPytYER8FsLkzBnyLVVrvF2ToyCvE5tILgF2 rTwLTIh1X/BDfVIHhGEN3Y+YShXyHMBztUUHR4sU4wtFctBxt602I6XFCWdbrO4N JAIanc87gcxixK7w8T5JBBM/MY4cnUI5gxnoGGakSROeIGndb9J2BFYadMwEK/Yn F3XoaagZRw9CE4fXUu2T2Uh108vljw== =0TVW -----END PGP SIGNATURE----- --zOcovwL2eKNVIBjj--