From: Andrew Lunn <andrew@lunn.ch>
To: David Yang <mmyangfl@gmail.com>
Cc: netdev@vger.kernel.org, Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: dsa: motorcomm: Report error when FDB fails to add
Date: Mon, 26 Oct 2026 01:44:24 +0100 [thread overview]
Message-ID: <d841a56b-1ec4-4095-9040-cc67f4f91956@lunn.ch> (raw)
In-Reply-To: <20261025024114.1955782-1-mmyangfl@gmail.com>
On Sun, Oct 25, 2026 at 10:41:11AM +0800, David Yang wrote:
> fdb_add() ignored any errors returned by the hardware (for example,
> table is full). Return error for that case.
>
> Fixes: 186623f4aa72 ("net: dsa: yt921x: Add support for Motorcomm YT921x")
> Signed-off-by: David Yang <mmyangfl@gmail.com>
I'm not sure this deserves a Fixes tag. How many entries does the
table take before it is full? Typical home networks have what, 10, 20
devices maximum. A small business network may have a couple of
hundred?
What happens if it is full, and you don't return ENOSPC?
Andrew
next prev parent reply other threads:[~2026-10-26 0:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-25 2:41 David Yang
2026-10-25 2:46 ` netdev-bot+sinfo
2026-10-26 0:44 ` Andrew Lunn [this message]
2026-10-26 8:35 ` David Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d841a56b-1ec4-4095-9040-cc67f4f91956@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmyangfl@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®