From: Logan Gunthorpe <logang@deltatee.com>
To: Marshall Midden <marshallmidden@gmail.com>,
joro@8bytes.org, will@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: v5.15-rc7 AMD no kernel dump, spews "scsi_dma_map failed: request for 36 bytes!"
Date: Wed, 27 Oct 2021 10:41:51 -0600 [thread overview]
Message-ID: <d8434a1a-b813-958f-69d7-34007faa49b7@deltatee.com> (raw)
In-Reply-To: <CAD2CkAWjS8=kKwEEN4cgVNjyFORUibzEiCUA-X+SMtbo0JoMmA@mail.gmail.com>
Hi,
On 2021-10-27 10:08 a.m., Marshall Midden wrote:
> v5.15-rc7 AMD no kernel dump, spews "scsi_dma_map failed: request for 36 bytes!"
>
> With v5.15-rc (1 through 7), AMD processor kernel crash dumps do not occur,
> instead spews:
> "scsci_dma_map failed: request for 36 bytes!"
> Works on Intel machines, and in v5.14.0 (and v5.14.14) - as well as previous
> kernels (down to v5.3.x.)
> git bisect torvalds repository shows: dabb16f67215918c48cf3ff1fc4bc36ca421da2b
> Reverse patch to tag v5.15-rc7 allows kernel crash dumps to occur/happen.
>
On careful review I think I see what might be causing this. Can you
please try the following patch?
Thanks,
Logan
--
diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c
index cd0f1a593997..3bfb5da87802 100644
--- a/drivers/iommu/dma-iommu.c
+++ b/drivers/iommu/dma-iommu.c
@@ -1028,7 +1028,8 @@ static int iommu_dma_map_sg(struct device *dev,
struct sc>
if (static_branch_unlikely(&iommu_deferred_attach_enabled)) {
ret = iommu_deferred_attach(dev, domain);
- goto out;
+ if (ret)
+ goto out;
}
if (!(attrs & DMA_ATTR_SKIP_CPU_SYNC))
next prev parent reply other threads:[~2021-10-27 16:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-27 16:08 Marshall Midden
2021-10-27 16:41 ` Logan Gunthorpe [this message]
2021-10-27 17:21 ` Marshall Midden
2021-10-27 17:24 ` Logan Gunthorpe
2021-10-27 17:44 ` Marshall Midden
2021-10-27 17:45 ` Logan Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8434a1a-b813-958f-69d7-34007faa49b7@deltatee.com \
--to=logang@deltatee.com \
--cc=joro@8bytes.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marshallmidden@gmail.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®