From: Andrew Davis <afd@ti.com>
To: Antoni Pokusinski <apokusinski01@gmail.com>, <vigneshr@ti.com>,
<andi.shyti@kernel.org>, <robh@kernel.org>, <krzk+dt@kernel.org>,
<conor+dt@kernel.org>, <aaro.koskinen@iki.fi>,
<andreas@kemnade.info>, <khilman@baylibre.com>,
<rogerq@kernel.org>, <tony@atomide.com>, <jmkrzyszt@gmail.com>,
<sumit.semwal@linaro.org>, <christian.koenig@amd.com>,
<phasta@kernel.org>
Cc: <linux-omap@vger.kernel.org>, <linux-i2c@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-media@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
<linaro-mm-sig@lists.linaro.org>
Subject: Re: [PATCH v2 3/4] i2c: omap: remove unused is_rdr and is_xdr function arguments
Date: Wed, 18 Nov 2026 18:58:30 -0600 [thread overview]
Message-ID: <d84aab69-c5b8-4718-90ce-7b6abcb9e9a2@ti.com> (raw)
In-Reply-To: <20261118205213.88778-4-apokusinski01@gmail.com>
On 11/18/26 2:52 PM, Antoni Pokusinski wrote:
> Both functions omap_i2c_{receive|transmit}_data() have unused arguments
> is_{r|x}dr which can be deleted.
>
> Signed-off-by: Antoni Pokusinski <apokusinski01@gmail.com>
> ---
I sent this same patch a few months ago..
https://patchwork.ozlabs.org/project/linux-i2c/patch/20260908154223.116074-3-afd@ti.com/
> drivers/i2c/busses/i2c-omap.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index f02d294db42a..3f7060d57a86 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -996,8 +996,7 @@ static int errata_omap3_i462(struct omap_i2c_dev *omap)
> return 0;
> }
>
> -static void omap_i2c_receive_data(struct omap_i2c_dev *omap, u8 num_bytes,
> - bool is_rdr)
> +static void omap_i2c_receive_data(struct omap_i2c_dev *omap, u8 num_bytes)
> {
> u16 w;
>
> @@ -1017,8 +1016,7 @@ static void omap_i2c_receive_data(struct omap_i2c_dev *omap, u8 num_bytes,
> }
> }
>
> -static int omap_i2c_transmit_data(struct omap_i2c_dev *omap, u8 num_bytes,
> - bool is_xdr)
> +static int omap_i2c_transmit_data(struct omap_i2c_dev *omap, u8 num_bytes)
> {
> u16 w;
>
> @@ -1122,7 +1120,7 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *omap)
> OMAP_I2C_BUFSTAT_REG) >> 8) & 0x3F;
> }
>
> - omap_i2c_receive_data(omap, num_bytes, true);
> + omap_i2c_receive_data(omap, num_bytes);
> omap_i2c_ack_stat(omap, OMAP_I2C_STAT_RDR);
> continue;
> }
> @@ -1133,7 +1131,7 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *omap)
> if (omap->threshold)
> num_bytes = omap->threshold;
>
> - omap_i2c_receive_data(omap, num_bytes, false);
> + omap_i2c_receive_data(omap, num_bytes);
> omap_i2c_ack_stat(omap, OMAP_I2C_STAT_RRDY);
> continue;
> }
> @@ -1145,7 +1143,7 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *omap)
> if (omap->fifo_size)
> num_bytes = omap->buf_len;
>
> - ret = omap_i2c_transmit_data(omap, num_bytes, true);
> + ret = omap_i2c_transmit_data(omap, num_bytes);
> if (ret < 0)
> break;
>
> @@ -1160,7 +1158,7 @@ static int omap_i2c_xfer_data(struct omap_i2c_dev *omap)
> if (omap->threshold)
> num_bytes = omap->threshold;
>
> - ret = omap_i2c_transmit_data(omap, num_bytes, false);
> + ret = omap_i2c_transmit_data(omap, num_bytes);
> if (ret < 0)
> break;
>
next prev parent reply other threads:[~2026-11-19 1:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-18 20:52 [PATCH v2 0/4] i2c: omap: add support for DMA Antoni Pokusinski
2026-11-18 20:52 ` [PATCH v2 1/4] dt-bindings: i2c: ti,omap4-i2c: Add DMA properties Antoni Pokusinski
2026-11-18 20:52 ` [PATCH v2 2/4] ARM: dts: am33xx-l4: Add missing DMAs for I2C controllers Antoni Pokusinski
2026-11-18 20:52 ` [PATCH v2 3/4] i2c: omap: remove unused is_rdr and is_xdr function arguments Antoni Pokusinski
2026-11-19 0:58 ` Andrew Davis [this message]
2026-11-18 20:52 ` [PATCH v2 4/4] i2c: omap: add DMA support Antoni Pokusinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d84aab69-c5b8-4718-90ce-7b6abcb9e9a2@ti.com \
--to=afd@ti.com \
--cc=aaro.koskinen@iki.fi \
--cc=andi.shyti@kernel.org \
--cc=andreas@kemnade.info \
--cc=apokusinski01@gmail.com \
--cc=christian.koenig@amd.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jmkrzyszt@gmail.com \
--cc=khilman@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=phasta@kernel.org \
--cc=robh@kernel.org \
--cc=rogerq@kernel.org \
--cc=sumit.semwal@linaro.org \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®