From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7CDF61A2545 for ; Mon, 30 Dec 2024 09:33:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735551235; cv=none; b=o7fyKqUc8T/N4LGWDSetAbfl7SOw+PUowEvcn3w9s3ZK4ZmsbbpECkSpTAtWTghwEQ6FimxTXTjLtx+QJH4wbO1nysy7yxgHPSu4b/q8NDBRHTkNDHZk7Qg175ASx/oUWfO0rI9TBiKgknuTKZxmKfoB08pGCO6Te0utmVtQWuE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735551235; c=relaxed/simple; bh=dYwHpSJUhuUAG0fqkuiQHa2k6x4/1UvSqmN7TRAtCSE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RunlWnhSziKRPWSQ8ADF/1iCvyARQ8DbftqO3oTU5yGR5Un0ti62MfoQ8vtRQF8wGObv7t96fhIuZ1q/CjTH+5xiW2/3YnEJG2Mzf/lrTBnck7D0BRBk+bIBdaPg8bYETTsMPl7+YukcAHe6PKmumLrEqJJ4x9NQex91WNCnNJU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=BMwOfNZq; arc=none smtp.client-ip=209.85.128.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BMwOfNZq" Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43675b1155bso74757355e9.2 for ; Mon, 30 Dec 2024 01:33:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1735551232; x=1736156032; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CWxCLyK4AJgfk1FfjpH9G6YxLoJtD0ixlqlSrDwjPFI=; b=BMwOfNZqxJdxb5G6NDUdiCws70XcndKFjb/Dz0WEzww65LAM4z6/JPYmcZdaowceu6 syW20bfbOGc7c+04FCab0dhZncE3xFrN9pNtHom2X/700PsjpvIvunQWZI1TTUquUHBK nYDSdY4p8pPzXMSAPObVupqR8hMdtxcgjHihnmCX7kJToFjZd/9yNsJ3wnJpAxK8RTBp LG8tw7B5s8Z83z7krL2seYWAN4Q8r3Gf1LehCWlCm37nm2Ys6OHF+/LBiQ2rECnq9hCA bepDEPVfUvw6alkIv+I424gWQkIRaFOLi4R11Z89VaeCif489h6fO4W6358EEFfbCOYz tW1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735551232; x=1736156032; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CWxCLyK4AJgfk1FfjpH9G6YxLoJtD0ixlqlSrDwjPFI=; b=vHu/oExrxbjMoiSRuHQqtmnlspMeVPpq/tQBFmWsrKQZoCUfIuKo53iGn+3yHpW4eM iqDimwwISoDf7NATFpzj7ho+8oQ59orfVB4dpvYX0pd4jXdDr0bghvJAgDIsMX4lSjk/ T+aJfYYL+wq8N77tnlHqPXh62qmWDlPc2gIkT551VEcz5jGYPzEDUgTzy/D63VkW05Rv afv8exYOMZDVmaiMRdT5yYp4sv5IGPGrPTIdXGGd0vmVbIJzamzCIV8xBQ9oUHGY7DEI ol+JFEpOj08c4Jv6hhJnCyFxQKbsIrACAmb4BHVl+xubWWxmFH4c2apAxFRkCjQZKjwg iqgw== X-Forwarded-Encrypted: i=1; AJvYcCVM+dE4cnvKjQ+PJbL6cFMty4SpYbNVoiYCxYeKk26xKSpKv9YfbMu9r6fSEI09X/1y89KnsCScOhZJJsU=@vger.kernel.org X-Gm-Message-State: AOJu0Yw04EuBbkQro2n7GV4Al8zCr181u4nm6GBl/41zjbLqRaHV+DK6 b2fRbk8Bz7GsCFZGp3kUW7wAOoYPbs4iHc8Ja0mqsrqAe/53wI1goWIgg1CyLbA= X-Gm-Gg: ASbGncvdxdvUzgIJimzqsiEe2S2K03nHiyOIQaZrYBGX4JL1pCMmMq4HFwEQMF49Oij RUUg/Ron7hiCJw399Kde6Cvwou1R/CLNysJHrFZc6T4qya4vj/Bj0C9cZcPp6X816nH4KBylnka WNNOCpyKioanX7y+5mIEPdGInJJDgCvHETadZogUZ33BD21qcryVm9gOb7KckVnGs4GWlq28QL6 +eCHECpdIWMfKXV6244D3E3OxHXk61tXYjoR0pJyQP3d0QZQfD8aWRq5wHQXFNf X-Google-Smtp-Source: AGHT+IGt9+hFPNfKD0vYj/l0vMmTZmm4MtaV//fw/vdTlSexZfNqLe9/5huEQLBsPI/BCg5Yf4wjuw== X-Received: by 2002:a05:6000:400c:b0:385:f23a:2fe1 with SMTP id ffacd0b85a97d-38a221f92c9mr32375904f8f.26.1735551231816; Mon, 30 Dec 2024 01:33:51 -0800 (PST) Received: from [192.168.0.14] ([188.26.61.92]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c847dabsm29231573f8f.59.2024.12.30.01.33.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Dec 2024 01:33:51 -0800 (PST) Message-ID: Date: Mon, 30 Dec 2024 09:33:49 +0000 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/4] arm64: dts: exynos: gs101: add AP to APM mailbox node To: Krzysztof Kozlowski , Peter Griffin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Alim Akhtar , Catalin Marinas , Will Deacon , Jassi Brar Cc: linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, andre.draszik@linaro.org, kernel-team@android.com, willmcvicker@google.com, daniel.lezcano@linaro.org, vincent.guittot@linaro.org, ulf.hansson@linaro.org, arnd@arndb.de References: <20241220-gs101-acpm-dt-v3-0-642d64daa5d1@linaro.org> <20241220-gs101-acpm-dt-v3-2-642d64daa5d1@linaro.org> Content-Language: en-US From: Tudor Ambarus In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 12/22/24 11:47 AM, Krzysztof Kozlowski wrote: > On 20/12/2024 15:45, Tudor Ambarus wrote: >> GS101 has 14 mailbox controllers. Add the AP to APM mailbox node. >> >> Mailbox controllers have a shared register that can be used for passing >> the mailbox messages. The AP to APM mailbox controller is used just as a >> doorbell mechanism. It raises interrupt to the firmware after the mailbox >> message has been written to SRAM where the TX/RX rings are defined. >> >> Signed-off-by: Tudor Ambarus >> --- >> arch/arm64/boot/dts/exynos/google/gs101.dtsi | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi >> index 1441e9a252c2..6947dd081a0e 100644 >> --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi >> +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi >> @@ -1445,6 +1445,15 @@ wakeup-interrupt-controller { >> }; >> }; >> >> + ap2apm_mailbox: mailbox@17610000 { >> + compatible = "google,gs101-mbox"; > > > I don't think I have this in my tree and cover letter does not explain > where I can find bindings. Nothing in next from few days ago. Always > document in DTS patchset where are the bindings, unless it's obvious. > Noted, will add such details. For the reference the bindings are part of these patch sets: https://lore.kernel.org/linux-arm-kernel/20241220-acpm-v4-upstream-mbox-v6-0-a6942806e52a@linaro.org/ https://lore.kernel.org/linux-arm-kernel/20241220-gs101-acpm-v5-0-4f26b7fb3f5f@linaro.org/ I'll ping you once we all have an agreement on the bindings. I'm still waiting for Jassi to let me know if he's fine with dropping the channel type argument for the ACPM use case or not. ACPM always uses the mailbox channel in DOORBELL mode, but this info can't be retrieved from SRAM at runtime. Jassi suggested that I shall pass the channel type via DT. While I don't mind, I don't find this necessary. Discussion at: https://lore.kernel.org/linux-arm-kernel/eaab647a-f6f4-4562-89fa-e64daa80bdf4@linaro.org/ Thanks! ta