mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
To: Sean Nyekjaer <sean@geanix.com>
Cc: linux-can@vger.kernel.org, linux-kernel@vger.kernel.org,
	Chandrasekar Ramakrishnan <rcsekar@samsung.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	Fengguang Wu <fengguang.wu@intel.com>,
	Varka Bhadram <varkabhadram@gmail.com>,
	Dong Aisheng <b29396@freescale.com>
Subject: Re: [PATCH] can: m_can: apply rate-limiting to lost msg in rx
Date: Sat, 21 Jun 2025 11:13:33 +0900	[thread overview]
Message-ID: <d855c26a-1982-4fc6-9333-93df4a5a98d9@wanadoo.fr> (raw)
In-Reply-To: <20250620-mcan_ratelimit-v1-1-e747ee30f71f@geanix.com>

On 20/06/2025 at 19:00, Sean Nyekjaer wrote:
> Wrap the "msg lost in rxf0" error in m_can_handle_lost_msg() with
> a call to net_ratelimit() to prevent flooding the kernel log
> with repeated error messages.

Note that another solution is to simply remove the error message. The users can
use the CAN error frames or the netstasts instead to see if lost messages occurred.

That said, I am OK with your proposed patch. See above comment as a simple FYI.

> Fixes: e0d1f4816f2a ("can: m_can: add Bosch M_CAN controller support")
> Signed-off-by: Sean Nyekjaer <sean@geanix.com>

Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>


Yours sincerely,
Vincent Mailhol


  reply	other threads:[~2025-06-21  2:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-20 10:00 Sean Nyekjaer
2025-06-21  2:13 ` Vincent Mailhol [this message]
2025-06-26 13:45   ` Sean Nyekjaer
2025-06-26 13:57     ` Marc Kleine-Budde
2025-06-26 14:46       ` Vincent Mailhol

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d855c26a-1982-4fc6-9333-93df4a5a98d9@wanadoo.fr \
    --to=mailhol.vincent@wanadoo.fr \
    --cc=b29396@freescale.com \
    --cc=fengguang.wu@intel.com \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=rcsekar@samsung.com \
    --cc=sean@geanix.com \
    --cc=varkabhadram@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®