From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755282AbdERUaW (ORCPT ); Thu, 18 May 2017 16:30:22 -0400 Received: from mout.web.de ([212.227.15.3]:52395 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752483AbdERUaU (ORCPT ); Thu, 18 May 2017 16:30:20 -0400 To: linux-pm@vger.kernel.org, linux-omap@vger.kernel.org, Eduardo Valentin , Keerthy , Zhang Rui Cc: LKML , kernel-janitors@vger.kernel.org, Wolfram Sang From: SF Markus Elfring Subject: [PATCH] ti-thermal-common: Delete an error message for a failed memory allocation in ti_thermal_build_data() Message-ID: Date: Thu, 18 May 2017 22:30:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:VqiumWC/ewWofEC6Oeetpxr2PQjVaSXxz+A0FoNrGesXCpkE2iB 5DONfJlrKa2W+S+dO++P7DlXUIN0NL37W1IYYrIIpwh6iOrg1zMb8cg7p3eFRdz1t26BwqX 7G+J+GyIhigEevlJRYlXaccip5Vl6e8cu1IbWr1G7/gOqKoM0HndAQYfz0YAuFK325hKaam cYDe4KiNwyihTEgMD8LsA== X-UI-Out-Filterresults: notjunk:1;V01:K0:YHRea0EneO4=:UZZ1BMFU+MCwQ46ODDNw80 xuMfmuSmVzTxT8cxh8pMLZljqkFlIFVn2WUrMBIT2qXsFQLrOzNJbLZdcsyQTPvGBofMMReox UxVBA/tchSj/gfpUJmCmRdVQrf1eXfJvvAW1kbGZdLEf5ADBFes7kWoiYwqclbvdLjHYufzfr MzpSadw2HxY5qc50WR9bou8J8Cq9aTHVKmS92QrNN2fMuZZRYDI+p970CME2PNsDIMUZVwuIW G+DBtI/R4d1VTsoeoMQxmBvJ32MEIMGL3FFGAsxuUdQRHikI8GEbVHf7Pd2LtfM3uCgh27xXB WVeABVa18dRRN+X6fcshXhlXLLoexvJ5XU0jKntvCWuysjkX6rcDiXDpxYilS4SACo9Cs2vZF vcD740c9UxHQ5Vh9Qkq9S8B67FaaFqp78vYGdjlnuIfJa5svEWmcFHriqWAGzquoyWT3zIXOZ i+VJBHpEeARsuXj0XlnVP5QHPcHxGlLhknpPt1CQvBFJfY2nGt+Ugx2YMHmgWHvBX6ZHFE2IY BK8Ixu73OHAGkct9TlN/FgIekIa/Fset19zh6qdpR5YDw+SgO9u+0gameWCftRXuCoFhT+O+g CoZ2BBHOZ44f4Mi9qLpPItKcqlFnjXjWfMiB00xQHHyC23/Gn2f1BtY3hJAeBnPs15KKHvryo TZGJJC5VhxaBlF80iOnVjHCcqHibQz9chCnsUtNhqWeY/LTqQlLQXQ4Y1UaOj2jjjkTrFr1A3 kPb6mSp0px0qrWR/lk5y4GPHHGu+LNaRIpbwk3BIjCb/AA2AX8OwUjaY/gw0miV8b70pAsUiA Ih0buac Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 18 May 2017 22:20:12 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/thermal/ti-soc-thermal/ti-thermal-common.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c index 02790f69e26c..5d29aa35cc34 100644 --- a/drivers/thermal/ti-soc-thermal/ti-thermal-common.c +++ b/drivers/thermal/ti-soc-thermal/ti-thermal-common.c @@ -160,10 +160,9 @@ static struct ti_thermal_data struct ti_thermal_data *data; data = devm_kzalloc(bgp->dev, sizeof(*data), GFP_KERNEL); - if (!data) { - dev_err(bgp->dev, "kzalloc fail\n"); + if (!data) return NULL; - } + data->sensor_id = id; data->bgp = bgp; data->mode = THERMAL_DEVICE_ENABLED; -- 2.13.0