From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-g123.zoho.com (sender4-pp-g123.zoho.com [136.143.188.123]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD62923B61E for ; Mon, 26 Jan 2026 18:30:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=136.143.188.123 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769452245; cv=pass; b=VmiWhIXY49tDA98SuQNZy1UfoN3UjmhLX+zHWoFvDQZjRxM6HntQn9a4gWbZLzrUeOWy1KQgZXo3vqhoQh4T5BVU/gv8Z+reAdQsYtUfAsEwTv0zJHj9Lgiv9haOnuIwBGnzr5/K4w99Qr4PFWLBZFxAigEMsnCKeJ2e0doxrt0= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769452245; c=relaxed/simple; bh=A3dWypEtdZY5Ui1xlIKclaDPq5Y8pFYrbzbWYy+I68g=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=qO6uTMOQRPpPAQsMVDFTdm8pKMvhrYc0GcXc9VWRuWk7n6tPPyjS3on5bdN75TrMIqN6MzMvuuEqVGXH8yg6h+5sq3UEFKpHtKxAAhR3HMHmSyuzYu5aByFzM9kx4BdtonPfJIdEhXS32umY+D+aNlQK8exariNMS5PY8wpga+o= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (1024-bit key) header.d=collabora.com header.i=nfraprado@collabora.com header.b=AcaowKzp; arc=pass smtp.client-ip=136.143.188.123 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=collabora.com header.i=nfraprado@collabora.com header.b="AcaowKzp" ARC-Seal: i=1; a=rsa-sha256; t=1769452215; cv=none; d=zohomail.com; s=zohoarc; b=nTShMgbUt3DXdgrTr8iXm4Y4DAOwXbPQU9MUY2TK0SxsMMgXv3PdAbEPwsbQUapdCyaXm4N4+HLA+ZlYOzC0m2k2tedIIeK7lwLTM0QFXB0OKm0Vgoj1JIyU4m0nMgxF1FAH+3/VicisnpIxq0Q1cwXg/XplCYn6iWCxZ07v28I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1769452215; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To; bh=hVd6diwc3mTM+TJy/I3dVmE0Ngl9ll/ws0dV8fch0dw=; b=lcTAcL1SKd8QSh1VmvxeHjesbMxCMrLMnNxOfHdmbXzx1HET4G9agqSleiWQVeX9V8BFNt4t45qvf9GKrkyuIApz9Uu6S6151GXZ6CrtUNfQ3tWJAvIh+QiMkWOvbKBQQvshFaiTGn44rra7RJQiOREcsAyP7CYBBMokqkO+DCk= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=nfraprado@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1769452215; s=zohomail; d=collabora.com; i=nfraprado@collabora.com; h=Message-ID:Subject:Subject:From:From:To:To:Cc:Cc:Date:Date:In-Reply-To:References:Content-Type:Content-Transfer-Encoding:MIME-Version:Message-Id:Reply-To; bh=hVd6diwc3mTM+TJy/I3dVmE0Ngl9ll/ws0dV8fch0dw=; b=AcaowKzpQTCzeaB33CnHLyfNtNEUQwRSJaQc72i/QVBSZhd4ZuO11PF1wE3OY3EC LfAEjmuT+Pk43Ht3wyJKPX6B72EWLGqjUeaj8SoOxT+JUfDpnEus+IUIC0Vc335TQ5C Nwb8YuSs/OLWlMHMaIkQSXEyoD6kytPui3Gm0A08= Received: by mx.zohomail.com with SMTPS id 1769452213766652.6163551638421; Mon, 26 Jan 2026 10:30:13 -0800 (PST) Message-ID: Subject: Re: [PATCH v4 4/4] drm/rockchip: vop2: Support setting custom background color From: =?ISO-8859-1?Q?N=EDcolas?= "F. R. A. Prado" To: Cristian Ciocaltea , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sandy Huang , Heiko =?ISO-8859-1?Q?St=FCbner?= , Andy Yan , Louis Chauvet , Haneen Mohammed , Melissa Wen Cc: Robert Mader , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Date: Mon, 26 Jan 2026 15:30:07 -0300 In-Reply-To: <20251219-rk3588-bgcolor-v4-4-2ff1127ea757@collabora.com> References: <20251219-rk3588-bgcolor-v4-0-2ff1127ea757@collabora.com> <20251219-rk3588-bgcolor-v4-4-2ff1127ea757@collabora.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-8 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ZohoMailClient: External On Fri, 2025-12-19 at 23:47 +0200, Cristian Ciocaltea wrote: > The Rockchip VOP2 display controller allows configuring the > background > color of each video output port. >=20 > Since a previous patch introduced the BACKGROUND_COLOR CRTC property, > which defaults to solid black, make use of it when programming the > hardware. >=20 > Note the maximum precision allowed by the display controller is > 10bpc, > while the alpha component is not supported, hence ignored. >=20 > Signed-off-by: Cristian Ciocaltea > --- > =C2=A0drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 13 ++++++++++++- > =C2=A0drivers/gpu/drm/rockchip/rockchip_drm_vop2.h |=C2=A0 4 ++++ > =C2=A02 files changed, 16 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > index 498df0ce4680..3a232d0d4acb 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > @@ -1554,6 +1554,7 @@ static void vop2_post_config(struct drm_crtc > *crtc) > =C2=A0 struct vop2_video_port *vp =3D to_vop2_video_port(crtc); > =C2=A0 struct vop2 *vop2 =3D vp->vop2; > =C2=A0 struct drm_display_mode *mode =3D &crtc->state->adjusted_mode; > + u64 bgcolor =3D crtc->state->background_color; > =C2=A0 u16 vtotal =3D mode->crtc_vtotal; > =C2=A0 u16 hdisplay =3D mode->crtc_hdisplay; > =C2=A0 u16 hact_st =3D mode->crtc_htotal - mode->crtc_hsync_start; > @@ -1599,7 +1600,11 @@ static void vop2_post_config(struct drm_crtc > *crtc) > =C2=A0 vop2_vp_write(vp, RK3568_VP_POST_DSP_VACT_INFO_F1, > val); > =C2=A0 } > =C2=A0 > - vop2_vp_write(vp, RK3568_VP_DSP_BG, 0); > + /* Background color is programmed with 10 bits of precision > */ > + val =3D FIELD_PREP(RK3568_VP_DSP_BG__DSP_BG_RED, > DRM_ARGB64_GETR(bgcolor) >> 6); > + val |=3D FIELD_PREP(RK3568_VP_DSP_BG__DSP_BG_GREEN, > DRM_ARGB64_GETG(bgcolor) >> 6); > + val |=3D FIELD_PREP(RK3568_VP_DSP_BG__DSP_BG_BLUE, > DRM_ARGB64_GETB(bgcolor) >> 6); Why aren't the DRM_ARGB64_GET*_BPC() helpers used here to get the values with a custom precision? --=20 Thanks, N=C3=ADcolas