From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [185.203.201.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2794C2D322E for ; Mon, 16 Mar 2026 14:39:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.203.201.7 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773671995; cv=none; b=dgvqJN0AVrPXvOc3+6rf0/Dg8aRbBsZGKo8u6vDvC5tYdccP+hYOg9bu9Qe2juLC1ehajrrNEVenWCtChQGxca1rITkmslv9MROWuvEMSphtwqWM3VJ33zSADaz73eqThzaO2kp4o6R92Cpc6BndSAiL5wXrZZaqi44KJVRkaw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773671995; c=relaxed/simple; bh=9Vaohowfy+7TritBVVV0aE7oAvA1NqzXqL34mLxXG4s=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=E4jrTrYTL/RPe4eFoGsh8PH1/HwNpg8SDjzVt9DtqGpCUBn4xZBIa4t6+ly4+JpSILWeMTmvPxu6+FtEtIAbsBFCYDh5eWyuowZcvxnvecAnUsdC8rUNDflBfSRt77kh7i4sxQQ84J26S22K8YL5a+X5rhtKp2wwRSY5rQEPH+s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de; spf=pass smtp.mailfrom=pengutronix.de; arc=none smtp.client-ip=185.203.201.7 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=pengutronix.de Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1w296d-0007Sm-Tv; Mon, 16 Mar 2026 15:39:43 +0100 Received: from lupine.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::4e] helo=lupine) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1w296d-000aWK-0o; Mon, 16 Mar 2026 15:39:43 +0100 Received: from pza by lupine with local (Exim 4.98.2) (envelope-from ) id 1w296d-00000000pc4-0huX; Mon, 16 Mar 2026 15:39:43 +0100 Message-ID: Subject: Re: [PATCH] i3c: master: dw-i3c: Assert reset control in remove() callback From: Philipp Zabel To: Felix Gu , Alexandre Belloni , Frank Li , Aniket Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Date: Mon, 16 Mar 2026 15:39:43 +0100 In-Reply-To: <20260316-dw-i3c-v1-1-ab41904fc780@gmail.com> References: <20260316-dw-i3c-v1-1-ab41904fc780@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2-0+deb13u1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org On Mo, 2026-03-16 at 21:55 +0800, Felix Gu wrote: > The reset line acquired during probe is currently left unasserted > when the driver is unbound. Add the missing reset_control_assert() > call to properly reset the hardware when the driver is unbound. >=20 > Fixes: 62fe9d06f570 ("i3c: dw: Add power management support") > Signed-off-by: Felix Gu > --- > drivers/i3c/master/dw-i3c-master.c | 2 ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/drivers/i3c/master/dw-i3c-master.c b/drivers/i3c/master/dw-i= 3c-master.c > index d87bde3f7700..5303282eb816 100644 > --- a/drivers/i3c/master/dw-i3c-master.c > +++ b/drivers/i3c/master/dw-i3c-master.c > @@ -1690,6 +1690,8 @@ void dw_i3c_common_remove(struct dw_i3c_master *mas= ter) > pm_runtime_disable(master->dev); > pm_runtime_set_suspended(master->dev); > pm_runtime_dont_use_autosuspend(master->dev); > + > + reset_control_assert(master->core_rst); Switching to devm_reset_control_get_optional_exclusive_deasserted() and removing the reset_control_deassert() in dw_i3c_common_probe() would have the same effect. regards Philipp