From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f51.google.com (mail-wr1-f51.google.com [209.85.221.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 231E32F8EBB for ; Tue, 19 May 2026 12:11:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779192718; cv=none; b=YZ+1jQh4SMvZy+D/9UZhw9eTw07OZ6OE2RaJ9gtv7Vdrq8a7TSeY8xXnCIpYLgPOPqYy3IOeRmqEm5eIrM8tKLS6cWahDvf5mUfT9NqYTbssRwjAEvGjQtwTAIxmf4LIU38we+8BxSys2W5QA4mesuJ2UC0GK3fTA34N3PMDYmE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779192718; c=relaxed/simple; bh=IYaQaJj5MVcvrd+hSHbZutQNIAVNVlA6s1NlpyumyNE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=kgFV7o94roEkv/BbtUNgWmECNn0FqzMfi+c1flF4F6nb5tv+pfWYHCefeN2EuAKhK8csicfHryFzMIvEe36rKniVnyfXvhKK4snAv79uHavCjKiJoeySYT6yrZm5U8okq1RIo8T1DFZTcJWqov3Quxco6+mK6nOEsrI0FvIkHAo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fRZjJq4t; arc=none smtp.client-ip=209.85.221.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fRZjJq4t" Received: by mail-wr1-f51.google.com with SMTP id ffacd0b85a97d-45e5f81074aso218135f8f.1 for ; Tue, 19 May 2026 05:11:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779192715; x=1779797515; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ww4CKOsmbnsFPVH2QTfL4TQf7KmUuJr3ZNu7Wd6tZ5Q=; b=fRZjJq4ttyYIGVGyskHuLjAE1hsUdBlf90mnpquzsTzMLlU/BbucUhUEvyorqfFccK h1lcmEBz/RmewteGB5Gd9f2LBcf/hKKpFcH/vD2z/WOkvAUZJ2zBZAo6tDiTDSsWXUFx 6GNXIGV8I3LnQujh5qfWIH8dfKh73oIkQSzgVs4efaDYDqlr718V3OzviP7QL5k9xkWU X/HJRsoxhCKVNcClUtmBun+yBLrOUgrskIrQmLpu4iSplYi0l5vGTVmPd4vmbMTjdiMd bZTfan5gt/klXXhzGXQ5sW+8JsO7Jfm2DpMUeQ7guU6qZFNEFmSlAfdT0p7T6fJ2/PAr b3+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779192715; x=1779797515; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ww4CKOsmbnsFPVH2QTfL4TQf7KmUuJr3ZNu7Wd6tZ5Q=; b=IkyL6dbz7qn918qThi3mfIZZQ3c03Aa8FjsYnlvpRjOnBqE/OsMtaVmggVaNN8sFWV CkMTTaFyCNDzsvmLnueFoxn28AbIMI+IsvG9q4DVyi6Bl+2xN2iD4mD4qJhWgZvtDAwI AmB0zM62xGpNK5eYZoht7XlEvFF4yrS/T1uCHboLh30HDxv/K+RET/RgaYt2o8NxM/hI IRe/BXfG9P2IGHNdxXDnWH+fktasaOOuTl2A36/dIHKHz2M9yzIWYrRBrPpKm5N6Lbha SNUy0UkyDU6R1XmUBLHU4kF3TkT0ZEH249GbPyUJhT8ZJz0mLCZ4BnMPoWa/0IifbZUE SQXQ== X-Forwarded-Encrypted: i=1; AFNElJ98APrqakpS6eBW9Ad7YgvgEADmLQo8Ft9I4pJLfxEo3MVTrK/nNxqBmUBE1sqpUyeXHP57Yc9T8z7eggI=@vger.kernel.org X-Gm-Message-State: AOJu0Yy4Rhw9P6sZquq0XN7jcuagj0fLQzAmM5wMAb1iOZ33B1X0jrlM 49jiAAAASm2FktyDPzRrs+OrdjHbDOGXW2Xf8afKENkCOQbey9J1vIqa X-Gm-Gg: Acq92OEB5uErNvg6ND7AYFZk4T+5RL7+9HlrZkNJ3l/L6UYRJNGjQqgRcHb5gMNbmR+ h6lE5aJBAu9BQkQQ8jhsd70JhIpsVF/6VnvYad2NRyk4mTsKEdSHHl7xNJBs3PTkzkGVg7F8wuS Y3l86PAyWcwiaBhjvsEnGL+I+Iqwlzdm6d/OLWhuB6fVRrOHdywPt9nvLBTs8+ckWsIYBHnYw0l eW5S98ji8kxqU3d8mBpx3XW7wTM5Oou8NvDyclcF6NQEryaLITTbAirtqXb/EUsptGX8wm7Hszx Qv21FHfmjvXc2T/edcg9r9V8hXfkJa/r1Io7rHfOU7ajuf7H7UdknAHrWgQVaWcmy4FHfPmMH8e hXJkUqNDs+ZU+nyB/hL3tyNjBIJRrUW5ulDVAkIuo43yCXGvRCYgK0TbcK+2jK49kqlYaqB/9Qo GXbI24DtmigEMsH7ahzEyCttF4soKQQsRHDfJ45DX1GetELS5cSveFv5XbZ58emErK+lMphdOc2 wt6DN1zb9VfAFQPw6rd X-Received: by 2002:a05:600c:4588:b0:489:1c1f:35e5 with SMTP id 5b1f17b1804b1-48fe664be2amr136275035e9.6.1779192715261; Tue, 19 May 2026 05:11:55 -0700 (PDT) Received: from ?IPV6:2a02:aa16:1105:8100:aca5:18d3:d87:7987? ([2a02:aa16:1105:8100:aca5:18d3:d87:7987]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48feab2896bsm109146625e9.4.2026.05.19.05.11.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 19 May 2026 05:11:54 -0700 (PDT) Message-ID: Date: Tue, 19 May 2026 14:11:53 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] net: dev_addr_lists: don't WARN on GFP_ATOMIC kmalloc failure in netif_rx_mode_run To: Jakub Sitnicki Cc: Stanislav Fomichev , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Qingfang Deng , netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260519095557.3749407-1-yzjaurora@gmail.com> <878q9fod8m.fsf@cloudflare.com> Content-Language: en-US From: Zijing yin In-Reply-To: <878q9fod8m.fsf@cloudflare.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Thank you so much for the feedback! I will address these comments in the next version. This is not found by syzbot by the way. Hope you have a great day! On 19.05.2026 13:22, Jakub Sitnicki wrote: > On Tue, May 19, 2026 at 02:55 AM -07, Zijing Yin wrote: >> netif_rx_mode_run() fires netdev_WARN() when netif_addr_lists_snapshot() >> returns non-zero. The only path to a non-zero return is -ENOMEM from >> __hw_addr_create() failing its kmalloc(GFP_ATOMIC) -- syzkaller hits it >> via failslab, and it can also be reached under real memory pressure. >> >> This is the only allocator-failure site in this file that WARNs. >> __hw_addr_create() itself, and every other caller of it in this file >> (__hw_addr_add_ex(), dev_uc_add_excl(), dev_uc_add(), dev_mc_add(), ...) >> just propagate the -ENOMEM silently. GFP_ATOMIC is a may-fail allocator; >> callers are required to handle NULL, so a returned -ENOMEM here is an >> expected runtime condition, not an invariant violation. >> >> The miss is self-healing: any subsequent change to dev->uc / dev->mc >> (every dev_{uc,mc}_{add,del}, IFF_PROMISC flip, etc.) calls >> __dev_set_rx_mode() -> netif_rx_mode_queue(), which re-queues the device >> and retries the sync. The only cost of a failed attempt is one stale >> rx-mode window until the next update; nothing in the kernel relies on >> this attempt succeeding. >> >> Demote to net_err_ratelimited() so the condition stays observable in >> dmesg without tripping panic_on_warn. >> >> Reproducer (syzkaller .prog format with setup notes): >> https://pastebin.com/t7AQKx9v >> >> Fixes: 3554b4345d85 ("net: introduce ndo_set_rx_mode_async and netdev_rx_mode_work") >> Signed-off-by: Zijing Yin >> --- >> net/core/dev_addr_lists.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/net/core/dev_addr_lists.c b/net/core/dev_addr_lists.c >> index d73fcb0c6..c6fdcac74 100644 >> --- a/net/core/dev_addr_lists.c >> +++ b/net/core/dev_addr_lists.c >> @@ -1275,7 +1275,8 @@ static void netif_rx_mode_run(struct net_device *dev) >> err = netif_addr_lists_snapshot(dev, &uc_snap, &mc_snap, >> &uc_ref, &mc_ref); >> if (err) { >> - netdev_WARN(dev, "failed to sync uc/mc addresses\n"); >> + net_err_ratelimited("%s: failed to sync uc/mc addresses\n", >> + netdev_name(dev)); >> netif_addr_unlock_bh(dev); >> return; >> } > > 1) I'd go with net_warn_ratelimited() instead. The promoted message > level in syslog might cause operational pain, and as you say the > condition is self-healing. Seems unwarranted. > > 2) Since it has a Fixes tag, should probably be sumitted for 'net' tree. > > 3) Was this reported by syzbot? If so, there should also be Reported-by > and Closes tags.