From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E234F309EFC for ; Mon, 29 Jun 2026 05:03:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782709415; cv=none; b=uWpyJw1lkvPLHmaoplGn4m0i2ZMhg0xdMpIT2aEWvtuMqU1m2tOlxYWKD4rdSP9wMGSaybUDPB43zKiwwmmCD4bJdWkOyqME3UpXPyryPxtEtNlN34Z4I5wBZoEI5ITRmm4TnxlhQ49zJsqKXWtq6CuBFMrU2qKw8j0sHRQI/jg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782709415; c=relaxed/simple; bh=8GGjHz2/I206+Fi11Ux2KHZMbQvRYWzNU1Gr6HP8wZA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LJF8Kp6GcP0BAroMEK1obhDanZGZeW+jiU+r8apJGlI4U4c/QLX6ibO8rth+1JSeFPlZ8VhOWzXTycHWQfWZf+MEPNewOKDj3BTub+u3qd19R7ApOvosqe1qJDSuUdvGfWs3hkNxheYhbukPKbUALN40fjik5iT3GRJPn2UV9cE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GYYZqT6G; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=c9N+vD+T; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GYYZqT6G"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="c9N+vD+T" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65T4NOb01766944 for ; Mon, 29 Jun 2026 05:03:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= W88vWECRU+wrMD9oJnjg+rbsRkfPT9MutHVGHqUs57c=; b=GYYZqT6GAgh/iKVv PHMl8k/9bppTUz6ZLT6n/6BHY/t3yDVI2Dyj9X7MaQhyrmg+erO2XqmL7MBB0cnM 9nh9bi593YU754NyB0hntP+68pgjUmJoWjHhiYpB9PhirnFKeviSaq7nWsINfV9m sbH2xAv18wohXAE9tgJpMcuyBMgd/F+eXA04IK/yVZ9qsY0q1u+oc0m7wm05KaAF BKzMIX+J4sJDhzE9avTvsqxKznBC5dIPB8Cns4QLLF5VkWGw6h9RkiHe0h0ynYL0 met+NUZQP2kHRKez4dxMAG61fBQJ5CrDfcZaLhp3dCOKuXh5kDbm2Gw1NY3LKa6k b1VXdg== Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f270a4jva-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Jun 2026 05:03:33 +0000 (GMT) Received: by mail-pf1-f197.google.com with SMTP id d2e1a72fcca58-84777e9b51bso971331b3a.2 for ; Sun, 28 Jun 2026 22:03:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782709412; x=1783314212; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=W88vWECRU+wrMD9oJnjg+rbsRkfPT9MutHVGHqUs57c=; b=c9N+vD+TDAsuf0diE4Nw9f6UsnlHWcih+jGBdx/oF2mkaBDkrsAGpNC/guCjxgafi6 V52RkJjwkVB9uBB3BofcYaQu7Kf8tpmLRMXtPQeKmECa/abIob46qkriFSzNlJ8EFBkj zYsHjlHCskDMO3e4oJnSKrzOgvhrpe8GWk4UjqHNLz8pZwNHy5I7ohFKcS1LFAmJQqQR MRACTsa0bwRw8MYfDrtz6IFwQrN0917KIGh547YFxiF6v9V2xeI/rkXPtm2Nypax2aw2 hutijEZGONpOoOp9xIF5qqQR5rbKuncwrS+67jffPgKmgaSHEsMiwmsC3hF5DClyUAY2 QHjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782709412; x=1783314212; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=W88vWECRU+wrMD9oJnjg+rbsRkfPT9MutHVGHqUs57c=; b=q0pPNJXDXN3c0RwtZMHcImJDdhglaRkTkHxHFKbBwUXC3QheWdrD9V/oJt3DELOJ2n +Lkolqxftb8Vue93OGvWK+NoiWx1r4WUVH0B6RRVyE2R0dlo53Rkz2BnrQoAy/ki7TaR c00P5fc/UbxbVGQmS3xON2rOJg45yLPU3tJqgXohrKRJSgwG45owIynjnoobuZp14OvP b23L7kke0GdJPcNRJ/mCDzvWHdi3YOaWl7XBsWnzZ1pJBPKrztofoasgXUUMp/ZRiwax wFtNZqZArq46yAYQoJ3W37r8pgsG6yhBSxZMHAOomrwJUvbUtiy58hU+2CtoOEqNOwAy TmSw== X-Forwarded-Encrypted: i=1; AHgh+RonuzNiOppEyZbnqNaUIEA/MxxPX0XS6XZFJkvHf5KInOz/P6vbZEziT5d8WZyVyTaQLWkW3COAFJWvxY8=@vger.kernel.org X-Gm-Message-State: AOJu0YxkBsOkgy9JUl1t+fJVBA7TdVJkBXRUnz3b2264m4mpPY7f26Dq pk1DjgvRYXs8Ypsqh2g7WtNR1VC0aZuXMbQ5VUnhnZoy5R9brVoqwY70B4utbFpT+W9TpAOLgFi bNrhstUBNwiH2HfwBKAZqDb0SVzJIOfNqkxhfegnnaBvBMJqHA/ep4ebQ7zUF6PT0yco= X-Gm-Gg: AfdE7cnIMYXUS8hr2dmo0j2ZYUcCTFLs8YPfKD8sTeby1ffA0ilaB3SRUehznCA2PrI c8KposGsvTo0AVYuz2WeXwmT5K/5Gb1R0l2OkXv60Eo2kA8ignYzzESrj3v1wFjc1VQ2flGezUY FUpUmNEBrBlUz/JlMPiUx2iGMrxrj/YemHciBsX4/R9PzOfmeLciTiX0sYMJbRgDAc1BW2/xHhM z0U2e8fEJ/MvARw5PoUWmpDkQFPwHR95+2YwGa2VSidaRle+Jw8Qv2Z6WYm1hZ1Q9Pc1fki6nhy pnMfeSt/U5BggP7A1C5MArC4vt2gxVDxtaWnYJiElDDcWixiNhDCMlt2981LnkJ6/GCVi3nUGYB ylr3VMY3MeRp2Abiftz8zH44U2mbsjYuBf/Aag325bD+krBPuAw== X-Received: by 2002:a05:6a00:450d:b0:847:1b77:6eb9 with SMTP id d2e1a72fcca58-8471c5c5170mr2872781b3a.9.1782709412456; Sun, 28 Jun 2026 22:03:32 -0700 (PDT) X-Received: by 2002:a05:6a00:450d:b0:847:1b77:6eb9 with SMTP id d2e1a72fcca58-8471c5c5170mr2872754b3a.9.1782709412036; Sun, 28 Jun 2026 22:03:32 -0700 (PDT) Received: from [10.218.21.154] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-845a40d23ccsm11615264b3a.36.2026.06.28.22.03.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 28 Jun 2026 22:03:31 -0700 (PDT) Message-ID: Date: Mon, 29 Jun 2026 10:33:26 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 3/3] ASoC: qcom: lpass-va-macro: Add shikra compatible To: Konrad Dybcio , Srinivas Kandagatla , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jaroslav Kysela , Takashi Iwai Cc: linux-arm-msm@vger.kernel.org, linux-sound@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260608172023.2965292-1-mohammad.rafi.shaik@oss.qualcomm.com> <20260608172023.2965292-4-mohammad.rafi.shaik@oss.qualcomm.com> <3a0890b2-f9c3-439b-a392-fd13e3da850d@oss.qualcomm.com> Content-Language: en-US From: Mohammad Rafi Shaik In-Reply-To: <3a0890b2-f9c3-439b-a392-fd13e3da850d@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI5MDA0MSBTYWx0ZWRfX4iBbgU7coO/v HgFW2vIc+D9/kues6E8pRvclq+0paNwMPnsmOqERJTrBrin1wp+wrHOeRVRtc3m2kVDe1thoz+P jA4ns8PMV/Dk2jSxQahZXS4U++AiKEyZKQ+gKV6beZiIcK5nlP9hsESEa3WJrtxJGVNotY+Deto myT6Ty+HdPEjiT8j5OZNxs/38W6exKR4L/hrPYoOPdGkfO4CFVBDD6uPEfWoCOW1QXZEuyhSj63 1CuTOd6s/mYbYY8sF+5g5IgYFEedzLW4ixafNH6TG4LmeSBkSbGfQm32oxML/5gN/D5+MUwVsJm VgJVTG8Yv/cJ+0Wrh7B39YP/R2l8lua+5SlSXH8VFOo6EJtTpqejVpcZTZYapStPgIaB1l7yHIY bLslWPmoOEpRviRHBqIAjAzCl2jkI1MmnGsUJ/DpPRKYo2hRL/u8FfVxag5r6s0KE+wNrOs0KoA 6kWhPPfZGPDjFeS4IAw== X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI5MDA0MSBTYWx0ZWRfX8MWqKXZEd+1+ 5To6tNLl64BPnSYlnzTRqgpCZjiBUly2ZWB9/AU8HuSaRTraoR9qtMNaJcJWcIypX2GCLsmZR0t r5tox8Fq1Vw/jhm04TZHYxTlrXT+hQU= X-Proofpoint-GUID: rMvXEgxUbEMpFK8pqSwZowAnxFgtEzAN X-Proofpoint-ORIG-GUID: rMvXEgxUbEMpFK8pqSwZowAnxFgtEzAN X-Authority-Analysis: v=2.4 cv=Fe4HAp+6 c=1 sm=1 tr=0 ts=6a41fca5 cx=c_pps a=rEQLjTOiSrHUhVqRoksmgQ==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yOCtJkima9RkubShWh1s:22 a=EUspDBNiAAAA:8 a=G8B2rSO7KOTdLhCsa_sA:9 a=QEXdDO2ut3YA:10 a=2VI0MkxyNR6bbpdq8BZq:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-29_01,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 bulkscore=0 clxscore=1015 priorityscore=1501 impostorscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606290041 On 6/9/2026 2:45 PM, Konrad Dybcio wrote: > On 6/8/26 7:20 PM, Mohammad Rafi Shaik wrote: >> Add shikra specific VA macro data and register programming needed by >> the LPASS codec v4.0 implementation. >> >> This adds a shikra regmap/default table covering the ADPT register >> range, wires new match data flags (bypass FS control and ADPT block >> presence), and enables the ADPT control programming path during TX >> decimator bring-up. >> >> Signed-off-by: Mohammad Rafi Shaik >> --- > > [...] > >> +/* ADPT control registers - Shikra adaptive filter blocks */ >> +#define CDC_VA_CDC_ADPT0_ADPT_CTRL (0x0800) >> +#define CDC_VA_CDC_ADPT0_ADPT_GAIN_0 (0x0804) >> +#define CDC_VA_CDC_ADPT0_ADPT_GAIN_1 (0x0808) >> +#define CDC_VA_CDC_ADPT0_DH_FSM_CTRL (0x080C) >> +#define CDC_VA_CDC_ADPT0_CUTOFF_FSM_CTRL_0 (0x0810) >> +#define CDC_VA_CDC_ADPT0_CUTOFF_FSM_CTRL_1 (0x0814) >> +#define CDC_VA_CDC_ADPT0_CUTOFF_FSM_CTRL_2 (0x0818) >> +#define CDC_VA_CDC_ADPT0_CUTOFF_FSM_CTRL_3 (0x081C) >> +#define CDC_VA_CDC_ADPT0_CUTOFF_FSM_CTRL_4 (0x0820) >> +#define CDC_VA_CDC_ADPT0_CUTOFF_FSM_CTRL_5 (0x0824) > > Please use lowercase hex and drop the parentheses > will fix it in the next revision. > [...] > >> +static const struct reg_default va_shikra_defaults[] = { >> + /* VA macro */ >> + { CDC_VA_CLK_RST_CTRL_MCLK_CONTROL, 0x00}, >> + { CDC_VA_CLK_RST_CTRL_FS_CNT_CONTROL, 0x00}, >> + { CDC_VA_CLK_RST_CTRL_SWR_CONTROL, 0x00}, > > lowercase hex likewise, please keep a consistent space before the closing > curly bracket > Ack, > [...] > >> + if (va->bypass_fs_control) >> + regmap_update_bits(regmap, CDC_VA_CLK_RST_CTRL_FS_CNT_CONTROL, >> + 0x80, 0x80); > > regmap_set_bits() > > [...] > >> case SND_SOC_DAPM_POST_PMU: >> + if (va->has_adpt_block) >> + snd_soc_component_update_bits(comp, adapt_ctrl, 0xFF, 0x00); > > Can you define these magic numbers? > sure, will define and use the same. > [...] > >> + va->regmap = devm_regmap_init_mmio(dev, base, >> + data->regmap_config ? data->regmap_config >> + : &va_regmap_config); > > data->regmap_config ?: &va_regmap_config > Will fix in the next revision, Thanks & regards, Rafi. > Konrad