From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F38C4386553 for ; Mon, 23 Mar 2026 10:01:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774260083; cv=none; b=uP1CERaDAyNrEvIErUZI5lq4LUU3YMOeucwchHZ8pdx+mqwCeA0Ekhne9EuG5EKm76vh+qO0dFCfY88EG9F3Yacg0iag/23ey9Y9RLsk4noWZYzm/adOB9IfK80sJaFY4FXu7Lf137A/OhmFgQ4Qlj8hukJMJtIO4OrEyIp30XI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774260083; c=relaxed/simple; bh=vViOxB6Cs1Vo4vecuWH5PX63l0iMGjGRSe4dXPzXc/E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OBTUb1/RTau2KrrwLN+56/SuJbC9PqzcfNUUfGnVuZnvwnnADjR9eFH+zec+OCPSG5CSVnntr5x+0bMfdhlfpksgdT+g0modviatlgOytNSSr9si6Oat0smt6thcH2H0EDFUH0oHqK/Yxr+KzQPOAnyLS3J4QoYCc9+NYVgdwFM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=F661NEi/; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=cRnji1XO; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="F661NEi/"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="cRnji1XO" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62N72GgN1674413 for ; Mon, 23 Mar 2026 10:01:21 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= mDKtBGhEAchSzR5OWggdmnwzuStLPCYVysdJXOF8xT0=; b=F661NEi/LOsBPWf+ OxGR/eqrodUaDt3erx8YjaeNl5TmgIX2/dTbUV5PdIORFJB9b27rWIY1unbGiCfG 8okgxIcAwLcUYnKpe+DRPTMoXfnPiHeZlf2JZMn93I4p37OG6H/ygpGzOQi3dBJg E06/BI3Qa22BDBTgvFeg+82Kw4BmIOLRPizDqAG319HmUSdhoCGfmBWM3wABPGP1 m4PSrviIi1PLqew05oa03/o+AcOoBG9P0Bd7K6myXbT7cVGjXR3QKYnWlrLu2vIQ /Wt/jC2x1cXq1/f7vtbfMwywMF9ClNIA6WA395zLQU7RPDAIiSwogijgYrNBl7zE NywOIQ== Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d1kduct56-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 23 Mar 2026 10:01:20 +0000 (GMT) Received: by mail-vk1-f198.google.com with SMTP id 71dfb90a1353d-56cd40ae396so268101e0c.0 for ; Mon, 23 Mar 2026 03:01:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1774260080; x=1774864880; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mDKtBGhEAchSzR5OWggdmnwzuStLPCYVysdJXOF8xT0=; b=cRnji1XO1ruW4JKqk4JK6m4a5lSFR1945MQzMQLZvlp166ajkKgzh0IMGhYIPE3cve y5qNU6sXp+3A6GE0Pe/fOcXs/dno7kX/orA9aWHlvJpxUuLpU7FHCjP/US+zQnWZkKVI f2Jf8hqHSI6Rys78rhyvvjC7X9F2UPXViOgxj/EiMSsDVtmgfrMhhcpODNbTuCEQnwGw GxKnVv0cq/kG7EKpmjudyc6kaGATQl2g7rcisXifey6LK5uGr9U9yZJrvYE+AHhQX+V4 tXS2L5nfxo0q0xZxwfC1LbNlGNx6u+e2Sqkjh7iJghTPtKKxE0RCVHAI2Ed8Q0mV6GCN jY9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774260080; x=1774864880; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mDKtBGhEAchSzR5OWggdmnwzuStLPCYVysdJXOF8xT0=; b=JzaL1e5b2e21YMIAl68uRxY9MQE734yKmfxSlBJV+My4mIhZZIiw8K0v9IrOmMIen5 ECDaJohfkX+04NZYljw5I8xUobnUgodeX3VFCOGsVgvnTl4ng8MJ/sNYKvacFU6xbcjp K8+OKZGipQ44ru46AkRyqz19uVZczRm1DuY3lmSvXf9GdfzVO6wTDU9C16x9s4HpqGR9 PNUu/kLS7mDQrrLYfWdcUvZ4yx/ssiRFeEHmgyDQc0y9PGSYrkRGlnc1vVXrgXcgdBJN 1yEc0YJYRv/HA2Ea1ibimf9gWH/c2BvRLZRhdNurRetyUHRdHw59EtxBDOIi2627NoV3 JnrQ== X-Forwarded-Encrypted: i=1; AJvYcCVyxnvNdbs1LY+i8cvSw4yVmWLhQn984X4P2m3Fib0ESA9IznQhn5Jfxkz4CphCfEnka9/arYCJA8GUe9g=@vger.kernel.org X-Gm-Message-State: AOJu0YzqdTemmtkOy9RbphoTXDW3vWB0rfyNmxVqIZ0hpj2LEvgS/c9a SmTGYSDz45oiPGbHuxF5e4L2JepX66ldjYlbIXgNJHNcIjKZSBpLZifYwbQmECd20oT9mOK6Lh/ UDzElhDYzQKiOFnQ1tA0M2T+Ujvz4OkOqHj9I+idDtnvaGZaZftB5RmvmF3pEj5rnpmg= X-Gm-Gg: ATEYQzyG5+Glvela2U0NnI3Q+FDO+0CjJ2FlAKIhY4PPKg1cAI1uapCi4Bh1aiNZbuo QwteKsVvszIYJNhghIFnxoLKpWic1pLZn39ourJt0QpNfKss4lHteU4UP/M6a7DPF9MwdL5fhxF faj5EBkp9gSjXNnzU5tTtfC65Tl3TMqbXFSTaAdtcfWL61fvYj+icxkj/5/xzb4BVEokT/21ZZM qf5CSjY/PGr1v0up4vVRV8BLUDENc2LMQ696ww0vfvxzfI2cjCuUMP5I2kdVOX8I0VCJVvxAEbe xw178TaHKnPE2HhbpO3nPkzZOMCxw5O5TO1lRcI+FTRU/hNYM9JaM8DWEoqON4ayiw15xbBUO4r Ejx2YCQD3ih6bqpxbRb0ncGZG80J+aDIOiHtluiEFnVSmlz4ZAVJWb7QmCBdbEnOZPL/THlQROs DtVvA= X-Received: by 2002:ac5:cd92:0:b0:56b:7252:f7e9 with SMTP id 71dfb90a1353d-56cde327a4emr2180258e0c.1.1774260079422; Mon, 23 Mar 2026 03:01:19 -0700 (PDT) X-Received: by 2002:ac5:cd92:0:b0:56b:7252:f7e9 with SMTP id 71dfb90a1353d-56cde327a4emr2180225e0c.1.1774260078861; Mon, 23 Mar 2026 03:01:18 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b983388070csm464744566b.60.2026.03.23.03.01.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Mar 2026 03:01:18 -0700 (PDT) Message-ID: Date: Mon, 23 Mar 2026 11:01:15 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5] arm64: dts: qcom: glymur-crd: Enable keyboard, trackpad and touchscreen To: Abel Vesa , Dmitry Baryshkov , Krzysztof Kozlowski Cc: Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260319-glymur-dts-crd-enable-kbd-tp-ts-v5-1-4a440594348b@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzIzMDA3NiBTYWx0ZWRfX/MbWf6/kAQma m31t3YlM+UVGu7AfTuhJfQWEK8Yt1SLFJHykrujn5ByaSxiSa4TDoLq/1YjgIYC46YFtq/pElgx pGrWkrmNp8mXtX3R8oZvDCEYRtxeRlX55RLGpocfgJB9dbMhOgYGBlPm/HJNuIRYCM8QrVGDBen PRPe6eJSJTY53/JTUHyi4+34sr0PobWZhyw8fdJnjbFbvDTKjV+0yO/U/u1E88byv7XzdXrt9h4 sumI/SKxyeFVgfuymh25cQnuFxcoDze0QZ7/3TH01OSroYoWY0NKX3/capOxxxaUvhEiqUnZ7Rc XJfeWiFczCilA+7CtjdSFG+uk5zzhfrfweHhoVHAG8nIH799/23iPToA8igMn4XUJZmj90yh2ip HpTyda3ki951LR0keJCE7g2vrn1UhVnro4RjDuXTAySnkaD/xwtXodHDqYtw2mYvF6fVOwoOhDA UC71IlskvLpyDhc5uVw== X-Proofpoint-ORIG-GUID: iQ3JzS0yhiNzSGAxBNB4asQ07kUH-FNg X-Authority-Analysis: v=2.4 cv=Q4DfIo2a c=1 sm=1 tr=0 ts=69c10f70 cx=c_pps a=1Os3MKEOqt8YzSjcPV0cFA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=EUspDBNiAAAA:8 a=EXM5FdCO88UtrUJ2BzMA:9 a=QEXdDO2ut3YA:10 a=hhpmQAJR8DioWGSBphRh:22 X-Proofpoint-GUID: iQ3JzS0yhiNzSGAxBNB4asQ07kUH-FNg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-23_03,2026-03-20_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 bulkscore=0 adultscore=0 lowpriorityscore=0 spamscore=0 impostorscore=0 malwarescore=0 suspectscore=0 clxscore=1015 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603230076 On 3/20/26 9:57 AM, Abel Vesa wrote: > On 26-03-20 01:52:06, Dmitry Baryshkov wrote: >> On Thu, Mar 19, 2026 at 11:11:18PM +0200, Abel Vesa wrote: >>> On 26-03-19 21:49:07, Dmitry Baryshkov wrote: >>>> On Thu, Mar 19, 2026 at 05:30:48PM +0200, Abel Vesa wrote: >>>>> On CRD, the keyboard, trackpad and touchscreen are connected over I2C >>>>> and all share a 3.3V regulator. >>>>> >>>>> So describe the regulator and each input device along with their >>>>> pinctrl states. >>>>> >>>>> Reviewed-by: Dmitry Baryshkov >>>>> Reviewed-by: Konrad Dybcio >>>>> Signed-off-by: Abel Vesa >>>>> --- >>>>> Changes in v5: >>>>> - Since this depends on Displat DT patchset and since that one >>>>> had to be respun in order to drop the non-merging phy patch >>>>> dependency, this one had to be respun as well so that the dependency >>>>> tree is correct. [...] >>>>> + ts0_default: ts0-default-state { >>>>> + int-n-pins { >>>>> + pins = "gpio51"; >>>> >>>> What was the sorting order here? I assume you had one. >>> >>> The way I see it, it should be based on state subnode name. >>> Which currently it is. >>> >>> Do you suggest some other sorting order though ? >>> >>> Thanks for reviewing! >> >> Then ts0-default-state > pcie0 > > Oh, right. Will fix that. +Krzysztof dts-coding-style should clarify this (pin state subnode sorting, IMO it would make sense to have both top-level and the child nodes sorted by the pinidx but I don't really care that much) Konrad