From: Peter Rosin <peda@axentia.se>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Sathyanarayanan Kuppuswamy Natarajan <sathyaosid@gmail.com>
Subject: Re: [PATCH v2 1/1] mux: consumer: Add dummy functions for !CONFIG_MULTIPLEXER case
Date: Sun, 9 Jul 2017 08:59:57 +0200 [thread overview]
Message-ID: <d8673232-5bb2-1679-71a8-2e5af944dd99@axentia.se> (raw)
In-Reply-To: <CAHp75VdbVx1YrO_8USJmRVjni2SW9g=3-fTWJQZaEJWOQ-RHCw@mail.gmail.com>
On 2017-07-08 23:22, Andy Shevchenko wrote:
> On Sat, Jul 8, 2017 at 9:12 PM,
> <sathyanarayanan.kuppuswamy@linux.intel.com> wrote:
>> From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>>
>> Add dummy functions to avoid compile time issues when CONFIG_MULTIPLEXER
>> is not enabled.
>>
>
> I don't think the error return code is okay to all of them. The return
> value should be choosen carefully (for some functions it's okay IMO to
> return 0).
BTW, is ENODEV correct for this situation? I have this nagging feeling
that ENODEV is over-used?
And again, all these stubs should all be inlines, or things will break it
this file is included more than once.
>> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>> ---
>> include/linux/mux/consumer.h | 38 ++++++++++++++++++++++++++++++++++++++
>> 1 file changed, 38 insertions(+)
>>
>> Changes since v1:
>> * Changed #ifdef to #if IS_ENABLED.
>>
>> diff --git a/include/linux/mux/consumer.h b/include/linux/mux/consumer.h
>> index 5577e1b..df78988 100644
>> --- a/include/linux/mux/consumer.h
>> +++ b/include/linux/mux/consumer.h
>> @@ -16,6 +16,7 @@
>> struct device;
>> struct mux_control;
>>
>> +#if IS_ENABLED(CONFIG_MULTIPLEXER)
>> unsigned int mux_control_states(struct mux_control *mux);
>> int __must_check mux_control_select(struct mux_control *mux,
>> unsigned int state);
>> @@ -29,4 +30,41 @@ void mux_control_put(struct mux_control *mux);
>> struct mux_control *devm_mux_control_get(struct device *dev,
>> const char *mux_name);
>>
>> +#else
>> +unsigned int mux_control_states(struct mux_control *mux)
>> +{
>> + return -ENODEV;
>
> Peter, is here we are obliged to return error code in such case?
Since it will presumably be difficult to obtain a mux_control
w/o the mux-core being present, it doesn't matter much what
most of these stubs return.
For this stub, 0 is perhaps best, since the kernel-doc for
mux_control_states mentions nothing about any error possibility.
>> +}
>> +
>> +int __must_check mux_control_select(struct mux_control *mux,
>> + unsigned int state)
>> +{
>> + return -ENODEV;
>
> return 0; ?
Maybe. But it doesn't matter much, but in this case the consumer must
handle errors. See above.
>> +}
>> +
>> +int __must_check mux_control_try_select(struct mux_control *mux,
>> + unsigned int state)
>> +{
>> + return -ENODEV;
>> +}
>
> return 0; ?
Maybe. But it doesn't matter much, but in this case the consumer must
handle errors. See above.
>> +
>> +int mux_control_deselect(struct mux_control *mux)
>> +{
>> + return -ENODEV;
>> +}
>
> return 0; ?
Probably. See above.
Cheers,
peda
>> +
>> +struct mux_control *mux_control_get(struct device *dev, const char *mux_name)
>> +{
>> + return ERR_PTR(-ENODEV);
>> +}
>> +
>> +void mux_control_put(struct mux_control *mux) {}
>> +
>> +struct mux_control *devm_mux_control_get(struct device *dev,
>> + const char *mux_name)
>> +{
>> + return ERR_PTR(-ENODEV);
>> +}
>> +#endif
>> +
>> #endif /* _LINUX_MUX_CONSUMER_H */
>> --
>> 2.7.4
>>
>
>
>
next prev parent reply other threads:[~2017-07-09 7:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-08 18:12 sathyanarayanan.kuppuswamy
2017-07-08 21:22 ` Andy Shevchenko
2017-07-09 6:59 ` Peter Rosin [this message]
2017-07-09 7:42 ` Kuppuswamy, Sathyanarayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8673232-5bb2-1679-71a8-2e5af944dd99@axentia.se \
--to=peda@axentia.se \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=sathyaosid@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®