From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Cc: stable@vger.kernel.org
Subject: Re: [PATCH] serial: Fix not set tty->port race condition
Date: Thu, 22 Jan 2026 18:11:59 +0100 [thread overview]
Message-ID: <d86ad878-a125-41c9-a0a3-bc24c926ba55@oss.qualcomm.com> (raw)
In-Reply-To: <20260122170031.433724-2-krzysztof.kozlowski@oss.qualcomm.com>
On 22/01/2026 18:00, Krzysztof Kozlowski wrote:
> Revert commit bfc467db60b7 ("serial: remove redundant
> tty_port_link_device()") because the tty_port_link_device() is not
And grumpy side note because I was looking at this for more than a day
blaming my new hardware:
I really wish commits (e.g. bfc467db60b7) calling something redundant
had that much of message written why something is redundant as the
commit (fb2b90014d78) which introduced that part of code.
If someone wrote one page of text why foo is needed, we should write not
less why it is not needed :)
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-22 17:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 17:00 Krzysztof Kozlowski
2026-01-22 17:11 ` Krzysztof Kozlowski [this message]
2026-01-23 5:59 ` Jiri Slaby
2026-01-23 5:55 ` Jiri Slaby
2026-01-23 7:13 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d86ad878-a125-41c9-a0a3-bc24c926ba55@oss.qualcomm.com \
--to=krzysztof.kozlowski@oss.qualcomm.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®