From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Vineet Gupta <Vineet.Gupta1@synopsys.com>
Cc: "linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
Alexey Brodkin <Alexey.Brodkin@synopsys.com>,
Andrea Gelmini <andrea.gelmini@gelma.net>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Noam Camus <noamc@ezchip.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: ARC-setup: Use seq_putc() in show_cpuinfo()
Date: Mon, 17 Oct 2016 19:19:14 +0200 [thread overview]
Message-ID: <d8738585-21f3-8691-4c53-bfbafef925be@users.sourceforge.net> (raw)
In-Reply-To: <579aaf85-c22d-b680-5ce8-3c0e23ab6d7e@synopsys.com>
>> A single character (line break) should be put into a sequence.
>> Thus use the corresponding function "seq_putc".
>
> Perhaps reword the changelog to say that seqc_putc is more efficient than
> seqc_printf to output a single char.
> I mean _printf is not wrong but not as efficient ?
I came along source files for a few other software modules with similar
change possibilities.
Unfortunately, the corresponding developers are not convinced yet
to replace a call of the function "seq_printf" at the end by
a "seq_putc" because of software efficiency reasons.
Do you find this update suggestion acceptable to some degree
for the function "setup"?
Regards,
Markus
next prev parent reply other threads:[~2016-10-17 17:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-15 19:56 [PATCH] " SF Markus Elfring
2016-10-17 16:25 ` Vineet Gupta
2016-10-17 17:19 ` SF Markus Elfring [this message]
2016-10-17 17:23 ` Vineet Gupta
2016-10-17 17:39 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8738585-21f3-8691-4c53-bfbafef925be@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=Alexey.Brodkin@synopsys.com \
--cc=Vineet.Gupta1@synopsys.com \
--cc=andrea.gelmini@gelma.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=noamc@ezchip.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome