From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Rob Herring <robh@kernel.org>
Cc: Mark Brown <broonie@kernel.org>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Patrick Lai <plai@codeaurora.org>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
spapothi@codeaurora.org
Subject: Re: [PATCH v1 1/2] ASoC: qcom: dt-bindings: Add SM8250 sound card bindings
Date: Thu, 29 Oct 2020 09:40:00 +0000 [thread overview]
Message-ID: <d876d014-8342-e1b9-7773-86995d7d79f6@linaro.org> (raw)
In-Reply-To: <CAL_JsqLUYCrqbgxJPc_CTH9MtQo=h4JBqcmpgwJgWncyLN2gtQ@mail.gmail.com>
On 28/10/2020 18:24, Rob Herring wrote:
> On Wed, Oct 28, 2020 at 10:19 AM Srinivas Kandagatla
> <srinivas.kandagatla@linaro.org> wrote:
>>
>>
>>
>> On 28/10/2020 15:01, Rob Herring wrote:
>>>> + - const: qcom,sm8250
>>>
>>> This collides with the top level SoC compatible resulting in:
>>>
>>
>> I did run dt_binding_check before sending out this patch, I might have
>> missed it somehow because the make dt_binding_check did not
>> end/termnitate in any errors, however if I had scrolled 15-20 Page ups
>> it does have this error log!
>
> make -sk
Thanks for the hint!
>
> :)
>
>> Documentation/devicetree/bindings/arm/qcom.yaml does have
>> qcom,qrb5165-rb5 entry under [qcom,sm8250]
>>
>> Can you help me understand why is this not a valid compatible?
>
> Those compatibles are used at the top level for the SoC. You can't use
> the same compatible to mean 2 different things.
>
Thanks for explaining this, This is now modified to
"qcom,qrb5165-rb5-sndcard"
"qcom,sm8250-sndcard"
I do not see any complains from dt_binding_check.
also makes it inline with other qcom soundcard compatible strings!
--srini
> Rob
>
next prev parent reply other threads:[~2020-10-29 9:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-26 17:09 [PATCH v1 0/2] ASoC: qcom: add support for QRB5165 RB5 machine Srinivas Kandagatla
2020-10-26 17:09 ` [PATCH v1 1/2] ASoC: qcom: dt-bindings: Add SM8250 sound card bindings Srinivas Kandagatla
2020-10-28 15:01 ` Rob Herring
2020-10-28 15:19 ` Srinivas Kandagatla
2020-10-28 18:24 ` Rob Herring
2020-10-29 9:40 ` Srinivas Kandagatla [this message]
2020-10-26 17:09 ` [PATCH v1 2/2] ASoC: qcom: sm8250: add sound card qrb5165-rb5 support Srinivas Kandagatla
2020-10-26 23:46 ` [PATCH v1 0/2] ASoC: qcom: add support for QRB5165 RB5 machine Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d876d014-8342-e1b9-7773-86995d7d79f6@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=plai@codeaurora.org \
--cc=robh@kernel.org \
--cc=spapothi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®