mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: John Johansen <john.johansen@canonical.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: LKLM <linux-kernel@vger.kernel.org>,
	Colin Ian King <colin.king@canonical.com>
Subject: Re: [PATCH] apparmor: fix off-by-one comparison on MAXMAPPED_SIG
Date: Wed, 8 Nov 2017 11:11:57 -0800	[thread overview]
Message-ID: <d87710ed-0333-8785-ddaf-269b3196ef47@canonical.com> (raw)
In-Reply-To: <CA+55aFz=fim-At4bdVz0Jte8WNU2BwUk_DHMw53hnpY+Q7LuSA@mail.gmail.com>

On 11/08/2017 10:53 AM, Linus Torvalds wrote:
> On Wed, Nov 8, 2017 at 8:09 AM, John Johansen
> <john.johansen@canonical.com> wrote:
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>> Signed-off-by: John Johansen <john.johansen@canonical.com>
> 
> This sign-off chain is odd. It implies that the patch came from Colin
> King, bnut it lacks authorship attribution.
> 
> So who authored this?
> 
> If it was Colin, there should have been a
> 
>     From: Colin Ian King <colin.king@canonical.com>
> 
> at the top.
> 
> So either the authorship is broken, or the sign-off chain is. Which is it?
> 
The initial patch is from Colin it covered the 1st of the 2 cases. I edited the
patch, adding the second case and added a revision note then I messed up the mail.
Rushing to get this out (I dumped it into the regular mail client instead of
using git mail).

I should have just sent the request pull

The following changes since commit 8b50f0a6261b3b6e6c7ef9febe7ab8a973243ba3:

  apparmor: fix off-by-one comparison on MAXMAPPED_SIG (2017-11-08 07:49:53 -0800)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/jj/linux-apparmor aa-for-up

for you to fetch changes up to 8b50f0a6261b3b6e6c7ef9febe7ab8a973243ba3:

  apparmor: fix off-by-one comparison on MAXMAPPED_SIG (2017-11-08 07:49:53 -0800)

----------------------------------------------------------------

  parent reply	other threads:[~2017-11-08 19:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-08 16:09 John Johansen
2017-11-08 18:53 ` Linus Torvalds
2017-11-08 18:56   ` Linus Torvalds
2017-11-08 19:11   ` John Johansen [this message]
2017-11-08 19:54   ` John Johansen
  -- strict thread matches above, loose matches on Subject: below --
2017-08-22 21:58 Colin King
2017-09-25 14:21 ` John Johansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d87710ed-0333-8785-ddaf-269b3196ef47@canonical.com \
    --to=john.johansen@canonical.com \
    --cc=colin.king@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®