From: Karthik S <karthik.s@oss.qualcomm.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Bartosz Golaszewski <brgl@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Linus Walleij <linusw@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] pinctrl: qcom: Add qcs615 lpass lpi pinctrl driver
Date: Tue, 17 Nov 2026 12:56:29 +0530 [thread overview]
Message-ID: <d880b084-ed36-488c-98bf-fe9acf757464@oss.qualcomm.com> (raw)
In-Reply-To: <83509feb-8776-4f61-9bc8-aca27d7c234b@oss.qualcomm.com>
On 9/8/2026 6:32 PM, Konrad Dybcio wrote:
> This patch produces dozens of compile warnings and is not split properly per
> subsystem.
>
> Also, it looks like the data you provided here is a subset of
> pinctrl-sdm670-lpass-lpi.c - is there a chance that the block is directly
> copy-pasted between these SoCs? Are the extra functions present on 670 also
> present on QCS615?
Hi Konrad,
Initially the i2s1 functionality seem to be similar between this new
pinctrl driver and sdm670, but now for further implementation upon
further inspection , there seems to be differences between the
functionality of this new pinctrl driver and sdm670 for example : i2s2
functions from LPI GPIO 23-28, will send v2 with new functions, hence we
will prefer going with this new pinctrl driver
Thanks,
Karthik S
next prev parent reply other threads:[~2026-11-17 7:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 7:58 [PATCH v1 0/2] pinctrl: qcom: Add QCS615 LPASS LPI pinctrl support Karthik S
2026-09-08 7:58 ` [PATCH v1 1/2] dt-bindings: pinctrl: qcom: Add QCS615 LPASS LPI pinctrl bindings Karthik S
2026-09-08 7:58 ` [PATCH v1 2/2] pinctrl: qcom: Add qcs615 lpass lpi pinctrl driver Karthik S
2026-09-08 13:02 ` Konrad Dybcio
2026-09-17 12:05 ` Karthik S
2026-09-18 11:31 ` Karthik S
2026-11-17 7:26 ` Karthik S [this message]
2026-09-08 14:58 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d880b084-ed36-488c-98bf-fe9acf757464@oss.qualcomm.com \
--to=karthik.s@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=brgl@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®