From: Chanwoo Choi <cw00.choi@samsung.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
linux-kernel@vger.kernel.org, Lee Jones <lee.jones@linaro.org>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH 09/16] mfd: max77686: drop of_match_ptr from of_device_id table
Date: Mon, 23 Nov 2020 14:12:05 +0900 [thread overview]
Message-ID: <d8812dd1-1912-edac-d2a7-eb2462ab1923@samsung.com> (raw)
In-Reply-To: <20201120162133.472938-9-krzk@kernel.org>
Hi Krzysztof,
On 11/21/20 1:21 AM, Krzysztof Kozlowski wrote:
> The driver can match only via the DT table so the table should be always
> used and the of_match_ptr does not have any sense (this also allows ACPI
> matching via PRP0001, even though it is not relevant here). This fixes
> compile warning (!CONFIG_OF on x86_64):
>
> drivers/mfd/max77686.c:148:34: warning: ‘max77686_pmic_dt_match’ defined but not used [-Wunused-const-variable=]
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/mfd/max77686.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/max77686.c b/drivers/mfd/max77686.c
> index 71faf503844b..2ad554b921d9 100644
> --- a/drivers/mfd/max77686.c
> +++ b/drivers/mfd/max77686.c
> @@ -270,7 +270,7 @@ static struct i2c_driver max77686_i2c_driver = {
> .driver = {
> .name = "max77686",
> .pm = &max77686_pm,
> - .of_match_table = of_match_ptr(max77686_pmic_dt_match),
> + .of_match_table = max77686_pmic_dt_match,
> },
> .probe_new = max77686_i2c_probe,
> };
>
Acked-by: Chanwoo Choi <cw00.choi@samsung.com>
--
Best Regards,
Chanwoo Choi
Samsung Electronics
next prev parent reply other threads:[~2020-11-23 4:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-20 16:21 [PATCH 01/16] mfd: bcm590xx: " Krzysztof Kozlowski
2020-11-20 16:21 ` [PATCH 02/16] mfd: da9055: " Krzysztof Kozlowski
2020-11-20 16:21 ` [PATCH 03/16] mfd: da9062: " Krzysztof Kozlowski
2020-11-20 16:21 ` [PATCH 04/16] mfd: da9063: " Krzysztof Kozlowski
2020-11-20 16:21 ` [PATCH 05/16] mfd: da9150: " Krzysztof Kozlowski
2020-11-20 16:21 ` [PATCH 06/16] mfd: ene-kb3930: " Krzysztof Kozlowski
2020-11-20 16:21 ` [PATCH 07/16] mfd: fsl-imx25: " Krzysztof Kozlowski
2020-11-20 16:21 ` [PATCH 08/16] mfd: max77650: " Krzysztof Kozlowski
2020-11-20 16:21 ` [PATCH 09/16] mfd: max77686: " Krzysztof Kozlowski
2020-11-23 5:12 ` Chanwoo Choi [this message]
2020-11-20 16:21 ` [PATCH 10/16] mfd: mt6397: " Krzysztof Kozlowski
2020-11-20 16:21 ` [PATCH 11/16] mfd: rt5033: " Krzysztof Kozlowski
2020-11-20 16:21 ` [PATCH 12/16] mfd: stmfx: " Krzysztof Kozlowski
2020-11-20 16:21 ` [PATCH 13/16] mfd: sun4i: " Krzysztof Kozlowski
2020-11-20 16:21 ` [PATCH 14/16] mfd: wm8994: " Krzysztof Kozlowski
2020-11-20 17:02 ` Charles Keepax
2020-11-20 16:21 ` [PATCH 15/16] mfd: axp20x: skip of_device_id table when !CONFIG_OF Krzysztof Kozlowski
2020-11-20 16:41 ` Chen-Yu Tsai
2020-11-20 16:21 ` [PATCH 16/16] mfd: twl6030: mark of_device_id table as maybe unused Krzysztof Kozlowski
2020-11-27 8:06 ` [PATCH 01/16] mfd: bcm590xx: drop of_match_ptr from of_device_id table Lee Jones
2020-11-27 8:17 ` Krzysztof Kozlowski
2020-11-27 9:17 ` Lee Jones
2020-11-27 11:37 ` Miguel Ojeda
2020-11-27 13:20 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8812dd1-1912-edac-d2a7-eb2462ab1923@samsung.com \
--to=cw00.choi@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=krzk@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®