From: Tadeusz Struk <tadeusz.struk@intel.com>
To: Laura Abbott <labbott@redhat.com>,
Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Cc: "linux-integrity@vger.kernel.org"
<linux-integrity@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Kees Cook <keescook@chromium.org>
Subject: Re: Bad usercopy from tpm after d23d12484307 ("tpm: fix invalid locking in NONBLOCKING mode")
Date: Tue, 7 Jan 2020 12:27:46 -0800 [thread overview]
Message-ID: <d8873e8d-358c-18f7-69b8-9c2467eafc4c@intel.com> (raw)
In-Reply-To: <b85fa669-d3aa-f6c9-9631-988ae47e392c@redhat.com>
On 1/7/20 10:51 AM, Laura Abbott wrote:
> I think this is related to d23d12484307 ("tpm: fix invalid locking in
> NONBLOCKING mode")
> Specifically, if tpm_try_get_ops fails I don't think we should be
> putting the error
> code in priv->response_length since tpm_common_read doesn't seem to
> account for
> negative errno values.
>
> I don't have a reproducer since this was just what was reported to
> Fedora's bug
> reporter but both reports happened after that commit landed in stable.
Thank you for the report Laura. Fix is on the way.
--
Tadeusz
next prev parent reply other threads:[~2020-01-07 20:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-07 18:51 Laura Abbott
2020-01-07 20:27 ` Tadeusz Struk [this message]
2020-01-07 22:04 ` [PATCH] tpm: handle negative priv->response_len in tpm_common_read Tadeusz Struk
2020-01-08 15:58 ` Jarkko Sakkinen
2020-01-08 16:04 ` Jarkko Sakkinen
2020-01-08 17:47 ` Tadeusz Struk
2020-01-13 0:07 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d8873e8d-358c-18f7-69b8-9c2467eafc4c@intel.com \
--to=tadeusz.struk@intel.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=keescook@chromium.org \
--cc=labbott@redhat.com \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®