From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932189AbdBJTWw (ORCPT ); Fri, 10 Feb 2017 14:22:52 -0500 Received: from ale.deltatee.com ([207.54.116.67]:37313 "EHLO ale.deltatee.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753863AbdBJTWu (ORCPT ); Fri, 10 Feb 2017 14:22:50 -0500 To: Dan Williams , Johannes Thumshirn , "Paul E. McKenney" , Sajjan Vikas C , Arnd Bergmann , Jan Kara References: <1486754370-3057-1-git-send-email-logang@deltatee.com> Cc: linux-kernel@vger.kernel.org, linux-nvdimm@ml01.01.org From: Logan Gunthorpe Message-ID: Date: Fri, 10 Feb 2017 12:22:48 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Icedove/45.6.0 MIME-Version: 1.0 In-Reply-To: <1486754370-3057-1-git-send-email-logang@deltatee.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 172.16.1.111 X-SA-Exim-Rcpt-To: linux-nvdimm@lists.01.org, linux-kernel@vger.kernel.org, jack@suse.cz, arnd@arndb.de, vikas.cha.sajjan@hpe.com, paulmck@linux.vnet.ibm.com, jthumshirn@suse.de, dan.j.williams@intel.com X-SA-Exim-Mail-From: logang@deltatee.com Subject: Re: [PATCH] device-dax: don't set kobj parent during cdev init X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on ale.deltatee.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hey, Also on the subject of very minor fixes: I noticed drivers/dax is not in the maintainers file. I just assumed the nvdimm list should have been included with those from get_maintainers. Thanks, Logan On 10/02/17 12:19 PM, Logan Gunthorpe wrote: > I copied this code and per feedback from Greg Kroah-Hartman [1] the > cdev's kobject's parent should not be set to the related device. > This should have minor consequences but isn't doing what anyone > expects it to. > > This patch then fixes device-dax so it doesn't make the same mistake. > > [1] https://lkml.org/lkml/2017/2/10/370 > > Signed-off-by: Logan Gunthorpe > --- > drivers/dax/dax.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/dax/dax.c b/drivers/dax/dax.c > index ed758b7..24e53b7 100644 > --- a/drivers/dax/dax.c > +++ b/drivers/dax/dax.c > @@ -699,13 +699,9 @@ struct dax_dev *devm_create_dax_dev(struct dax_region *dax_region, > goto err_inode; > } > > - /* device_initialize() so cdev can reference kobj parent */ > - device_initialize(dev); > - > cdev = &dax_dev->cdev; > cdev_init(cdev, &dax_fops); > cdev->owner = parent->driver->owner; > - cdev->kobj.parent = &dev->kobj; > rc = cdev_add(&dax_dev->cdev, dev_t, 1); > if (rc) > goto err_cdev; > @@ -722,7 +718,7 @@ struct dax_dev *devm_create_dax_dev(struct dax_region *dax_region, > dev->groups = dax_attribute_groups; > dev->release = dax_dev_release; > dev_set_name(dev, "dax%d.%d", dax_region->id, dax_dev->id); > - rc = device_add(dev); > + rc = device_register(dev); > if (rc) { > put_device(dev); > return ERR_PTR(rc); >