From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17054C43467 for ; Thu, 8 Oct 2020 07:29:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9FD5F2173E for ; Thu, 8 Oct 2020 07:29:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="VjUejw/F" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726761AbgJHH3u (ORCPT ); Thu, 8 Oct 2020 03:29:50 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:46432 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725849AbgJHH3u (ORCPT ); Thu, 8 Oct 2020 03:29:50 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0987ThGe055125; Thu, 8 Oct 2020 02:29:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1602142183; bh=0fJP+PjiMjaHur0vYWV+WdV/MjQ3t6LWtmw89pujeog=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=VjUejw/FNINArgmkrPMZaGBvN+Jr2FTp/BG0ltrftx4XDh6ULdu/E8VshoGzfpOZ5 i5BJdhNeFV5DOKiCajZK1xvXEv50MOVMuolDx/GEJWYj28zM8bQD2yQ6DMrsAtZIWN VjaFuDkPiQFj2u0FII84rukeF/VxUg5jE4byemYU= Received: from DLEE115.ent.ti.com (dlee115.ent.ti.com [157.170.170.26]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0987ThLv126887 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 8 Oct 2020 02:29:43 -0500 Received: from DLEE106.ent.ti.com (157.170.170.36) by DLEE115.ent.ti.com (157.170.170.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Thu, 8 Oct 2020 02:29:43 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Thu, 8 Oct 2020 02:29:43 -0500 Received: from [192.168.2.14] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0987TfRt088630; Thu, 8 Oct 2020 02:29:41 -0500 Subject: =?UTF-8?B?UmU6IFtQQVRDSCAyLzJdIHVzYjogY2RuczM6IFZhcmlhYmxlIOKAmGxl?= =?UTF-8?Q?ngth=e2=80=99_set_but_not_used?= To: Pawel Laszczak , Sergei Shtylyov , "balbi@kernel.org" CC: "peter.chen@nxp.com" , "nsekhar@ti.com" , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Rahul Kumar References: <20201007033932.23050-1-pawell@cadence.com> <8994106d-2cc5-fa2c-bbcc-6526632ff80b@ti.com> <18bf46b7-d86a-fbf0-9ce7-c2d0765758f1@gmail.com> From: Roger Quadros Message-ID: Date: Thu, 8 Oct 2020 10:29:40 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pawel, On 08/10/2020 06:57, Pawel Laszczak wrote: > Siergei, > >> >> On 10/7/20 11:15 AM, Roger Quadros wrote: >> >> [...] >>>> Patch removes not used variable 'length' from >>>> cdns3_wa2_descmiss_copy_data function. >>>> >>>> Signed-off-by: Pawel Laszczak >>> >>> Fixes: commit 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case") >> >> No "commit" is needed here. > > Can you explain why? > > I guess it's because commit 141e70fef4ee is quite new and it's not yet included in any stable kernel version, > or because it's only warning - not error. > > Am I right ? Siergei meant that the word "commit" should not be used. So it should be Fixes: 141e70fef4ee ("usb: cdns3: gadget: need to handle sg case for workaround 2 case") cheers, -roger > >> >>> Acked-by: Roger Quadros >> [...] >> > > Regards, > Pawel > -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki