From: Damien Le Moal <dlemoal@kernel.org>
To: Genjian <zhanggenjian@126.com>,
axboe@kernel.dk, shinichiro.kawasaki@wdc.com,
johannes.thumshirn@wdc.com, kch@nvidia.com,
zhengqixing@huawei.com, willy@infradead.org,
namcao@linutronix.de, vincent.fu@samsung.com
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Genjian Zhang <zhanggenjian@kylinos.cn>
Subject: Re: [PATCH] null_blk: Fix correct parameter desc for the module
Date: Fri, 15 Aug 2025 14:23:50 +0900 [thread overview]
Message-ID: <d892eb87-6ee2-40a4-9b25-66c2f2e8befa@kernel.org> (raw)
In-Reply-To: <20250815043033.1534949-1-zhanggenjian@126.com>
On 8/15/25 13:30, Genjian wrote:
> From: Genjian Zhang <zhanggenjian@kylinos.cn>
The patch title is a little strange. What about:
null_blk: Fix the description of the cache_size module argument
>
> When executing modinfo null_blk, there is an error in the description
> of module parameter mbps, and the output information of cache_size is
> incomplete.The output of modinfo before and after applying this patch
> is as follows:
>
> Before:
> [...]
> parm: cache_size:ulong
> [...]
> parm: mbps:Cache size in MiB for memory-backed device.
> Default: 0 (none) (uint)
> [...]
>
> After:
> [...]
> parm: cache_size:Cache size in MiB for memory-backed device.
> Default: 0 (none) (ulong)
> [...]
> parm: mbps:Limit maximum bandwidth (in MiB/s).
> Default: 0 (no limit) (uint)
> [...]
>
> Fixes: 058efe000b31 ("null_blk: add module parameters for 4 options")
>
Remove the blank line here.
> Signed-off-by: Genjian Zhang <zhanggenjian@kylinos.cn>
With these fixed,
Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-08-15 5:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 4:30 Genjian
2025-08-15 5:23 ` Damien Le Moal [this message]
2025-08-15 8:53 ` genjian zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d892eb87-6ee2-40a4-9b25-66c2f2e8befa@kernel.org \
--to=dlemoal@kernel.org \
--cc=axboe@kernel.dk \
--cc=johannes.thumshirn@wdc.com \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namcao@linutronix.de \
--cc=shinichiro.kawasaki@wdc.com \
--cc=vincent.fu@samsung.com \
--cc=willy@infradead.org \
--cc=zhanggenjian@126.com \
--cc=zhanggenjian@kylinos.cn \
--cc=zhengqixing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®