From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D6F6C04A6A for ; Mon, 7 Aug 2023 09:09:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231271AbjHGJJb (ORCPT ); Mon, 7 Aug 2023 05:09:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231208AbjHGJJ3 (ORCPT ); Mon, 7 Aug 2023 05:09:29 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9B084E6C; Mon, 7 Aug 2023 02:09:27 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 0BDCF8016; Mon, 7 Aug 2023 17:09:21 +0800 (CST) Received: from EXMBX061.cuchost.com (172.16.6.61) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 7 Aug 2023 17:09:20 +0800 Received: from [192.168.125.128] (113.72.146.246) by EXMBX061.cuchost.com (172.16.6.61) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Mon, 7 Aug 2023 17:09:19 +0800 Message-ID: Date: Mon, 7 Aug 2023 17:04:47 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v1 5/5] riscv: dts: starfive: Add the nodes and pins of I2Srx/I2Stx0/I2Stx1 Content-Language: en-US To: Krzysztof Kozlowski , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Maxim Kochetkov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Emil Renner Berthing CC: Jose Abreu , Paul Walmsley , Palmer Dabbelt , Albert Ou , Walker Chen , , , , References: <20230802084301.134122-1-xingyu.wu@starfivetech.com> <20230802084301.134122-6-xingyu.wu@starfivetech.com> <8fc27960-fa82-c900-0414-75b10a118f15@linaro.org> From: Xingyu Wu In-Reply-To: <8fc27960-fa82-c900-0414-75b10a118f15@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [113.72.146.246] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX061.cuchost.com (172.16.6.61) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/8/6 5:04, Krzysztof Kozlowski wrote: > On 02/08/2023 10:43, Xingyu Wu wrote: >> Add I2Srx/I2Stx0/I2Stx1 nodes and pins configuration for the >> StarFive JH7110 SoC. >> >> Signed-off-by: Xingyu Wu >> --- > > ... > >> + >> spi0_pins: spi0-0 { >> mosi-pins { >> pinmux = > diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi >> index 05f843b8ca03..507312eb6053 100644 >> --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi >> +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi >> @@ -512,6 +512,30 @@ tdm: tdm@10090000 { >> status = "disabled"; >> }; >> >> + i2srx: i2srx@100e0000 { > > Node names should be generic, so: > i2s@ Will fix. Thanks. > >> + compatible = "starfive,jh7110-i2srx"; >> + reg = <0x0 0x100e0000 0x0 0x1000>; >> + clocks = <&syscrg JH7110_SYSCLK_I2SRX_BCLK_MST>, >> + <&syscrg JH7110_SYSCLK_I2SRX_APB>, >> + <&syscrg JH7110_SYSCLK_MCLK>, >> + <&syscrg JH7110_SYSCLK_MCLK_INNER>, >> + <&mclk_ext>, >> + <&syscrg JH7110_SYSCLK_I2SRX_BCLK>, >> + <&syscrg JH7110_SYSCLK_I2SRX_LRCK>, >> + <&i2srx_bclk_ext>, >> + <&i2srx_lrck_ext>; >> + clock-names = "i2sclk", "apb", "mclk", >> + "mclk_inner", "mclk_ext", "bclk", >> + "lrck", "bclk_ext", "lrck_ext"; >> + resets = <&syscrg JH7110_SYSRST_I2SRX_APB>, >> + <&syscrg JH7110_SYSRST_I2SRX_BCLK>; >> + dmas = <0>, <&dma 24>; >> + dma-names = "tx", "rx"; >> + starfive,syscon = <&sys_syscon 0x18 0x2>; >> + #sound-dai-cells = <0>; >> + status = "disabled"; >> + }; >> + >> usb0: usb@10100000 { >> compatible = "starfive,jh7110-usb"; >> ranges = <0x0 0x0 0x10100000 0x100000>; >> @@ -736,6 +760,47 @@ spi6: spi@120a0000 { >> status = "disabled"; >> }; >> >> + i2stx0: i2stx0@120b0000 { > > i2s@ Will fix. > >> + compatible = "starfive,jh7110-i2stx0"; >> + reg = <0x0 0x120b0000 0x0 0x1000>; >> + clocks = <&syscrg JH7110_SYSCLK_I2STX0_BCLK_MST>, >> + <&syscrg JH7110_SYSCLK_I2STX0_APB>, >> + <&syscrg JH7110_SYSCLK_MCLK>, >> + <&syscrg JH7110_SYSCLK_MCLK_INNER>, >> + <&mclk_ext>; >> + clock-names = "i2sclk", "apb", "mclk", >> + "mclk_inner","mclk_ext"; >> + resets = <&syscrg JH7110_SYSRST_I2STX0_APB>, >> + <&syscrg JH7110_SYSRST_I2STX0_BCLK>; >> + dmas = <&dma 47>; >> + dma-names = "tx"; >> + #sound-dai-cells = <0>; >> + status = "disabled"; >> + }; >> + >> + i2stx1: i2stx1@120c0000 { > > i2s@ Will fix. Best regards, Xingyu Wu